From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C27FA04A2; Thu, 3 Mar 2022 17:11:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2199B40687; Thu, 3 Mar 2022 17:11:13 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id C6ECF40395; Thu, 3 Mar 2022 17:11:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646323871; x=1677859871; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=JDAFUAqgoxVSinuVNniZ3nm7H7APYrypbuItT8/v7ME=; b=LlCTGPqhLOBjLgnXKRl5skgS+AYERZlujzI7oS/DNO5HrKXVtHks5Bd5 SYQAZdangR52mfrCrf+9Vjx8+ZqXIVXTUFYOyK8bmfeG0o4GfBN9Wsd2v uA8RD0mZC9r9udXK3r6X3eIBg7ZPNzhcmo1HYP8bp7GZFOnFgRD8FIKwI 3Cl5LrAYLqcpBteZJ7fWnnLE9i7V6RgIC+VtH7TyhbhSeLpbemYVZLswF DQU/fsdehCr/W/jVjqJRJ54Vq/1n1v/7jdFFEJj5FDF+6g990SZmJxsx1 p+WhjlbK8NarSGqzepj/g5FB2eX+CMfOtere0fbYqxSsHiisumUz1I2Q/ Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10275"; a="314429580" X-IronPort-AV: E=Sophos;i="5.90,151,1643702400"; d="scan'208";a="314429580" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2022 08:07:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,151,1643702400"; d="scan'208";a="709969001" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 03 Mar 2022 08:07:38 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 3 Mar 2022 08:07:38 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Thu, 3 Mar 2022 08:07:38 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Thu, 3 Mar 2022 08:07:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GJCRUZ7jjIU+X8APUvvok754EWdi8ExCSd2EkOVytl59B3y0JxBFMvDseSoaXBm0/ouiMvTcm1hopHrPnyBLowilfgnLSmSFM+Qo32STzc0nmTuT8aldOuAuJZltEVwNEGEpOi7DJjNsgRvn46VGZ2oYjw9ucT3Fz2h4aO7twksgDtlL6eZ3o7en60iemsIYo6UHdAjpkmb4HJY/L3CEJ5bQaeP8bX/kNmwF3FeGSocixqyqcd8P10xwGAkg9d2AmDn1LBwsLdgDeqvGvQgdSvREd66R4CuXYvo1VWvN9QtJTK3AKbHY79mguk7ntYtD5qWvLG+8gLfHprrXlHL61Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gJWRBHcfnH+mJw4dR3zVJH+/i7e75ueYFVA8iTicbFQ=; b=K3XMjD2ejlGfgsoBGWtjLJJVmcq5UPhza1SazQGB6aHnxRdgY3iPPBQFJDfPxuHibUr6rcJB1jt9+kscQz2PtfEXc97JGwBE3e8ISNRR60fGVnPi3ZueHULF1nm0kkUkkHFlsRvf3vU7kAtE0Q/j1f2nYB0+Wg9gw5futkzrHuvrLQVuHllUFHFgiah3XFpL07M1LJXOrTcs4JCkARUMrw0mwR1gEg4YH8NV5SqDSo4V1eIh+30zqswUM4llBZbkYr8AviPTnamk+E6VbpLFQUUFky5o8fEJSfgrSmJ9PH1L5vKjrK/JMyjqT/T8aJNJPZ1rJicz+jsnmk90ZhbH9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BL1PR11MB5367.namprd11.prod.outlook.com (2603:10b6:208:318::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Thu, 3 Mar 2022 16:07:36 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf%7]) with mapi id 15.20.5038.015; Thu, 3 Mar 2022 16:07:36 +0000 Message-ID: <67896084-e08e-4615-8992-84524f220b1b@intel.com> Date: Thu, 3 Mar 2022 16:07:29 +0000 Content-Language: en-US To: Gregory Etelson , CC: , , , "Viacheslav Ovsiienko" , Stephen Hemminger References: <20220301151856.17341-1-getelson@nvidia.com> <20220301151856.17341-2-getelson@nvidia.com> From: Ferruh Yigit Subject: Re: [PATCH 2/2] net/mlx5: fix INET IPIP protocol type X-User: ferruhy In-Reply-To: <20220301151856.17341-2-getelson@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR07CA0165.eurprd07.prod.outlook.com (2603:10a6:6:43::19) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f95f0bf5-75a4-4ac6-af99-08d9fd2fee8e X-MS-TrafficTypeDiagnostic: BL1PR11MB5367:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Yg6+DHI3/YXqwbKjUd96PY9VQx/eSiW+emJ1qBqkgS7dSEwkTpwPptvPpvISUONl4QLPp3nN1mXhEmDN7JO4NoOeMQFjjW37bni50mrGFBuOV5M9QNHcTgayGB2W/giZsa5cpwA0B91bgIugSTOC2Xh5OCVg/QbjhYCgU+NlrIlnclF26fkDlBr6NdutSVrKQiOZtPTJUpxJ36h9bfjUavx2PzxefIsImxg2Y6QAZ+CxJQuLnEbZm2wuj5+0FkBnf69rPbITaBawjgzajzKorqHGB8ybMHB3TPv5Aggzj6JozPdhu5H8CVtC+WIjOvSXVSFSK4pp753MMxyPwXjBofk2gTPfmHsRhw0Hnhfdqoiw6Bnw0BzjjZ6O8xAnF0ij1qUkNFFgiUV9ZtGGLXx5FmIpq5RyFCUYiwf1b5Kd4BgkhcHdt9F2LmoRBN12dSg9MfSlfLbHJBQbD5dgTGE+6l84yEzViu9k8/l6a1oAKa6n/htTmLou4+M1Cdo/niMtyTT5M4mf10ud7uEE19QBeRuGSZ/MFqsITm1T3LL3n9FU/V8iXiPi19adTpdUDjWVelpHduDZqUtXa9l6lXiylA5jrAUM8WemdS0C9ZGRA1r2ISiy/GgsxqGxDohxdq2lc2QN4JmVpXdwMD7weXxE7MpaBYWqogBXXv9kY07rW31hmYxc8cZv97fAIg7BhONa+iH5yZe5KvwQ6yFFHi3KNebLiEzo8aJGIzJNUk2X6U84ubdkgzgy3koxR807gOvoLrASWy2tx6c/XZYmrzYZIzX25UQao+ARk0k/NmnxtSo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66476007)(66556008)(8676002)(2616005)(66946007)(31686004)(53546011)(8936002)(966005)(6486002)(4326008)(5660300002)(54906003)(316002)(6666004)(44832011)(36756003)(508600001)(31696002)(86362001)(38100700002)(6506007)(83380400001)(2906002)(6512007)(26005)(186003)(82960400001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NzVBNHJhM1NhRnp3NWJPeFZqRDZCcmV6eVMzbnE0UEs5MGNaTm1hTXpvakda?= =?utf-8?B?TFNBMjkyek5hK2NBa3FmVHlBTEtHb3FIYThlZWV1eVVkdjAweFdlNGVNRGtG?= =?utf-8?B?RjZUUjBjZDJwMFUvRmo4dk5SdlpUQlo5OGs0L0RDaEdqVlltbmlvdXkwdDN0?= =?utf-8?B?NXU1Z2JtL3VETDZHbWZBek54cWl5Q3VGelRGUGFrYUNpWjJ6TXJzaVlaN29J?= =?utf-8?B?MVlGN0o2RGN2Qi93dmpaZ29CYkE1ZmlmYmpFSSs5TzZvZHhGQWJhVmZKMnVJ?= =?utf-8?B?eG45K0Z6K3RBQmpCZ1ZISWdXRGZnRWhtOGp1WVpzMXB0bnBxOVEzNWhFTFJh?= =?utf-8?B?eTczNGJjemdrRFN4THJlc0FpV1lQaVV1NjN6ODVPallaemtKemxuc1VJSHhN?= =?utf-8?B?WFZiRG4zZWJHTDNVQ3lwQjZKaHc2ZDFPNGdHVitjVXFCUjM2OEExK2pOdW1Y?= =?utf-8?B?MzlsckNFNTlhL0g0R3ljZHBSYktWQi9FSGlkVFZGYkU0K0ZWYmU0OUNzcHdT?= =?utf-8?B?YmtzdW9oT29wOGFYVnJxN2tFUDZOdWhNY0dVL0ZURFEzRkhnZy91ZlR0Slhs?= =?utf-8?B?UlI2eW5ET1pJV1FSek5DYUtOWXd1bkd1MzI0Zjg3SmplQ1BVMUIwQ1lFamVp?= =?utf-8?B?cTY4V2JMb2hCNUo5aTE2K3g4ZXhhYnJEdXBuT0VONmpsOTFibTFrL3lTQlFX?= =?utf-8?B?OUtsRDNjQkc4UVpCM09MTWxaS3cyVi93SFhyOWJWRWt6dTlnNG42Qmo4Wjh1?= =?utf-8?B?MXpmQURLR3lKcTQ0cmlzTzNNc09UZm4rMXRJRXhreVlNRjVKSGZNVmZ3TitX?= =?utf-8?B?T3dTQmNFbzVGcWlSZ05LUW9MQW52N2s5VjRBZkh0OUpLS2hHUEloMkF5S3J6?= =?utf-8?B?U0tsZkJyanNoMUhnamJLc1Y5STU1Zys5NjF0SFNrSkk3U084Y2lZNlU0QXdy?= =?utf-8?B?Q2ROR3h1M2F1NElPRUladm16bUNvNTE0R3M2Y2QxQnRHdG9MelBWMzcva04z?= =?utf-8?B?M2NBNWRwa3g5dG1wa3N2czNMTHMyUlYyMUZMb3ZIV2VNcEVLZGw2VXB1V2tV?= =?utf-8?B?Mi9ybGt0UWtnNGxtcGViR1ZGMVdFYkZ5V1NzNWR4N0grMFVod0tFb25rSExu?= =?utf-8?B?RXNsdHBaQVVXaUtvWW9sTzAzQ0F5ZEtWTlVaZkFTc1k4aHRYd05KcGlSblBX?= =?utf-8?B?cjNMREFoSERuKzZHaDI3QzdIODYvUE9zV0NzM3JGU1lvbjZXbU1NU0pLYmFh?= =?utf-8?B?VG00czN0dEN6SVUxcVo5WmtoYWlrNk5GUTJuaTg0TDVUU3k3U1Z0Y1E2SS9R?= =?utf-8?B?QktJRVlYaXVqS0JaaHZoQS9qSXlMUll2dTY5SEFFcTFBQTI3aVkvekRNaGZp?= =?utf-8?B?OXVMS0RuRHVJazY4ait3TkFVdi82cno5Mm5nNGJJQ0Q4MlJOV2NXclFpU1Nx?= =?utf-8?B?WVFRcmJ1Y3lEV1NLRXdsWmpDTVJJZWxmYjh6bnQwQUQ4aEdJM3hlNFVpUGo3?= =?utf-8?B?WHR5eTVNOThDWS9aUGczeDZ0ZUR4OXpnb2JqV0U0T3JxbC9LcW9mOXQ2MnJz?= =?utf-8?B?bW4xNVcvU21ZWU95M1dnejA4ZTJIbGRVUDFLMnVkR0dKUDNPenAzWTNoZzdB?= =?utf-8?B?RmdpOUc2YTZuQTVlS1B1R0NGL09pQ0JDVnU5ckNnZk4yZHcyOWtvUzhTWGF1?= =?utf-8?B?aElDOHJraStsOFlnZStmZ2NqZ3JKRmU4eWx5Q3BrSDlPM2hKcWozRGVpTkt3?= =?utf-8?B?eFhqN2JxWmVDbGxHVEZoVHMxUDlob3BVQlZRNVBhQU1KWm5UUTVPcUdPNWpD?= =?utf-8?B?OUZ1RUNaZ25pVGl1eDloSFVydW8rNTZnaXRYdFpHdzMvUkRMR29EVEtqS1Zr?= =?utf-8?B?VzFEOGVNOVZpZE54M1ZIYXgzQ2JxZkJyK3hGRG5ISUpEaGFUK3VYZjFpOGxS?= =?utf-8?B?K1hKcDdzaDFVTWJIQXZCdUl0a3FUV1R1MnMvVEhndnYxNDNmODBhamgzNndx?= =?utf-8?B?TzY3L1RMNzV6UVZiY0luUzdEcEVBbWdwOUlxS2ZpNGw2aWk0TWVPN0hxQmR6?= =?utf-8?B?SmpnaElCdzVxVXR5bFA1KzhpcUZnTytTaG1kMUV5RUF1cHErVGFwQ0tNYmhw?= =?utf-8?B?d3piOU1aK0dpRlFrQWJqUXYxSEp0QUhhRE5pMGdIcW10eDNCb0hCQzJJc3k3?= =?utf-8?Q?bdd7jJbVZy4jPhodEHglDDw=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f95f0bf5-75a4-4ac6-af99-08d9fd2fee8e X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 16:07:36.0378 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /7O3uXH0p7BatDSAENR5J5WsuZziGgEed7OA7jw8z5izK/zt0ppcQITJ3o4F1aJZLTeFyKMg+4O2p33Ang2+kQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5367 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/1/2022 3:18 PM, Gregory Etelson wrote: > Fix typo in INET IPIP protocol macro. > > Cc: stable@dpdk.org > > Fixes: f3f1f576f438 ("net/mlx5: fix RSS expansion with explicit next protocol") > Signed-off-by: Gregory Etelson > Acked-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index 0d774cfd19..efb988a9bb 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -208,7 +208,7 @@ mlx5_inet_proto_to_item_type(uint8_t proto_spec, uint8_t proto_mask) > case IPPROTO_TCP: > type = RTE_FLOW_ITEM_TYPE_TCP; > break; > - case IPPROTO_IP: > + case IPPROTO_IPIP: Hi Gregory, Matan, Are you sure about this change? In linux header (include/uapi/linux/in.h) it is defined as: IPPROTO_IPIP = 4, /* IPIP tunnels (older KA9Q tunnels use 94) */ And IPIP tunnels as far as I can found [1]: IPIP tunnel, just as the name suggests, is an IP over IP tunnel, defined in RFC 2003. Since type set to 'RTE_FLOW_ITEM_TYPE_IPV4' in this case statement, I would like to double check if this is correct. [1] https://developers.redhat.com/blog/2019/05/17/an-introduction-to-linux-virtual-interfaces-tunnels#ipip_tunnel