From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA58D45895; Thu, 29 Aug 2024 10:08:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F933427E3; Thu, 29 Aug 2024 10:08:58 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 105DD402BE for ; Thu, 29 Aug 2024 10:08:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724918925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2YF4a8yMlSCXzwvI+gIx3Rw7dtojEWVWx0I5LmUHpB0=; b=hdv70ZWhLTJD9oEIqeyQE7fY6MijvnLtUFv3XAHAjmG63+1bv9cNYU/tTcV7x7MOFdTdG6 ryDQ6co4nCdnWoe/qvvLaILL7+w0j9PBfZYFoejI3lJGjpTRIduhQaR/BdlUpdF4hJCbLO 131CzkUY55z9jVxyzNvo8qlcDpqKSmk= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-56-pG_Ufom8PNG9L3FHR2bmsw-1; Thu, 29 Aug 2024 04:08:39 -0400 X-MC-Unique: pG_Ufom8PNG9L3FHR2bmsw-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B5B64195608A; Thu, 29 Aug 2024 08:08:38 +0000 (UTC) Received: from [10.39.208.9] (unknown [10.39.208.9]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BF1CA300019C; Thu, 29 Aug 2024 08:08:35 +0000 (UTC) Message-ID: <678fa7b2-6cf0-4835-9af9-2124ea566f30@redhat.com> Date: Thu, 29 Aug 2024 10:08:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] bbdev: add new function to dump debug information To: "Chautru, Nicolas" , Hemant Agrawal , "dev@dpdk.org" Cc: "hemant.agrawal@nxp.com" , "Marchand, David" , "Vargas, Hernan" References: <20240701223424.427588-1-nicolas.chautru@intel.com> <20240701223424.427588-2-nicolas.chautru@intel.com> <0b28aebd-0247-0e0f-22f3-f04ee0b2a236@oss.nxp.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= xsFNBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABzSxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPsLBeAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASrOwU0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAHC wV8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/2/24 20:55, Chautru, Nicolas wrote: > Hi Hemant, > >> -----Original Message----- >> From: Hemant Agrawal >> Sent: Tuesday, July 2, 2024 3:54 AM >> To: Chautru, Nicolas ; dev@dpdk.org; >> maxime.coquelin@redhat.com >> Cc: hemant.agrawal@nxp.com; Marchand, David >> ; Vargas, Hernan >> >> Subject: Re: [PATCH v1 1/2] bbdev: add new function to dump debug >> information >> >> Hi Nicolas, >> >>     Few comments inline. >> >> On 02-07-2024 04:04, Nicolas Chautru wrote: >>> This provides a new API to dump more debug information related to the >>> status on a given bbdev queue. >>> Some of this information is visible at bbdev level. >>> This also provides a new option dev op, to print more information at >>> the lower PMD level. >>> This helps user to troubleshoot issues related to previous operations >>> provided into a queue causing possible hard-to-debug negative >>> scenarios. >>> >>> Signed-off-by: Nicolas Chautru >>> --- >>> lib/bbdev/rte_bbdev.c | 214 >> ++++++++++++++++++++++++++++++++++++++ >>> lib/bbdev/rte_bbdev.h | 41 ++++++++ >>> lib/bbdev/rte_bbdev_pmd.h | 9 ++ >>> lib/bbdev/version.map | 4 + >>> 4 files changed, 268 insertions(+) >>> >>> diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c index >>> 13bde3c25b..81c031fc09 100644 >>> --- a/lib/bbdev/rte_bbdev.c >>> +++ b/lib/bbdev/rte_bbdev.c >>> @@ -1190,3 +1190,217 @@ rte_bbdev_enqueue_status_str(enum >> rte_bbdev_enqueue_status status) >>> rte_bbdev_log(ERR, "Invalid enqueue status"); >>> return NULL; >>> } >>> + >>> + >>> +int >>> +rte_bbdev_queue_ops_dump(uint16_t dev_id, uint16_t queue_id, FILE >> *f) >>> +{ >>> + struct rte_bbdev_queue_data *q_data; >>> + struct rte_bbdev_stats *stats; >>> + uint16_t i; >>> + struct rte_bbdev *dev = get_dev(dev_id); >>> + >>> + VALID_DEV_OR_RET_ERR(dev, dev_id); >>> + VALID_QUEUE_OR_RET_ERR(queue_id, dev); >>> + VALID_DEV_OPS_OR_RET_ERR(dev, dev_id); >>> + VALID_FUNC_OR_RET_ERR(dev->dev_ops->queue_ops_dump, >> dev_id); >>> + >>> + q_data = &dev->data->queues[queue_id]; >>> + >>> + if (f == NULL) >>> + return -EINVAL; >>> + >>> + fprintf(f, "Dump of operations on %s queue %d\n", >>> + dev->data->name, queue_id); >>> + fprintf(f, " Last Enqueue Status %s\n", >>> + rte_bbdev_enqueue_status_str(q_data- >>> enqueue_status)); >>> + for (i = 0; i < 4; i++) >> >> It shall be RTE_BBDEV_ENQ_STATUS_SIZE_MAX instead of 4 ? > > Thanks, I can update this in the v2. > Hi Nicolas, could you please send a v2 addressing Hemant's comments? Thanks, Maxime