From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7EBB5A0526; Tue, 21 Jul 2020 14:26:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 72A741BFEE; Tue, 21 Jul 2020 14:26:43 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id E9AD61BFE9 for <dev@dpdk.org>; Tue, 21 Jul 2020 14:26:41 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 83F835C00A7; Tue, 21 Jul 2020 08:26:41 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 21 Jul 2020 08:26:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= HN8AYJ098usTs45IjKuvbt1/6VKjcGV+SXsrFp9FD0Q=; b=d2nCeJTIPLrAFlvq +yaJGg2uPECaHlTfuosyfbKPaW+RVPx6mLN+qV+5LiUZBZVwE/j5b+7Sn3MGQyvI ZDpdCPiQt8KcIKwuFPfLn34pvqy3EQQQJAh+ofievI0L9dS7IfmFK3VBO4mK/xIg k6uxeIM8iUg+dTcI/WRdJxkk5PR1dTfaQzDh3ebT04Cgqxj4HZtg3JJSa20qIzRo gRI+JZeJwEWeTLxBou/eePgU43TOk4iWi/eKs61T0Y7DkYkEJyr94QHoJ01TXRwx ckoK1cGgumKQ+fNUTXIprmGdJCVaZ6mI6maKM9VP8RQuykhiHE+Cy7zKFzgca7jC 5N57dg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=HN8AYJ098usTs45IjKuvbt1/6VKjcGV+SXsrFp9FD 0Q=; b=chqe81JvqE5wNYYo0G6hDkzGg7WLSmKwa2OXxzjvJ3+otKb1zY9zmp/dK fKmjGSlKvOLgjfa7uD8ntEYslMHUEZNLjqP3X1zLEwn369ibUadPWEq34cKHm+2m w3vLe1OcxANJ+R6vBJNuD5ykNyHp8QE7W+aED9AcfOJaHfWeHpRr8XGSwnvlAc9y NLie8tuRp7tkFuxpyCKQAG5sEF8AgowsnIMuGld9d1n+hZO3bbpmEQMQwvQY4V7e co9ZMJgDNd++adRgsCfMgD8oB7Y2OXt0I/huslXKH4jxFRQ2cAmHJWLplXLARwiy OZuzbYnQwtv3Azqwx1q1xiVXaJyIA== X-ME-Sender: <xms:AN8WX7qJ-mmvyUjEuD1WoQ6cuQ4JJPg0rJRZkrZtRYEwT4xJmu_I3g> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrgeeigdegkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: <xmx:AN8WX1rc18LbjXG8v18VT2Gdz6a1mAuL8ggZZ3RNfTIM6GBv09M3ag> <xmx:AN8WX4MGOgwEQ8Y2_BLDr-LX8lgsmjeHUVBZxH4-JEkUaETydcLYwg> <xmx:AN8WX-7jNTYNEPfe8qJvIS2gnp7bKT4_4A46HQQf7CorST2OczaYpA> <xmx:Ad8WX8RxKQ_7cP7D2VKsKTeOuhlNn53TbbyfOvGNOvow5-I90pga_A> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 98D6530600A9; Tue, 21 Jul 2020 08:26:39 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Parav Pandit <parav@mellanox.com> Cc: David Marchand <david.marchand@redhat.com>, dev@dpdk.org, Ori Kam <orika@mellanox.com>, Ferruh Yigit <ferruh.yigit@intel.com>, dev <dev@dpdk.org>, Gaetan Rivet <grive@u256.net>, Raslan Darawsheh <rasland@mellanox.com>, Matan Azrad <matan@mellanox.com>, Joyce Kong <joyce.kong@arm.com> Date: Tue, 21 Jul 2020 14:26:38 +0200 Message-ID: <6790966.1uoSfovWKA@thomas> In-Reply-To: <AM0PR05MB486624FE0033AFE4758ADDB3D1780@AM0PR05MB4866.eurprd05.prod.outlook.com> References: <20200610171728.89-2-parav@mellanox.com> <CAJFAV8yibEAh_OqvW9xSP51NAKxXCGBm9La944jr2oQ3mXXy=w@mail.gmail.com> <AM0PR05MB486624FE0033AFE4758ADDB3D1780@AM0PR05MB4866.eurprd05.prod.outlook.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 21/07/2020 14:13, Parav Pandit: > From: David Marchand <david.marchand@redhat.com> > > On Tue, Jul 21, 2020 at 1:19 PM Parav Pandit <parav@mellanox.com> wrote: > > > > This way, net/mlx5 and vdpa/mlx5 will pass their id_map to the mlx5 > > > > pci driver whether it is registered to the pci bus or not yet. > > > > > > And here pci_id_table will not be const *. > > > Is that ok? > > > > This is already the case in the current patch. > > I see nothing wrong with it. > > The pci code expects this pointer to be const and will it treat it as such. > > > o.k. > > Gaetan, Ferruh, Thomas, > Can you please ack as well? Yes of course it is OK updating the PCI table of the common layer in runtime. The most important is to keep the fixed PCI table of the PMDs the same as registered for pmdinfo usage. > > On the other hand, you may remove the pci table exported by the common > > driver as it is useless. > > pmdinfogen only parses the .o and extracts the table symbol, so it won't load > > other mlx drivers to generate the .pmd.c file. > > Ok. One more nit: please don't use "class" as variable name for drivers.