From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2BCBB43F68; Thu, 2 May 2024 15:48:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1B6DD402B2; Thu, 2 May 2024 15:48:52 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2061.outbound.protection.outlook.com [40.107.236.61]) by mails.dpdk.org (Postfix) with ESMTP id 786BB40299 for ; Thu, 2 May 2024 15:48:50 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=corqJYk8hOiJqBJks0Oxamw7bYEi1Xmt4Db3Zj6VjlWPu9g5IwqpyISlmYYvtwy+uIJ8e5nFFNQ0wHPM1iYLBneMMYWMzOcp+2X/1QivHvFD8v/+MkYv/Inknr4rW9WjH01YhzJvOB0QcGmhG4OkKtPsNZStc9TPzakzSAYHqZT5bBgWklzNbBMaAKZElzVlXDTVm20JGc8m1uOWZ1qyQxkSWrvqmkavV2lCoXlT9FlKfoZK9W/WsFIAthFJANx8vrt3lH4awG2rrKQt21Z7Ss29dXNeIP5aBkJcd5DetZ9/FqCZazduvLF58XA8Mvl4TuruLrRT5Dy/pO/I79ESnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sgWxfdTxDTkBjDN1GfYGtPyLi6dLX3yyxvOLZtoaZPE=; b=AJWjFhw+0mRXfEXVhDYTIvYGGQKs17+wBJRdUlrapCnAmVlbVCpC/zlHl0g9X8U/IZbGhPQrOymdZ40ulVVFKUKUp4t1MICIxpFfrtRMTB+lMc7ZlvGUytvEUV10oL9CfuxoF8lJ6/1opQ8UZeFksf/IcEVWxbAhMZ+NR4uRFocvf7I5b2JRj+npJ/aFEXd3crd/RsyDeN/y22uYjSAMfeakewcHdajU6SuwMOOrkK0sABN9lEwBPVtMVlHSxdubTznGLUrmaEebi4EflrI+6K6Q8V2iOA5FqiFThVHq7xArpuiQzGtK6iwDNxeAJtI9xHR5dKYZ98KiBozJU38ghQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sgWxfdTxDTkBjDN1GfYGtPyLi6dLX3yyxvOLZtoaZPE=; b=yuQ/LsEM+07021a3CjGoBn9dz/tI22LC3SeA+Ug9gHJ0tHuHVhyeWQhvFr5Fa4y1rABE7ddoixMEVvv74jy1XM24eLvy8aU6B8Ux+Ka5FQ9UNXbZggMXxQE9R8ROwJh7b7F5Tfec2ZM/A1W9/XG4tnT1QqTSowoWrxRAgYp+dfs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BL3PR12MB6594.namprd12.prod.outlook.com (2603:10b6:208:38d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.28; Thu, 2 May 2024 13:48:47 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3%7]) with mapi id 15.20.7544.029; Thu, 2 May 2024 13:48:46 +0000 Message-ID: <679a5189-2d15-432d-a47d-ddb7718a0bac@amd.com> Date: Thu, 2 May 2024 14:48:42 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/af_packet: fix statistics To: Stephen Hemminger Cc: dev@dpdk.org, "John W. Linville" , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= References: <20240430154129.7347-1-stephen@networkplumber.org> <9025199c-585c-4779-9f4e-360845707088@amd.com> <20240501094208.5f9e4cf9@hermes.local> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240501094208.5f9e4cf9@hermes.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0061.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::12) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BL3PR12MB6594:EE_ X-MS-Office365-Filtering-Correlation-Id: e281bea9-3072-4749-8940-08dc6aae9670 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|1800799015|366007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Sy90Q2Fzam1LZW8waFRoSTd4TmZuZnBWOGhJbGg2YWxhQmxGMzcrOGVEai9s?= =?utf-8?B?eDJ1eUkxeEhUZjgrdThVcmNhUmR5eGhqL0dUcUVtNXVJUjA2TzJYbjJzWGcr?= =?utf-8?B?TjA1SnJ2MmxVV3dyS0VjdUFJandGMnVoc0ZkR3NCWitKMGxSYXAxdjZpeC9S?= =?utf-8?B?L3VPU3htRXJvRGkrbU1PcHVVM1RKQWNVRGxsWlJkeHRnVHAxbTZYQzd4YkN4?= =?utf-8?B?c296TkdwdGFra1hsVnVKR2xScUhrNGIycmJBOTJCd0lFNGRDUDJ2UVlvb29Y?= =?utf-8?B?WjBsWi9QTG1yK2RYU1JmS0NIRXZQVFNJd0xCQXh2WEgrREp6NWhzWkdjaGdt?= =?utf-8?B?SG52amRsRTh3YWVqd1RyOEJZejFWZ1p1ZEtsRVBZa0xYeGtheXRpMGpFeGdZ?= =?utf-8?B?WDZHelNwQkp5RmwyelYzNE0wV3dqWllWa1NaUWFnRkJkL1JIMkdnL1dDN3hs?= =?utf-8?B?L2wvSlFuY0FOdU5jaEd0cDlSWDdEdTBxUTZtTG8vdGZtU3cyZ3EwWkt4MEgv?= =?utf-8?B?MEE4UERZM1NDVElmQklPT1lzODRSRjZMU3JvQ2czL3RFbm5abmdmT0xRSVlN?= =?utf-8?B?NGNIYkxGZGl0WnJBSytJVk1XdTBCL0s3NVVYZmlKR1Fyc0o2dmJ6M3NMNGZv?= =?utf-8?B?dmwzVER5VWVXa2p0ajVhN2xoUk5abXlZaFo4R1Flemwzc21xbS81ME5odUNa?= =?utf-8?B?TDR5M2d0TjRZdHc0Q2grUG5wempjRkJhdHBmV2NXdTdaVEZJcjBaVGRud0hs?= =?utf-8?B?Sk9vdlhjTW9QVFcwejVpaFQrTVhOVnFpVWNkL2xZKzUvRW5CZ2JiL1lrOS9J?= =?utf-8?B?d3lFUnh1bWpKYUIyZ1RnMzlvK1MvUk9NYU03K3BmMEtJbXBLMW5YT1lMeGJH?= =?utf-8?B?Vkh0L3pRblYzRDNHNFBVVUlpMjREc3hmTFB0cFJyNm51NklzL0RBK09zVmQ0?= =?utf-8?B?OW5KMXVIVFBveW94cXQ1aUtrdmowcHdNSkErbXUvWU9LUkRGWElSYThsYlZ0?= =?utf-8?B?VzBpQW9kOU50WFAzdVlxV05qOU16dWg4Rjl3bERKRTQ3bWE4MUVJTzhPc2dS?= =?utf-8?B?SjcvbGFpNXZGWmJYMzFDZmNUdkFKTHhkRWEyN1V2dEc5aVV5K2RQM0VqbU1p?= =?utf-8?B?ckFjZCtEOVdSTHJuaWVlbS9SZ09MaWMyTEs2UldCSEFvY29oMU0zTkdMOGlO?= =?utf-8?B?cDV4QjhReUoyQ0lQRXVyUjRWcWhTUFA4RDV4bHhqcWFtM29qVk9MNlhINjhD?= =?utf-8?B?aTBON2lTVEZlZzliTGp6VWxCSTJSZjAwUVhQc2E4OFVYMDhKWmJuZUltL2Mw?= =?utf-8?B?NjlKaHBYU2s3bGU4SGYwM1hWcFphaUZ2TUUzNzNqOXNYcVpqRUFwaXY2d1VX?= =?utf-8?B?MkRKN1dnOFpRM0NoeWZVR0g4YjF5MVNUZjU5K3lDSy9UOUYwOE1jakZWdWk1?= =?utf-8?B?NTVjMUh1T2lDYmh0TVJ6M0xlNXZUeERUc2xHQWp3VkJEM3VVZ1oydHZUSDZH?= =?utf-8?B?djdFeEFZMVJsZmFXY3pwektjWVphM3ZXV3prQnRHQXI0ZityV2xvNmk4Wm5Z?= =?utf-8?B?RGlpM3ZobktmY3p4TUpkT25sWWxMaVdiTGZwdm1xVWdVTmtOcmxHWjlEMWc2?= =?utf-8?B?QXNDMXFZa3VIam1ubmRFT05JM1VrTWFULzYvc1RZZVA4QWdTYU4vRnU2bmV2?= =?utf-8?B?N2hISHhiaEExR25SSHBGbHlhRDh3Z0JzT2ptK2pDdGxMeWlFWG1NSnpnPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eE1ZSkhMbkx4TS9IVU9pa0FFWWVLYzYwYWJqREU3cGRhWWFJaG41TW5pbWV3?= =?utf-8?B?N2plbEljeVBIcDNWSks5THcxYVJNa2RGbTVudGhCWWlNai9TT0xMVHR4YTl2?= =?utf-8?B?Y2w4RHkwbXBsd1ZVMjdMcFMyN2loaHlUS2M3WS9pT0w0RUFocjNqcTcxSnZh?= =?utf-8?B?WnR0Uk1jRWplOG04N1FnWGpZYW4zNzFQazc4bG1WcHo4c2dlRk5xMTNGdmtT?= =?utf-8?B?TThTZkRVa0ZpZGI0dm8zU3ZORmtuN2ZxaFZnSmgxZ1lTNDljU3VKdlVpMmhY?= =?utf-8?B?WXEycnhxZDRDOFF2ck5iZmo2RG9NQ294QzVkeU9rSWg2NFVDRFFyNG1udGcr?= =?utf-8?B?TjRYT0RRUmRiY1BScEt6elo0TkwvdXpzcExvbUlKWjdhQ1BhcFh0aG9sTzhP?= =?utf-8?B?dVVWUm5Yd3NCa0tidlZUU25LQy9MYk55L2hMZmFXTTl4eStGcUI5TjZWcUln?= =?utf-8?B?alJpa1FZSmlPRDNNZTM3cmp4M0RnckhsYTFBYW9jK0U5Um9xQnA2aExJTHla?= =?utf-8?B?L2hGYjdqbVlFY1hzdEs4dU9FaUZnVGtwd1NOemZNUWhsTnNiMUNnWHZvMnFN?= =?utf-8?B?Zk1LcVNPRzlONkE3S0pFMlorRTBPYmQvOXBYeGhEU0NBZFcxN1JTQjVtWURB?= =?utf-8?B?WjF2YVduLzZSSEkrK0lOZTJObVZUdHNnbmFXWGZuR0FoS2krUGhFT0VXU3lx?= =?utf-8?B?WWRNZ3Z1NkNiV1V5dVQ4aEI4M2g5dW52Z3oxWWlUSWhrRUdmdHZkNnc1RUlQ?= =?utf-8?B?Y082WjdoMGpnbTJIdE1RUFZBVDFHZkhKOXhGN1cwRU5HbTIwemVaUXJQV0hy?= =?utf-8?B?alNYdU9xMEE5UExKdThuTm5UQVlhTjV4Q3R3M29aSWk0ZXBmbUgvQitTK1pj?= =?utf-8?B?M0ppZWdmYVl1Smo3ejJSSG1MMnBMKzZweGYzcmt1THBpNlRtZUpWWERWM2Ni?= =?utf-8?B?MTlZQkI1eUlsa1EzZXNsbjJ6Zm1RaWlJQzIvR0xLV0tBeEluc0krV2NwTGFW?= =?utf-8?B?bVZpRDRHMElrKzZ4OXo1b0hQbk1BZUt6SEora2l4TGpkZ1d0MVJKemNtblpt?= =?utf-8?B?dW40eDVkUXhTSDMzUXkzWFgwL3MrMEoxQU5OZkYxY1VWQ2c1eE1LYktUeTEz?= =?utf-8?B?NGhDZTMrbE5YdEVyRTVnQlpZbnRFOW9Cd3lNanBnK1RNNGlZRTRMVEhFaExM?= =?utf-8?B?Y1VaWG5QZXJCNTV1dnZlSDFhVm5lVDRGUkRPYlhNNHcvS1ZmdSszMFRNRlpQ?= =?utf-8?B?aFZCSVZKUyt2VTEvWEtNbGtpN0REa2NRYTJpTDFCQjRnTy9ETHovL1hYQ2lN?= =?utf-8?B?bFBPZkZTaWEzRzdkVjFNUTkxeG5Fa0ptVERveDVFcnBvR3VETTFKUkJMcHEv?= =?utf-8?B?VC8xRWJ2Y0U5d1dWVUdXaWVpYnF3ZCtZeS9WSWtnN0N5WWlLK05BUGZ1ZUpR?= =?utf-8?B?R3dnQkNpT2pwT3h2OCszTUdnUGRtaTN2clRienVQNmtQYTdPMkZSWlFmNzZi?= =?utf-8?B?dE56OXVjNUg4MDNidVJrZktxU1J3UWRuRWpjMzRoTkVxZ2FubGhTY2N3MVNF?= =?utf-8?B?M2cvdDhlUndJM1JQdGdqc2NUbEZhcTdhb0ltRDJyMlkwbURDTjZEZUJQTzRv?= =?utf-8?B?dVZqbDRVYndzbUhXS25TQktHUlhISHB1YmFOWHBIMjJtaXdET2xzSFJxbHZK?= =?utf-8?B?dmF3d1VweGl6ZSs5aFhaQUMyMlQ1ZElXKzBtVFBXQVVnM3BLLzZGQXRUUEl4?= =?utf-8?B?Yi90WFFETUJ5dEQwOEJLa2pVSjZZU1U3OXVwbUlOTklHQmxuRXNTb0lORmZt?= =?utf-8?B?R1BTWnFxWUVrMXlhVTBiNVVrZXhtaW9GNVJDeWVJallxOG9KOC9YK3prN0VY?= =?utf-8?B?bUVFMS9EVExzVlhvamZieGhUM1pWSlpvOEFZYkRFOC9KRkZkUWhJNjB5cHlR?= =?utf-8?B?SG50TGRPSVhTVEdGa3FqYVgvajA0aW5OTjJzTTdMNSt3NThGTTNYdjhjT1k2?= =?utf-8?B?R013RURYTVE1YUd2YXdKNUc4UTR1Sys2cmdONnZtekFLVytsTG1OcWEreW11?= =?utf-8?B?ajkzK0JuNFp1ZE5GNkk3SENFOXVSSitjeDQxdzdiRHhtUys0MFJ4K0ZGSXRa?= =?utf-8?Q?b8FnkIXIn+w8P6tjnSYjy0u3X?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e281bea9-3072-4749-8940-08dc6aae9670 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2024 13:48:46.2431 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Xx+afIlI9PaqDosdjU9GUNIn82qfHY5GretO5kvL5r9o8y+P2XRb8rKq+uVOxzKq X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6594 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/1/2024 5:42 PM, Stephen Hemminger wrote: > On Wed, 1 May 2024 17:25:59 +0100 > Ferruh Yigit wrote: > >> On 4/30/2024 4:39 PM, Stephen Hemminger wrote: >>> The statistics in af_packet driver do not follow the standard >>> practice of other drivers: >>> >>> - Statistics should be maintained as 64 bit even on 32 bit. >>> >> >> ack >> >>> - Remove the tx_error counter since it was not correct. >>> When transmit ring is full it is not an error and >>> the driver correctly returns only the number sent. >>> >> >> nack >> Transmit full is not only return case here. >> There are actual errors continue to process relying this error calculation. >> Also there are error cases like interface down. >> Those error cases should be handled individually if we remove this. >> I suggest split this change to separate patch. > > It is possible to get errors, but the code wasn't looking for those. > See packet(7) man page. > Some of the error cases are in dpdk level, so we can't just rely on af_packet socket error counters.