Re: [dpdk-dev] [PATCH v2] net/i40e: support mac loopback

["Peng, Yuan" <yuan.peng@intel.com>]

Tested-by: Peng,Yuan<yuan.peng@intel.com>

- Tested Branch: dpdk master
- Tested Commit: e976052a1106153c93c802e5ffd2f6c8a29f239f
- OS: 4.4.0-62-generic
- GCC: gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
- CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz
- NIC: Intel Corporation Ethernet Controller XL710 for 40GbE QSFP+ [8086:1583]
- Default x86_64-native-linuxapp-gcc configuration
- Prerequisites:
- Total 2cases, 2passed, 0 failed

- Prerequisites command / instruction:
 Two 40Gb Ethernet ports of the DUT are directly connected and link is up.

- Case:
Case1: loopback mode
enable loopback mode:
In dpdk/test/test/test_pmd_perf.c
set::
    .lpbk_mode=1
    #define MAX_TRAFFIC_BURST              32
then make test
    ./usertools/dpdk-devbind.py -b igb_uio 05:00.0
start test::
    ./test/test/test -c f -n 4 -- -i
    RTE>>pmd_perf_autotest
The final output of the test will be matrix of average cycles of IO used per packet, and "Test OK" is printed out.
the peer port can't receive any packet.

case2: physical link mode
disable lookback mode:
In dpdk/test/test/test_pmd_perf.c
set::
    .lpbk_mode=0
    #define MAX_TRAFFIC_BURST              32
then make test
start test::
    ./test/test/test -c f -n 4 -- -i
    RTE>>pmd_perf_autotest
there is not "Test OK" presented.
the peer port can receive all the 32 packets.

When run the two test cases on XXV710 with same dpdk version, the cases passed too. 

-----Original Message-----
From: Wu, Yanglong 
Sent: Wednesday, December 20, 2017 3:29 PM
To: dev@dpdk.org
Cc: Xing, Beilei <beilei.xing@intel.com>; Zhang, Helin <helin.zhang@intel.com>; Peng, Yuan <yuan.peng@intel.com>; Wu, Yanglong <yanglong.wu@intel.com>
Subject: [PATCH v2] net/i40e: support mac loopback

According to loopback mode, setup loopback link or not.
If loopback link is setted, packets in tx will be sent to rx directly.
Loopback mode can be used to support testing task

Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
---
v2:
fix coding style issue
---
 drivers/net/i40e/i40e_ethdev.c | 10 ++++++++++  drivers/net/i40e/i40e_ethdev.h |  3 ++-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 0739f65a8..e8bdb335a 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -2047,6 +2047,16 @@ i40e_dev_start(struct rte_eth_dev *dev)
 						     true, NULL);
 		}
 	}
+
+	/* Enable mac loopback mode */
+	if (dev->data->dev_conf.lpbk_mode == I40E_AQ_LB_MODE_NONE ||
+	    dev->data->dev_conf.lpbk_mode == I40E_AQ_LB_PHY_LOCAL) {
+		ret = i40e_aq_set_lb_modes(hw, dev->data->dev_conf.lpbk_mode, NULL);
+		if (ret != I40E_SUCCESS) {
+			PMD_DRV_LOG(ERR, "fail to set loopback link");
+			goto err_up;
+		}
+	}
 
 	/* Apply link configure */
 	if (dev->data->dev_conf.link_speeds & ~(ETH_LINK_SPEED_100M | diff --git a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethdev.h index cd67453d1..2ad9858e4 100644
--- a/drivers/net/i40e/i40e_ethdev.h
+++ b/drivers/net/i40e/i40e_ethdev.h
@@ -61,7 +61,8 @@
 #define I40E_NUM_MACADDR_MAX       64
 /* Maximum number of VFs */
 #define I40E_MAX_VF               128
-
+/*flag of no loopback*/
+#define I40E_AQ_LB_MODE_NONE	  0x0
 /*
  * vlan_id is a 12 bit number.
  * The VFTA array is actually a 4096 bit array, 128 of 32bit elements.
--
2.11.0