From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5539B727A; Fri, 12 Jan 2018 06:39:35 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2018 21:39:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,347,1511856000"; d="scan'208";a="10172150" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga008.jf.intel.com with ESMTP; 11 Jan 2018 21:39:34 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 11 Jan 2018 21:39:34 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002; Fri, 12 Jan 2018 13:39:32 +0800 From: "Peng, Yuan" To: "Dai, Wei" , "Ananyev, Konstantin" , "Yang, Qiming" , "Lu, Wenzhuo" , "Wu, Jingjing" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v4 0/2] app/testpmd: fix invalid rxq and txq nubmer settings Thread-Index: AQHTipsf3GFcXS0Cl0aNs17K/J5Y/qNvucaA Date: Fri, 12 Jan 2018 05:39:31 +0000 Message-ID: <67D543A150B29E4CAAE53918F64EDAEA3746DA9E@SHSMSX103.ccr.corp.intel.com> References: <1515573656-41847-1-git-send-email-wei.dai@intel.com> <1515646700-56892-1-git-send-email-wei.dai@intel.com> In-Reply-To: <1515646700-56892-1-git-send-email-wei.dai@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 0/2] app/testpmd: fix invalid rxq and txq nubmer settings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 05:39:37 -0000 Hi Wei, There is a build error applied your patches to the latest DPDK version. /root/dpdk/app/test-pmd/testpmd.c: In function 'check_nb_rxq': /root/dpdk/app/test-pmd/testpmd.c:579:3: error: 'pid' may be used uninitial= ized in this function [-Werror=3Dmaybe-uninitialized] printf("Fail: input rxq (%u) can't be greater " ^ /root/dpdk/app/test-pmd/testpmd.c: In function 'check_nb_txq': /root/dpdk/app/test-pmd/testpmd.c:625:3: error: 'pid' may be used uninitial= ized in this function [-Werror=3Dmaybe-uninitialized] printf("Fail: input txq (%u) can't be greater " ^ My gcc verison is gcc version 5.3.1 20151207 (Red Hat 5.3.1-2) (GCC) Could you help to check it? Thanks. Yuan. -----Original Message----- From: Dai, Wei=20 Sent: Thursday, January 11, 2018 12:58 PM To: Ananyev, Konstantin ; Yang, Qiming ; Peng, Yuan ; Lu, Wenzhuo ; Wu, Jingjing Cc: dev@dpdk.org; stable@dpdk.org; Dai, Wei Subject: [PATCH v4 0/2] app/testpmd: fix invalid rxq and txq nubmer setting= s If an invlaid number of RX or TX queues is configured from testpmd command = like "port config all rxq number" or "port config all txq number". or from --rxq and --txq in the command to start testpmd. The global variabl= e nb_rxq or nb_txq is updated by the invalid input. This can cause testpmd crash. For example, if the maximum number of RX or T= X queues is 4, testpmd will crash after running commands "port config all r= xq 5", "port config all txq 5" and "start" in sequence. With these 2 patches, if an invalid input is detected, it is refused and te= stpmd keeps last correct values of nb_rxq and nb_txq. Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") Cc: stable@dpdk.org Signed-off-by: Wei Dai Aced-by: Konstantin Ananyev --- v4: update git log message and rename 2 new added functions v3: follow the guide from Konstantin to use functions to check input rxq and txq instead of usage of new added global variables. v2: fix a bug in v1 Wei Dai (2): app/testpmd: fix invalid rxq number setting app/testpmd: fix invalid txq number setting app/test-pmd/cmdline.c | 4 +++ app/test-pmd/parameters.c | 13 +++---- app/test-pmd/testpmd.c | 92 +++++++++++++++++++++++++++++++++++++++++++= ++++ app/test-pmd/testpmd.h | 5 +++ 4 files changed, 108 insertions(+), 6 deletions(-) -- 2.7.5