From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 29DC844BE; Fri, 12 Jan 2018 10:09:05 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jan 2018 01:09:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,348,1511856000"; d="scan'208";a="166197098" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 12 Jan 2018 01:09:04 -0800 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 12 Jan 2018 01:09:03 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 12 Jan 2018 01:09:03 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002; Fri, 12 Jan 2018 17:09:01 +0800 From: "Peng, Yuan" To: "Dai, Wei" , "Ananyev, Konstantin" , "Lu, Wenzhuo" , "Xing, Beilei" CC: "dev@dpdk.org" , "stable@dpdk.org" , "Peng, Yuan" Thread-Topic: [PATCH v5 0/2] app/testpmd: fix invalid rxq and txq nubmer settings Thread-Index: AQHTi38Qy059hVyFaUSgJa3LjN0/AqNv8QWQ Date: Fri, 12 Jan 2018 09:09:01 +0000 Message-ID: <67D543A150B29E4CAAE53918F64EDAEA3746DC3E@SHSMSX103.ccr.corp.intel.com> References: <1515646700-56892-1-git-send-email-wei.dai@intel.com> <1515744603-60457-1-git-send-email-wei.dai@intel.com> In-Reply-To: <1515744603-60457-1-git-send-email-wei.dai@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 0/2] app/testpmd: fix invalid rxq and txq nubmer settings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 09:09:07 -0000 Tested-by: Peng Yuan - Tested Branch: master - Tested commit 6c7001480ac6356ff0a4995f3ed495ed9c866061 - OS: 4.5.5-300.fc24.x86_64 - GCC: gcc version 5.3.1 20151207 (Red Hat 5.3.1-2) (GCC) - CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz - NIC: Intel Corporation Device Fortville [8086:1572] - Default x86_64-native-linuxapp-gcc configuration - Prerequisites: - Total 1 cases, 1 passed, 0 failed - Case:=20 ./usertools/dpdk-devbind.py -b igb_uio 05:00:0 echo 1 >/sys/bus/pci/devices/0000:05:00.0/max_vfs ./usertools/dpdk-devbind.py -b vfio-pci 05:02.0 pf: ./x86_64-native-linuxapp-gcc/app/testpmd -c f -n 4 -w 05:00.0,queue-num-pe= r-vf=3D4 --file-prefix=3Dtest1 --socket-mem 1024,1024 - -I vf: ./x86_64-native-linuxapp-gcc/app/testpmd -c f -n 4 -w 05:02.0 --file-prefi= x=3Dtest2 --socket-mem 1024,1024 - -i --rxq=3D4 --txq=3D4 EAL: Detected 88 lcore(s) EAL: Probing VFIO support... EAL: VFIO support initialized EAL: PCI device 0000:05:02.0 on NUMA socket 0 EAL: probe driver: 8086:154c net_i40e_vf EAL: using IOMMU type 1 (Type 1) Interactive-mode selected USER1: create a new mbuf pool : n=3D171456, size=3D217= 6, socket=3D0 USER1: create a new mbuf pool : n=3D171456, size=3D217= 6, socket=3D1 Configuring Port 0 (socket 0) Port 0: 7E:AC:58:44:3C:94 Checking link statuses... Done testpmd> port stop all Stopping ports... Checking link statuses... Done testpmd> port config all txq 5 Fail: input txq (5) can't be greater than max_tx_queues (4) of port 0 testpmd> port config all rxq 5 Fail: input rxq (5) can't be greater than max_rx_queues (4) of port 0 testpmd> port start all Port 0: 5A:19:E4:5C:A3:C7 Checking link statuses... Done testpmd> show port info all Current number of RX queues: 4 Max possible RX queues: 4 Current number of TX queues: 4 Max possible TX queues: 4 there is no core dump, and the actual queue number doesn't change. The case passed. -----Original Message----- From: Dai, Wei=20 Sent: Friday, January 12, 2018 4:10 PM To: Peng, Yuan ; Ananyev, Konstantin ; Lu, Wenzhuo ; Xing, Beilei Cc: dev@dpdk.org; Dai, Wei ; stable@dpdk.org Subject: [PATCH v5 0/2] app/testpmd: fix invalid rxq and txq nubmer setting= s If an invlaid number of RX or TX queues is configured from testpmd command = like "port config all rxq number" or "port config all txq number". or from --rxq and --txq in the command to start testpmd. The global variabl= e nb_rxq or nb_txq is updated by the invalid input. This can cause testpmd crash. For example, if the maximum number of RX or T= X queues is 4, testpmd will crash after running commands "port config all r= xq 5", "port config all txq 5" and "start" in sequence. With these 2 patches, if an invalid input is detected, it is refused and te= stpmd keeps last correct values of nb_rxq and nb_txq. Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") Cc: stable@dpdk.org Signed-off-by: Wei Dai Aced-by: Konstantin Ananyev --- v5: fix building failure with -Werror=3Dmaybe-uninitialized by gcc 5.3.1 fix typo error v4: update git log message and rename 2 new added functions v3: follow the guide from Konstantin to use functions to check input rxq and txq instead of usage of new added global variables. v2: fix a bug in v1 Wei Dai (2): app/testpmd: fix invalid rxq number setting app/testpmd: fix invalid txq number setting app/test-pmd/cmdline.c | 4 +++ app/test-pmd/parameters.c | 13 +++---- app/test-pmd/testpmd.c | 92 +++++++++++++++++++++++++++++++++++++++++++= ++++ app/test-pmd/testpmd.h | 5 +++ 4 files changed, 108 insertions(+), 6 deletions(-) -- 2.7.5