From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 371F211A4; Wed, 20 Mar 2019 10:21:24 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2019 02:21:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,248,1549958400"; d="scan'208";a="284221450" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 20 Mar 2019 02:21:21 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 20 Mar 2019 02:21:16 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 20 Mar 2019 02:21:16 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.134]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.80]) with mapi id 14.03.0415.000; Wed, 20 Mar 2019 17:21:14 +0800 From: "Peng, Yuan" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Zhang, Qi Z" Thread-Topic: [PATCH] net/i40e: add warning info when no perfect RSS key Thread-Index: AQHU3tFCQiwjp2VbEE6/G3mC8FT6eqYUPpSg Date: Wed, 20 Mar 2019 09:21:13 +0000 Message-ID: <67D543A150B29E4CAAE53918F64EDAEA376A5E6E@SHSMSX103.ccr.corp.intel.com> References: <1553052676-7961-1-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1553052676-7961-1-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Mar 2019 09:21:26 -0000 Tested-by: Peng Yuan - Tested Branch: master - Tested Commit: 239912fa798e6e671072ca7ff987afd74c1e506c - OS: 4.13.9-300.fc27.x86_64 - GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5) - CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz - NIC: Intel Corporation Device Fortville [8086:1583] - Default x86_64-native-linuxapp-gcc configuration - Prerequisites: - Total 1 case1, 1 passed, 0 failed - Case steps: 1. Bind the pf port to dpdk driver: ./usertools/dpdk-devbind.py -b igb_uio 05:00.0 05:00.1 2. start testpmd: ./x86_64-native-linuxapp-gcc/app/testpmd --log-level=3D*:8 -c 1ffff -n 4 - = -i --nb-cores=3D8 --rxq=3D4 --txq=3D4 --port-topology=3Dchained 3. set an invalid RSS-key testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp end = key 67108863 / end i40e_config_rss_filter(): Max of contiguous 4 PF queues are configured i40e_config_rss_filter(): Warning! No perfect RSS key config for i40e, so = use default configuration Flow rule #0 created there is a device warning reported. -----Original Message----- From: Zhao1, Wei=20 Sent: Wednesday, March 20, 2019 11:31 AM To: dev@dpdk.org Cc: Peng, Yuan ; stable@dpdk.org; Zhang, Qi Z ; Zhao1, Wei Subject: [PATCH] net/i40e: add warning info when no perfect RSS key There need a warning info when no perfect RSS key is config, so i40e will u= se default key. Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") Cc: stable@dpdk.org Signed-off-by: Wei Zhao --- drivers/net/i40e/i40e_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.= c index dca61f0..9235b08 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf, rss_conf.rss_key =3D (uint8_t *)rss_key_default; rss_conf.rss_key_len =3D (I40E_PFQF_HKEY_MAX_INDEX + 1) * sizeof(uint32_t); + PMD_DRV_LOG(INFO, "Warning! No perfect RSS key config for i40e, so=20 +use default configuration\n"); } =20 i40e_hw_rss_hash_set(pf, &rss_conf); -- 2.7.5 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C8D1DA00E6 for ; Wed, 20 Mar 2019 10:21:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6C0561B19; Wed, 20 Mar 2019 10:21:27 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 371F211A4; Wed, 20 Mar 2019 10:21:24 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2019 02:21:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,248,1549958400"; d="scan'208";a="284221450" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 20 Mar 2019 02:21:21 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 20 Mar 2019 02:21:16 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 20 Mar 2019 02:21:16 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.134]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.80]) with mapi id 14.03.0415.000; Wed, 20 Mar 2019 17:21:14 +0800 From: "Peng, Yuan" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Zhang, Qi Z" Thread-Topic: [PATCH] net/i40e: add warning info when no perfect RSS key Thread-Index: AQHU3tFCQiwjp2VbEE6/G3mC8FT6eqYUPpSg Date: Wed, 20 Mar 2019 09:21:13 +0000 Message-ID: <67D543A150B29E4CAAE53918F64EDAEA376A5E6E@SHSMSX103.ccr.corp.intel.com> References: <1553052676-7961-1-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1553052676-7961-1-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190320092113._9EqVj3GwiGHRQkLg3MysxVRBwJvHbGSmca-3dKAdt8@z> Tested-by: Peng Yuan - Tested Branch: master - Tested Commit: 239912fa798e6e671072ca7ff987afd74c1e506c - OS: 4.13.9-300.fc27.x86_64 - GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5) - CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz - NIC: Intel Corporation Device Fortville [8086:1583] - Default x86_64-native-linuxapp-gcc configuration - Prerequisites: - Total 1 case1, 1 passed, 0 failed - Case steps: 1. Bind the pf port to dpdk driver: ./usertools/dpdk-devbind.py -b igb_uio 05:00.0 05:00.1 2. start testpmd: ./x86_64-native-linuxapp-gcc/app/testpmd --log-level=3D*:8 -c 1ffff -n 4 - = -i --nb-cores=3D8 --rxq=3D4 --txq=3D4 --port-topology=3Dchained 3. set an invalid RSS-key testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp end = key 67108863 / end i40e_config_rss_filter(): Max of contiguous 4 PF queues are configured i40e_config_rss_filter(): Warning! No perfect RSS key config for i40e, so = use default configuration Flow rule #0 created there is a device warning reported. -----Original Message----- From: Zhao1, Wei=20 Sent: Wednesday, March 20, 2019 11:31 AM To: dev@dpdk.org Cc: Peng, Yuan ; stable@dpdk.org; Zhang, Qi Z ; Zhao1, Wei Subject: [PATCH] net/i40e: add warning info when no perfect RSS key There need a warning info when no perfect RSS key is config, so i40e will u= se default key. Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") Cc: stable@dpdk.org Signed-off-by: Wei Zhao --- drivers/net/i40e/i40e_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.= c index dca61f0..9235b08 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf, rss_conf.rss_key =3D (uint8_t *)rss_key_default; rss_conf.rss_key_len =3D (I40E_PFQF_HKEY_MAX_INDEX + 1) * sizeof(uint32_t); + PMD_DRV_LOG(INFO, "Warning! No perfect RSS key config for i40e, so=20 +use default configuration\n"); } =20 i40e_hw_rss_hash_set(pf, &rss_conf); -- 2.7.5