From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Zhou, JunX W" <junx.w.zhou@intel.com>,
"Zhang, AlvinX" <alvinx.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix RSS key
Date: Fri, 22 Jan 2021 14:58:47 +0000 [thread overview]
Message-ID: <67a2059d-c426-9aeb-6479-52375b060349@intel.com> (raw)
In-Reply-To: <d1989c470ca849f7afaad4ee2ecda981@intel.com>
On 1/22/2021 5:43 AM, Zhou, JunX W wrote:
<...>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang,Alvin
> Sent: Thursday, January 21, 2021 5:42 PM
> To: Yigit, Ferruh <ferruh.yigit@intel.com>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix RSS key
>
> From: Alvin Zhang <alvinx.zhang@intel.com>
>
> Since the patch '1848b117' has initialized the variable 'key' in 'struct rte_flow_action_rss' with 'NULL', the PMD cannot get the RSS key now. Details as bellow:
>
> testpmd> flow create 0 ingress pattern eth / ipv4 / end actions
> rss types ipv4-other end key
> 1234567890123456789012345678901234567890FFFFFFFFFFFF123
> 4567890123456789012345678901234567890FFFFFFFFFFFF
> queues end / end
> Flow rule #1 created
> testpmd> show port 0 rss-hash key
> RSS functions:
> all ipv4-other ip
> RSS key:
> 4439796BB54C5023B675EA5B124F9F30B8A2C03DDFDC4D02A08C9B3
> 34AF64A4C05C6FA343958D8557D99583AE138C92E81150366
>
> This patch sets offset and size of the 'key' variable as the first parameter of the token 'key'. Later, the address of the RSS key will be copied to 'key' variable.
>
> Fixes: 1848b117cca1 ("app/testpmd: fix RSS key for flow API RSS rule")
> Cc: stable@dpdk.org
>
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
>
> Tested-by: Zhou, Jun <junx.w.zhou@intel.com>
>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2021-01-22 14:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 8:59 [dpdk-dev] [PATCH] " Zhang,Alvin
2021-01-19 19:14 ` Ferruh Yigit
2021-01-21 9:35 ` Zhang, AlvinX
2021-01-21 9:41 ` [dpdk-dev] [PATCH v2] " Zhang,Alvin
2021-01-22 5:43 ` Zhou, JunX W
2021-01-22 14:58 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67a2059d-c426-9aeb-6479-52375b060349@intel.com \
--to=ferruh.yigit@intel.com \
--cc=alvinx.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=junx.w.zhou@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).