From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C718DA0562; Fri, 19 Mar 2021 10:18:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 95943140F61; Fri, 19 Mar 2021 10:18:18 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 77268140F44 for ; Fri, 19 Mar 2021 10:18:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616145496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oQ7CDayxPmfNwXD1RSGbkLp3XmluboiDCYrRvbwg1FI=; b=FGax9slLi9nhuoIecCvFPIeTxdDGlnnd5Xb7J8UfMa97WDtRxFm5/XVels7qtRhAkbGwjQ q3BdihYSnnWG2Qs1hFG4FS+y3qSg+islHyY/VT1fQA99HNlRnPIqNT3slL3LG9Zt3VhynO UkahzFW0zLiF8PBRulTxTEKipfGdLsw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-38-DCbRrE_wNDSk1GwW8Yuvxg-1; Fri, 19 Mar 2021 05:18:14 -0400 X-MC-Unique: DCbRrE_wNDSk1GwW8Yuvxg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0D09D63CD6; Fri, 19 Mar 2021 09:18:13 +0000 (UTC) Received: from [10.36.110.37] (unknown [10.36.110.37]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0BE095C1D1; Fri, 19 Mar 2021 09:18:11 +0000 (UTC) To: Ibtisam Tariq , chenbo.xia@intel.com Cc: dev@dpdk.org, roy.fan.zhang@intel.com References: <20210204080542.3812-1-ibtisam.tariq@emumba.com> From: Maxime Coquelin Message-ID: <67be15b5-97c6-9b49-e8e5-9f857e1b6a58@redhat.com> Date: Fri, 19 Mar 2021 10:18:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210204080542.3812-1-ibtisam.tariq@emumba.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] examples/vhost_crypto: remove unused short option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/4/21 9:05 AM, Ibtisam Tariq wrote: > Short option "s" was passed to getopt_long function, while there was > no condition on this option. > > Fixes: f5188211c7 ("examples/vhost_crypto: add sample application") > Cc: roy.fan.zhang@intel.com > > Signed-off-by: Ibtisam Tariq > --- > examples/vhost_crypto/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c > index 29c8f7228..66bde38c0 100644 > --- a/examples/vhost_crypto/main.c > +++ b/examples/vhost_crypto/main.c > @@ -219,7 +219,7 @@ vhost_crypto_parse_args(int argc, char **argv) > > argvopt = argv; > > - while ((opt = getopt_long(argc, argvopt, "s:", > + while ((opt = getopt_long(argc, argvopt, "", > lgopts, &option_index)) != EOF) { > > switch (opt) { > Reviewed-by: Maxime Coquelin Thanks, Maxime