From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Raslan Darawsheh <rasland@mellanox.com>, gaetan.rivet@6wind.com
Cc: dev@dpdk.org, thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH v3] net/failsafe: fix PCI devices init
Date: Mon, 23 Oct 2017 12:24:52 -0700 [thread overview]
Message-ID: <67d65316-c34a-bf22-1b6b-3c2c0ceac51b@intel.com> (raw)
In-Reply-To: <1508447700-11394-1-git-send-email-rasland@mellanox.com>
On 10/19/2017 2:15 PM, Raslan Darawsheh wrote:
> When trying to attach a port as a sub-device, the ethdev port
> was compared with devargs.
> In the case of a PCI device, the name in devargs is the PCI address.
> And since DPDK 17.08, the devargs name of the underlying device was
> used to match an ethdev port:
> a1e7c17555e8 ("ethdev: use device name from device structure")
>
> But the recent commit 72e3efb149cc has reverted this wrong matching
> to use the ethdev port name as identifier of the port.
> It impacts functions like rte_eth_dev_allocated() used in failsafe
> for matching ports with given devargs.
> The fix is to search for matching devargs in underlying device of
> all ethdev ports.
> If many ports match the same PCI device, only the first one is matched.
>
> This limitation was already present in previous implementation of
> rte_eth_dev_allocated(), and must be adressed later with a better
> devargs syntax.
>
> Fixes: 72e3efb149cc ("ethdev: revert use port name from device structure")
>
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2017-10-23 19:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 21:15 Raslan Darawsheh
2017-10-23 19:24 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67d65316-c34a-bf22-1b6b-3c2c0ceac51b@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=rasland@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).