From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C59ABA034C; Tue, 18 Jan 2022 14:28:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B3EBB4271F; Tue, 18 Jan 2022 14:28:31 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 9AB984068E; Tue, 18 Jan 2022 14:28:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642512509; x=1674048509; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=JcngNmTLsVF0pxLVWJh5wsJQKXqcWRvk7iJ/pk9zNZI=; b=f1XLGwMMXEdeXX+0A86woqii1vom6yevm5NMpxs8WsgpG20FFYbPQMs1 3AGIJrf7qOJbFQ5828wQ5Ujfms6aKceJJwAZlIpXehOxpYr3JQVX2JK8n zvStFPI362kP2T/zhtRNcVd4zUsW86t37LyHVccidh+JWcJnDlmRgupQa FRvurlXX+/saSavAeL6myUG45NX6D4WNsicjir48kK4dFnG5GMFvRYpxC x18uUmnBf1TrNqg9SK2uhysv8sIVffj2NmWLjwMs+fYjxblDFOKwy86Hb 8l3BbxGqkz/D7koznFtpnTpCvcS39Afuw4rlEE8ek3dMaFIhy+0XOH1FN Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10230"; a="244610216" X-IronPort-AV: E=Sophos;i="5.88,297,1635231600"; d="scan'208";a="244610216" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2022 05:28:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,297,1635231600"; d="scan'208";a="693385595" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga005.jf.intel.com with ESMTP; 18 Jan 2022 05:28:28 -0800 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 18 Jan 2022 05:28:27 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 18 Jan 2022 05:28:27 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 18 Jan 2022 05:28:27 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RrjFUTQY/yjiNoqFhFc79HLAQStf0DCrq9B5dcKw4/9Q15R01ur+RcoW/MWjQ5vTD48zoP+SK0+OdGidqAyt5uWB7VJ1fX3vQOKdXbRC17rb8kf/IId6MXYU9fxNcPM+HcnQ4OJUS0JQf8KYZWEquBu3u8ElLkEp6JGsX9o0kWXAFex3O7iQlRjg0R0fhc9dM3k18+uesnHFxCIY3R6LQD4byhBpGyp2HgmT9gOLF7fByJNoJyblfAK2FuRTJdW0ucrtFYEeP5nVYjquVyxv9PaT7OWIQiNpugrOqAyZTy5RykbHzXdMjfs6kVN/ZSMBlyO11oauBu6Qy/MwjMtFjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uF/biVgN3FY9SSdAJVsfja53dd4K4oMQbX79v14zmgA=; b=BfjqDlk8vzbRIYbHhTTU8hSfrzoyust1+4/mYx4voyPGgqR2tCV8mN7GrEnkwMbjS1qaRTYiG3w+wg6LknnqRY7HH0KuWJslBCgyrdnAJQofnwLIyRbgerHYbaqUhk9x15OptDAnOSxJ7h40TA8DM45FgZ8KnTwHswpyZykQBD7f3eI+vNHKIRglz1RXspQ9EmMt8wHNdYACtVSRd+pYbl2hfzH0VglWz1pqKafiT3p0F79gIcmMGwDi2aCPiGYEDLbGx3l8IMYZOyzOvT/KH7yOqJlX2yOYrUy8wcgrwwn4sUx2yfqSx6IMLQPfFRTyMfJtcKr1puCwYGmYT0oQEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by DM4PR11MB5262.namprd11.prod.outlook.com (2603:10b6:5:389::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Tue, 18 Jan 2022 13:28:25 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4888.014; Tue, 18 Jan 2022 13:28:25 +0000 Message-ID: <67e9d81f-ddd6-795c-cea6-338f281a6819@intel.com> Date: Tue, 18 Jan 2022 13:28:19 +0000 Subject: Re: [PATCH v2] app/testpmd: fix dereference before null check Content-Language: en-US To: Sean Morrissey , Ori Kam , Xiaoyun Li , Aman Singh , Yuying Zhang CC: , , References: <20211209162727.12295-1-sean.morrissey@intel.com> <20220118105309.1362804-1-sean.morrissey@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20220118105309.1362804-1-sean.morrissey@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0353.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18d::16) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9078aae3-8035-4fe2-d19e-08d9da8667f3 X-MS-TrafficTypeDiagnostic: DM4PR11MB5262:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1201; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OJiYPHNyugXOgCY2nn4Cgszm1GgyrljXaBSuLryvUAG42erfTbPZgkGbnQEu84YxaaSZNU+Z8JazK1Cnq+Jpl6dhVj9iPySr6/QpugKAMawh8tALXqKFmj2vsC5u8S68rstTJ2MdR7dCPAxjoayJE2mOoXgRXakX8LtPD2G0tugMPUaUQo0ExzK/OmdRtBgQbkdoReezRybVGDUrDubrs4SgSEsP0fl4GP8KVobs8qBja9iVB/35xIIZVShYnZs0NWJ85W2SoCF/FCLn9OUk8V4hqL67oZlwQ5iXTxdoBKeuwxkICPYztJ//1SKUgTIa9le/7b/VPfV/8FM+rwBxfDqY1Y8PhRwXcXAmfDeafzfN5dtZaXMk8kXNBoDbsi4ErktNe6yMIRibVn3E+0sa8GppwSLvmvq3bXBG3DHWeV28Kxw7NANslqTTk24OB1GeYCGMZ5IlR56hWmUR4oHMQEV6aZFUQX9rf68uf1tpAjZb1lzKFwMAy9E92OeAO2uvxU4D6bQPQDMuZtCJqAYYInTzPCxbyACDe4VQe8JSEGD3krEezAxsS2534mnOsJBMhDtP0N1h4fvE+P0OX4bAK2Wnd/n1/DPacN0Ic4vJ9xd3AN9G+riuzzHKLzPKUGWKmfPQWN9InbdCfhOZwFIrmjdL3ktao4JfECXNyp7Qxcy7ppmGNZzJ/z0PPVQfvhodxYdCiXMV+pZlt6YKYVKUWVbDEDzGb7ERHG63mMeD1M1BzI4+reMr9LcFBDFcrpLw X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6666004)(6506007)(4326008)(316002)(5660300002)(2906002)(107886003)(2616005)(186003)(44832011)(6512007)(6486002)(8936002)(110136005)(4744005)(66476007)(66946007)(508600001)(82960400001)(86362001)(26005)(31686004)(31696002)(36756003)(6636002)(38100700002)(66556008)(53546011)(8676002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?anZ1aDQyMlVrUDFyMSs2cml2WDJFZTBzSjFtZnovV0EyWGs2aTRUMytrY2xB?= =?utf-8?B?NWZXa1NDNEgvL201dytxUUIzSVdhRC9idEE2ODRLZ3gxcmtQV3A2SDJMaG9X?= =?utf-8?B?eHZzbmRkUjZ2R1E1VzJ4dU5FeERudDVmQVVCMHpMeEZ1V2xyTmxKSG9uN1Qx?= =?utf-8?B?b2U2S0NSZmZQY1V3Y25kb2N2VGZuek1xamFuYis5RnhQRkZRbmRKUTQ3V281?= =?utf-8?B?UXFZK0lFNGkwcFp0bFNiMnhtZ1UwbEhQVXpFRWZqbjVlcTNYNlU5dm9yMU9C?= =?utf-8?B?dGJoNXRJdTdMd1ZVT1c1WmZJaFlPU0VKMVlXK0VncDltNmxoNWl0SjhrUzY4?= =?utf-8?B?V01xMXczQ1paRHViQnl6UjZYL3RGNEZ1NmxOeEJKUFRHc3VYQUttVlMxMnUr?= =?utf-8?B?WG1WRG1Ddlh2OVd1QUtqZHA0dGdSWVJBUEo4T04xSDNSandwYlJYTWsrMFhM?= =?utf-8?B?ckRBRGcweXZMVU1SNEg5VUNtV0tSVUp3ZjBac2d6YldzYW90blMvWkE2WlNh?= =?utf-8?B?Y1lXdXpaN1NRZVhnY1ZrTW5pbWRnS1JraTJjejlOajJRd2c0SlpOS3o2VU5M?= =?utf-8?B?SU5GcytDRDl6MkVqL2d3QWRIa3JlU2JmM2RUVG1EY1dWZTRVd1VTcTM3RVRS?= =?utf-8?B?WmR0SGZrTkU0ZXEyYlpzcHBpZFYrS1hwUVE2NHVhZjFnZTRmbVdxZWJrQWts?= =?utf-8?B?aUpHU0gxeEE3NnI5Rlg3T3FxeWE4YmFWaEJpOWhhRTFpMVFiZ1BDVXJvanFF?= =?utf-8?B?SUVjWVhwRFZib3g5VmdhdjFYZ3d4elhjaFZhRVExU3lnQ3RiU3hzTW8rTzE4?= =?utf-8?B?Sm5EUnRnQ2pkeUwvL0VJR1RkbDJPVzR6WU8rdUFmalVXejl5ckRlZUxRWFlJ?= =?utf-8?B?amhNR1BGQWlSRW5HOUZPU2ZxTHdUeXRkV2RKb24rOWlNU2NNcHpYeUY1alRP?= =?utf-8?B?aS96MmVtbGJldDZaeGxmRTMxdmI5M2xhQjl2MGtXZEgwR2xIeVBFUGpJd09M?= =?utf-8?B?cFhKNlVBMUJUMTZuTklQZ0RjbWhiSWVpYWtJRWtNY1I3TG02NmpLbk9HRVJQ?= =?utf-8?B?MjdWQXJHc2htS3RVR1FWQWQ4RldEcXp2U29MaDh1ZDNjSXl6SWVZZk0zRGpa?= =?utf-8?B?WThUY2FKdTJOQXRUbFVaUWg2YlBLQzBzZ05kdEF6UGpGQkxvcVR3U001NjBo?= =?utf-8?B?TEZJVXNVajJVRzhTQUl5TkhLVmIxNnhFWGRhVXAvZzE2ditjNEttaG51UC9J?= =?utf-8?B?TUszUkUreE1LRU1Ydmx2VTFlYkJZQjJOYnlVMExzWCs4QU5LZlgxWi94Z1FQ?= =?utf-8?B?YlpxQnlveitCcFZUclZySTgycUlHR3VvejlnbWJQbW50VnVCdXM0NjNyYTZL?= =?utf-8?B?UFFtMUZXMERrdjMyN2VDbHdJZDByTUY2c3hXSE9teml2c050V0dLUTRKNU9H?= =?utf-8?B?dkZrT0owY2Y5U3YzUUwyVHRsRlhLQUhNQ3QvTS9lOXk0SzB4K1VOd2UrbWFJ?= =?utf-8?B?RTlTSDFTU2hIRDh5SXVEN3dsK1NTQzJqMXF5RERDQ2hIZ1dWL2NRbThVa2Rm?= =?utf-8?B?ZU9KK3NxMDE2WElzMkVOWmVMRkdUV3lqQjNZcnZrQkd1QTNTbVphcWpyb0sz?= =?utf-8?B?L2t5U0gyMm9XSTFrZnk2NHI4Q2xDSEhIK2ltTk13L0NCcnFLanJVVUNpMVd3?= =?utf-8?B?dHNHbWZ6WVdWRHlBb2VxTW1Ecnh0TGlmOWxnTE9PdlIreFhPWklXckZ4ZWIy?= =?utf-8?B?UmR5eE5XOENOUEFTQ0FVK1k1YWppZEUwcVVwWDAwaUlxRnJtMVRFV2NzcTI5?= =?utf-8?B?Z1JaZTAxRmFuYkF3anUyWVlyM1JWZlRHclpVQk8zVGpKbEtkbDZmOFNlU29w?= =?utf-8?B?QjBXZlBZUEZUMlpqWjRjV3Njdk9YNG9QOHVvTTZwdDJMUStwTHhWaXA2RGxw?= =?utf-8?B?WnFHSjRKZG1LV2FiMTVpTEcyY1hBYjJpK3UwOHE2VDhDb3lya0UrbFhuazdW?= =?utf-8?B?eDNrbVRRaVYxdFlxd0szcGdZZ1BLYzJyV3pZNjljalMwUUVHMHNSUXArZmlm?= =?utf-8?B?R3Z0NkdsRk1nRm90YXNFeVJ5dVRWTkFManQ3OURFOCtJdzRZVjJlU3ZYQW85?= =?utf-8?B?cDFSdGh5elNLTlljQjYzbGR1SnZEL01QMXp6cWhsWVhqbTg1WmNXU1ZMZHpM?= =?utf-8?Q?fuBqQ3JqVfbiQyZUaF8+/Fc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9078aae3-8035-4fe2-d19e-08d9da8667f3 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2022 13:28:25.7577 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: m4g+Mi8mCwCQz+PJAHNbgjNk2JM657Wwulbi+A7rQpMOGSQKXd0hgLbro3nJlSp9e2zh0GEo7lGoluFz8+PVyg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5262 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/18/2022 10:53 AM, Sean Morrissey wrote: > Assign 'left' variable only after null check on 'size' > as function returns if 'size' is null. > > Coverity issue: 374381 > Fixes: 169a9fed1f4 ("app/testpmd: fix hex string parser support for flow API") > Cc: stable@dpdk.org > Cc: wei.zhao1@intel.com > > Signed-off-by: Sean Morrissey > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.