From: "Kinsella, Ray" <mdr@ashroe.eu>
To: Fady Bader <fady@mellanox.com>, dev@dpdk.org
Cc: thomas@monjalon.net, tbashar@mellanox.com, talshn@mellanox.com,
yohadt@mellanox.com, dmitry.kozliuk@gmail.com,
harini.ramakrishnan@microsoft.com, ocardona@microsoft.com,
pallavi.kadam@intel.com, ranjit.menon@intel.com,
olivier.matz@6wind.com, arybchenko@solarflare.com,
nhorman@tuxdriver.com
Subject: Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows
Date: Thu, 2 Jul 2020 15:56:46 +0100 [thread overview]
Message-ID: <67f92962-1cc1-cdbc-0371-a57a5b38533d@ashroe.eu> (raw)
In-Reply-To: <7adaf2b2-f7ca-05ce-06f8-f23a59519698@ashroe.eu>
Fady,
Any comments on the below?
Ray K
On 30/06/2020 11:49, Kinsella, Ray wrote:
>
>
> On 22/06/2020 12:55, Fady Bader wrote:
>> Function versioning is not needed on Windows, also the function versioning
>> implementation is not supported by Windows.
>> Function versioning was disabled on Windows.
>>
>> Signed-off-by: Fady Bader <fady@mellanox.com>
>> ---
>> lib/librte_eal/include/rte_function_versioning.h | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/lib/librte_eal/include/rte_function_versioning.h b/lib/librte_eal/include/rte_function_versioning.h
>> index f588f2643b..cee06602e9 100644
>> --- a/lib/librte_eal/include/rte_function_versioning.h
>> +++ b/lib/librte_eal/include/rte_function_versioning.h
>> @@ -11,6 +11,10 @@
>> #error Use of function versioning disabled, is "use_function_versioning=true" in meson.build?
> Do we need a meson error/rule that catches if people explicitly try to enable function_versioning.
> We don't want to just silently fail under such circumstances?
>
> Would something in lib/meson.build would work better?
>
> if use_function_versioning and target_machine.system == "Windows"
> // complain loudly ...
> endif
>
>> #endif
>>
>> +#ifdef RTE_EXEC_ENV_WINDOWS
>> +#undef RTE_BUILD_SHARED_LIB
>> +#endif
>> +
>> #ifdef RTE_BUILD_SHARED_LIB
>>
>> /*
>>
next prev parent reply other threads:[~2020-07-02 14:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <'20200531124151.16848-2-fady@mellanox.com'>
2020-06-22 11:55 ` [dpdk-dev] [PATCH v3 0/4] build mempool " Fady Bader
2020-06-22 11:55 ` [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning " Fady Bader
2020-06-29 23:26 ` Thomas Monjalon
2020-07-02 10:25 ` Fady Bader
2020-06-30 10:49 ` Kinsella, Ray
2020-07-02 14:56 ` Kinsella, Ray [this message]
2020-07-05 7:00 ` Fady Bader
2020-07-05 8:37 ` Thomas Monjalon
2020-07-05 8:51 ` Fady Bader
2020-07-05 9:00 ` Thomas Monjalon
2020-07-05 20:00 ` Thomas Monjalon
2020-07-07 7:57 ` Kinsella, Ray
2020-06-22 11:55 ` [dpdk-dev] [PATCH v3 2/4] mempool: use generic memory management Fady Bader
2020-06-22 11:55 ` [dpdk-dev] [PATCH v3 3/4] eal: export needed functions for mempool Fady Bader
2020-06-29 23:28 ` Thomas Monjalon
2020-07-02 10:24 ` Fady Bader
2020-06-22 11:55 ` [dpdk-dev] [PATCH v3 4/4] mempool: mempool build on Windows Fady Bader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67f92962-1cc1-cdbc-0371-a57a5b38533d@ashroe.eu \
--to=mdr@ashroe.eu \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=fady@mellanox.com \
--cc=harini.ramakrishnan@microsoft.com \
--cc=nhorman@tuxdriver.com \
--cc=ocardona@microsoft.com \
--cc=olivier.matz@6wind.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@mellanox.com \
--cc=tbashar@mellanox.com \
--cc=thomas@monjalon.net \
--cc=yohadt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).