From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 189C5A0A0F; Fri, 16 Apr 2021 11:57:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0394F141C8F; Fri, 16 Apr 2021 11:57:56 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 4A45D141C78 for ; Fri, 16 Apr 2021 11:57:55 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id B80755C0143; Fri, 16 Apr 2021 05:57:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 16 Apr 2021 05:57:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= zv7Qq1wIe0dqx+smTtZScCLNYk+5aq8CQR4zfJROUmw=; b=zmRfHaxgjxL9wMnU 0F7d2KhKMWqOfPIuvDgeD+tWz1iJyGg25rrNSf9RWzOotcRI8BE9i1KNkBCOWW1c qGEhViHJGyZHWaRD7wt/pXo5l0EaIPiiDULey892IQkHHIEBTdkHbkl9SF4DR5W/ CNfe8SbUEhGXaL1WZsj3Zo71LUau6gTTNA/XBI4nf0dblXUeQPdOG3tFNmDpfTdV PHSeaX18KMkLIqfIwgINO27WiRMGAySBnPNfWnaizLMOFD51pvJqZWIKPbXy5vyc 4U+TQqL7aTuqrOokGbrABndLycleELY7GxVZvR/6jkacKFnTVppWg5t7T6zJJwke UfXr9Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=zv7Qq1wIe0dqx+smTtZScCLNYk+5aq8CQR4zfJROU mw=; b=PbybeWpf90u05i/hPLTVIT6ElAvIpd0M1ZAp8KU9Ao9+xo4XuCiMchZbR jxpY/JKdjJAcNPjqlqwPt71l6DfjLy/Y2MvnAKRPvPE8qR4TvDDYo0QhrwRYg4Zr eYBnwuHV3gIfycBJMRZdrb8eqzbjGLzmEBML4so4Hv55BvHDvKV8BU75AHYnFA1J BW5MzFASD+ZkOI55PObtOfNyVmdopYaMzoNkKwS4+VBqW5+hTb6hBVZwdYoY/sGv SGh++7V75XPhJ7W/kCRLuL4I6VNAfxQEnxB4S79db9A6lj34h49BZyiKY6Iim26l pKhzP0vBOXg+69ZOxHjf0tOzJA5Ew== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudelhedgvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 38E72108005B; Fri, 16 Apr 2021 05:57:53 -0400 (EDT) From: Thomas Monjalon To: Lijun Ou , Ferruh Yigit Cc: dev@dpdk.org, linuxarm@openeuler.org, mdr@ashroe.eu Date: Fri, 16 Apr 2021 11:57:51 +0200 Message-ID: <6803418.Bd1l75JkzX@thomas> In-Reply-To: <04c856eb-7112-adf3-f072-ea1a5323c775@intel.com> References: <1618454426-21457-1-git-send-email-oulijun@huawei.com> <2292057.lhpI95xzKh@thomas> <04c856eb-7112-adf3-f072-ea1a5323c775@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH V4] ethdev: add queue state when retrieve queue information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/04/2021 11:41, Ferruh Yigit: > On 4/16/2021 9:58 AM, Thomas Monjalon wrote: > > 16/04/2021 10:46, Lijun Ou: > >> Currently, upper-layer application could get queue state only > >> through pointers such as dev->data->tx_queue_state[queue_id], > >> this is not the recommended way to access it. So this patch > >> add get queue state when call rte_eth_rx_queue_info_get and > >> rte_eth_tx_queue_info_get API. > >> > >> Note: After add queue_state field, the 'struct rte_eth_rxq_info' size > >> remains 128B, and the 'struct rte_eth_txq_info' size remains 64B, so > >> it could be ABI compatible. > > [...] > >> --- a/doc/guides/rel_notes/release_21_05.rst > >> +++ b/doc/guides/rel_notes/release_21_05.rst > >> @@ -251,6 +251,12 @@ ABI Changes > >> function was already marked as internal in the API documentation for it, > >> and was not for use by external applications. > >> > >> +* Added new field ``queue_state`` to ``rte_eth_rxq_info`` structure > >> + to provide indicated rxq queue state. > >> + > >> +* Added new field ``queue_state`` to ``rte_eth_txq_info`` structure > >> + to provide indicated txq queue state. > > > > Not sure we should add a note here for additions which > > do not break ABI compatibility. > > It may be confusing. > > > > Hi Thomas, > > What do about adding the documentation to "API Changes" section? > Since 'rte_eth_rx_queue_info_get()'/'rte_eth_tx_queue_info_get()' can get > 'queue_state' now, which may taken as API change. That's an addition. The users have nothing to change in their existing code, so I think we don't need a note in API or ABI change. The only required note would be in the "New Features".