From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 2FD518D95 for ; Tue, 17 Apr 2018 11:57:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2018 02:57:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,463,1517904000"; d="scan'208";a="46802265" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.128]) ([10.237.220.128]) by fmsmga004.fm.intel.com with ESMTP; 17 Apr 2018 02:57:18 -0700 To: Yangchao Zhou , dev@dpdk.org Cc: thomas@monjalon.net References: <1523958196-6408-1-git-send-email-zhouyates@gmail.com> From: "Burakov, Anatoly" Message-ID: <6821483b-30f3-ac79-208c-406fb46685af@intel.com> Date: Tue, 17 Apr 2018 10:57:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1523958196-6408-1-git-send-email-zhouyates@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] mem: memory leaks of hubedir caused by strdup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 09:57:21 -0000 On 17-Apr-18 10:43 AM, Yangchao Zhou wrote: > Fixes: cb97d93e9d3bb5607681085d20acaca1aa16deb1("mem: share hugepage info primary and secondary") > > Signed-off-by: Yangchao Zhou > --- Please use proper formatting for "fixes" line (refer to DPDK docs for correct way to generate it). Also, this fixes a coverity defect, please also add the following line: Coverity issue: 272585 That said, for actual patch contents, Acked-by: Anatoly Burakov Thanks for fixing this! -- Thanks, Anatoly