Re: [dpdk-dev] [PATCH 2/7] mem: use proper prefix

["Burakov, Anatoly" <anatoly.burakov@intel.com>]

On 31-Oct-18 5:29 PM, Alejandro Lucero wrote:
> Current name rte_eal_check_dma_mask does not follow the naming
> used in the rest of the file.
> 
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> ---

I don't think this belongs in the _mem_ namespace. It is usually used 
for things to do with memory, while the DMA mask IMO sits firmly in the 
domain of EAL, specifically bus subsystem.

However, i don't have strong feelings one way or the other, so if you do 
decide to go forward with this naming...

> diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
> index 04f624246..ef8126a97 100644
> --- a/lib/librte_eal/rte_eal_version.map
> +++ b/lib/librte_eal/rte_eal_version.map
> @@ -295,7 +295,7 @@ EXPERIMENTAL {
>   	rte_devargs_parsef;
>   	rte_devargs_remove;
>   	rte_devargs_type_count;
> -	rte_eal_check_dma_mask;
> +	rte_mem_check_dma_mask;

...then this should be in alphabetical order.

>   	rte_eal_cleanup;
>   	rte_fbarray_attach;
>   	rte_fbarray_destroy;
> 


-- 
Thanks,
Anatoly