From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 38CC3293B for ; Thu, 1 Nov 2018 11:08:20 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Nov 2018 03:08:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,451,1534834800"; d="scan'208";a="246153421" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.72]) ([10.237.220.72]) by orsmga004.jf.intel.com with ESMTP; 01 Nov 2018 03:08:18 -0700 To: Alejandro Lucero , dev@dpdk.org References: <20181031172931.11894-1-alejandro.lucero@netronome.com> <20181031172931.11894-3-alejandro.lucero@netronome.com> From: "Burakov, Anatoly" Message-ID: <68244b83-2810-043e-f9b5-0b8984e99ab9@intel.com> Date: Thu, 1 Nov 2018 10:08:17 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181031172931.11894-3-alejandro.lucero@netronome.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/7] mem: use proper prefix X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 10:08:20 -0000 On 31-Oct-18 5:29 PM, Alejandro Lucero wrote: > Current name rte_eal_check_dma_mask does not follow the naming > used in the rest of the file. > > Signed-off-by: Alejandro Lucero > --- I don't think this belongs in the _mem_ namespace. It is usually used for things to do with memory, while the DMA mask IMO sits firmly in the domain of EAL, specifically bus subsystem. However, i don't have strong feelings one way or the other, so if you do decide to go forward with this naming... > diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map > index 04f624246..ef8126a97 100644 > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -295,7 +295,7 @@ EXPERIMENTAL { > rte_devargs_parsef; > rte_devargs_remove; > rte_devargs_type_count; > - rte_eal_check_dma_mask; > + rte_mem_check_dma_mask; ...then this should be in alphabetical order. > rte_eal_cleanup; > rte_fbarray_attach; > rte_fbarray_destroy; > -- Thanks, Anatoly