From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id BDA0DA0547;
	Wed, 29 Sep 2021 10:42:19 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 8C465410DB;
	Wed, 29 Sep 2021 10:42:19 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 163AA410D7
 for <dev@dpdk.org>; Wed, 29 Sep 2021 10:42:18 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 99FA87F52E;
 Wed, 29 Sep 2021 11:42:17 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 99FA87F52E
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1632904937;
 bh=1QaFHG1W5IC9QJqXSBYSI50dOhLBTkCKkiTDoesmd5Y=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=ktAoPAhBuD3tX0FUKNnnpcgKzFC5dHNWZqw0eMLETA1r309NLMNdKySiajjFyI+fe
 AoK4NaSTrWzQPiGxevvgV8NiuuUDb7YIP+tZWdamlsY6gBCJ7YOzh4nguDbyBEomIz
 BRGRqyy2Sy5Q0EcfYw3ASnxBCUS7Ql6inkLz/slc=
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Xiaoyun Li <xiaoyun.li@intel.com>, Ferruh Yigit <ferruh.yigit@intel.com>, 
 Beilei Xing <beilei.xing@intel.com>, Rosen Xu <rosen.xu@intel.com>,
 Haiyue Wang <haiyue.wang@intel.com>, Ray Kinsella <mdr@ashroe.eu>,
 Jiawen Wu <jiawenwu@trustnetic.com>, Jian Wang <jianwang@trustnetic.com>,
 dev@dpdk.org
References: <20210928161633.1082957-1-andrew.rybchenko@oktetlabs.ru>
 <3606914.QClUM3AYhQ@thomas>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <6824cd8f-70ee-5c49-942d-791d096ad751@oktetlabs.ru>
Date: Wed, 29 Sep 2021 11:42:17 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <3606914.QClUM3AYhQ@thomas>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] ethdev: remove legacy mirroring API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Thomas,

On 9/29/21 11:17 AM, Thomas Monjalon wrote:
> Hi Andrew,
> Thanks a lot for working on this.
> I had sent the deprecation notice and forgot about it, apologies.

No worries. I always liked to delete some code.
I think it is my favorite in programming :-)

> 
> 28/09/2021 18:16, Andrew Rybchenko:
>> A more file grain flow API should be used instead of it.
> 
> Do you mean "fine-grain"?

Thanks. Fixed.

> I think we can reference the rte_flow action to be used:
> 	RTE_FLOW_ACTION_TYPE_SAMPLE

Yes, I think is useful, added in v2.

> 
>> --- a/doc/guides/rel_notes/release_21_11.rst
>> +++ b/doc/guides/rel_notes/release_21_11.rst
>> +* ethdev: Removed the port mirroring API. A more fine grain flow API may
>> +  be used instead.  The structures ``rte_eth_mirror_conf`` and
>> +  ``rte_eth_vlan_mirror`` and the functions ``rte_eth_mirror_rule_set``
>> +  and ``rte_eth_mirror_rule_reset`` along with the associated macros
>> +  ``ETH_MIRROR_*`` are removed.
> 
> Here as well we can mention the replacement RTE_FLOW_ACTION_TYPE_SAMPLE.

Yes, added in v2.