From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 25A6A4F98 for ; Fri, 14 Sep 2018 16:50:31 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id E7C6A2598; Fri, 14 Sep 2018 10:50:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 14 Sep 2018 10:50:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=kYEwXwBFlsKme2f62J5Q10byyT wdCkZzJ5wvH6pH/S0=; b=pZDve9jAKW3HiGQb8e4I0BNm8XwgGLOdUH94tC/eAl m8aFAfPwhZt6mb/QCfXkl+IqtubgNYRBlT7czNyq6zbg84FH0rL3nUdnK7rR/ckj JdRKzVdrs8c594WD1LcYZrf1XxJaII5CGMFJOjnL/KqWR6MmdXeLaiEpXyCRI/zE E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=kYEwXw BFlsKme2f62J5Q10byyTwdCkZzJ5wvH6pH/S0=; b=N4FmxSknDGbmmX+vOi3Dvy MMytCKwn/GdNtirjmb73MP0CJQUmPQnpBH++rkIf/SM8B1+tVDvwVKypGzdvIQvs iXTC+RcOchtMUtIPBOZ84HbcekdAPpq8sndZZm08pxwF3F4Nnexg5SePR21pLlfa im+jvGI7xklhB1P7LFHw5kS2Cnx02TV8SVvotVqm5cVQiVLnThFYZ28iDkitWxXI +l9yhRnsOflkzNkBCj2kytY+i6W6ebM3yNIQtfJR1R9EMgdbMnUjWazgPFNILsO6 JCbjmeCKRZ4i6bwt5sQHP67evEffXKBoa6zVQGinsmY87p3CWiwU2WVKJB1h56Fw == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 17F2FE4121; Fri, 14 Sep 2018 10:50:25 -0400 (EDT) From: Thomas Monjalon To: Arnon Warshavsky Cc: Ilya Maximets , dev@dpdk.org, Stephen Hemminger Date: Fri, 14 Sep 2018 16:50:24 +0200 Message-ID: <6831653.AvvoQPlBBt@xps> In-Reply-To: References: <20180815153346.11495-1-i.maximets@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] devtools: don't use bash extension in checkpatches X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Sep 2018 14:50:31 -0000 16/08/2018 07:25, Arnon Warshavsky: > Hi Ilya > > Let's use single quotes instead of variable. > > > Using the script directly with single quotes loses the ability to reuse it > with an additional set of folders , expressions and RET_ON_FAIL. I don't know awk. Please could you explain what we are loosing and why? > If we wish to keep the awk code in this file and not in a separate file, > maybe receiving the awk script parameters from the function > check_forbidden_additions( ) can also preserve the ability to reuse in > future cases. Yes I feel we could add some parameters to this function. And yes, we could move the awk script in a separate file. Actually, it would be better to keep checkpatches.sh as a wrapper script calling various tools. Thanks