From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29604A0C5A; Mon, 29 Nov 2021 15:05:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC21F4068A; Mon, 29 Nov 2021 15:05:30 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 7857740689 for ; Mon, 29 Nov 2021 15:05:29 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10182"; a="222854622" X-IronPort-AV: E=Sophos;i="5.87,273,1631602800"; d="scan'208";a="222854622" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2021 06:03:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,273,1631602800"; d="scan'208";a="594684468" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by FMSMGA003.fm.intel.com with ESMTP; 29 Nov 2021 06:03:22 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 29 Nov 2021 06:03:21 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 29 Nov 2021 06:03:21 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 29 Nov 2021 06:03:21 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jatow5C3PzXTNblgc/lL0o5XFV4qm/ElaRKijQ0c/1/S90p/EPhXwDV25YXVIKQDkUUtl8rPPW5jU2kHzYjsJdVV+d+IUK8kbmdiwG+xLzE/quNfbbCnqQDwP7hTa4XVgvZt4/kwe1BKwoct1SLJK8FzatEDM+QjZHyz1ThM69/KrDXRjB4s6cWFpndqOUAjwgJ1y1WcosfwTbPuNtutxZkcC/bVcq92qq7GGJPKX1MCimOPvRM2qgxaLVT1xZIyG2OOd4XfC2eZKyqKV4/mZCZCUAXgVbbgHFfO1SI2YIoS5IIyKQHT6wSqfGF3sVM+YgCcT8daNDwUnuqig+3/tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kLJGOXjRZnw9kM/ZheAa27EyIwmBFZyyn/NOugKODiw=; b=YoGOS5ed7N84OD/++XYqfbj/NtUflWmUUJFMsNCy4cTlnidFSvqSntIBABGjzPsL0CLXwSwDy4S+s1Pa9c3PPb/1UuwwzMHZJpk62QNloCKIoU/WqpaO6z++tH0DNhVA5RM99qNMpInXAyH/GMCqfZhddhE7CvPJGvpmMrunH7WY5Bf+AxfzryO1IcE/LOQe6lhlQLa2uiBNdbpVbp1wcfWRf4erRifqNrbXPDYod/vK+LlOTQ0jeGLr+Lavg7CHHw7MIV88ixaVY5YA1tkhPAo4g2i3ei3Y0vZejmkWJ1gGLqEVrQKvX+k/lu46OJv3U/xwa0c1WWwoKs3cg3i+PA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kLJGOXjRZnw9kM/ZheAa27EyIwmBFZyyn/NOugKODiw=; b=WBDkBYJDrC2bkr4yTmIlNZm1mh3qjVGXNRs/UauCx3eHyR4lJIDxfJqJq09xuxLy66YNq/6y4mn747Pom7rV8y+OER9Sb6R6HqhulCXsAut76Fj5/6BpihENu6pk9fP3MCehuj6UIi9Ht6zV/5RhDHFqnVrVOQpu4xFJSFtYd6I= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4918.namprd11.prod.outlook.com (2603:10b6:510:31::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.21; Mon, 29 Nov 2021 14:03:18 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4734.024; Mon, 29 Nov 2021 14:03:18 +0000 Message-ID: <68412427-b6aa-cb38-110a-14bc90d8fdc0@intel.com> Date: Mon, 29 Nov 2021 14:03:12 +0000 Content-Language: en-US To: Bruce Richardson CC: Josh Soref , Josh Soref , , David Marchand , Thomas Monjalon References: <20211126195851.50167-1-jsoref@users.noreply.github.com> <737b8856-a247-3709-ad4c-a074d4547c86@intel.com> From: Ferruh Yigit Subject: Re: [PATCH] Spelling X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6P195CA0010.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::20) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6P195CA0010.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23 via Frontend Transport; Mon, 29 Nov 2021 14:03:17 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cccf1861-f7a2-47c2-1960-08d9b340fece X-MS-TrafficTypeDiagnostic: PH0PR11MB4918: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TnpAJdclaIsuBoky7lLVpdVuC4vLma84phuFl3Ux5Irmzbh43jhmPf/6vo51u8idD29WjNWD7jNPQ6YY9YjtPXsNW5gz9JKE9A2SA2OqxOjoCf6NkHOzA/I3z5DgxTck7THBtz7YlRiiAzfHk2u4P5sl87XLQ24b0oh/YYkSGYMct6EfdN3mD1Ao+9HQoRKlA5L3AcRmdYOcHXHcQrCCZGlvwrTyLTY9DhBbpDKuwaRu/oO36cqasG6lRV5mP+gXfoeFTvmA8tkedwzaBOQxZA9nq/lSOjZw5Mm6G+oabsgMzd9sUZmFX/aApMiad1Ll2J+Bl63de5jEEVGssxD2f/nFeNOL4tQxifRHsFPe0/yeRKhSzokutfwkfSvucZ7dK+uKO/B7n6n3tfFw/my45/yuy1hdKPphFt4ZyPWPHayxdtzL8+2Rfc6rTnfisHGPcPiNbCeevdxYcVleP4JFLtoNRLamyN8E1qYCxWvj2fdTshd2ELerTtGKzmUWwSqkeO94arhAIVAW0M5Hru5dOfYgJ1h/p+C2NFe+a1qRrzzk/1RgW5bj0kw8+rnA9DNIa1ectyc+SPgjIOUYbSF4I9tqARzkeRkn+fei3PgGe1+zEl1vlve6kN5T17dvleRMKaq06NQ0JARPFt5kNrxUbZ36BQFifF1/bZyytsezhsT0RqMUIu0qlqgfufZUqhOSALlfaJtu6L6Op0WO3DE+wA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(82960400001)(956004)(4326008)(2906002)(38100700002)(83380400001)(26005)(2616005)(53546011)(37006003)(6636002)(54906003)(66556008)(31696002)(44832011)(6862004)(316002)(16576012)(186003)(66946007)(36756003)(6486002)(508600001)(31686004)(8936002)(6666004)(86362001)(5660300002)(66476007)(8676002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWhNUXVvN2YvTGJBazAyL2puNU5RR3A1VWRUQytDTmV2S29GSXNYWXhXc0Mx?= =?utf-8?B?dVdIWmM3dmh4MURkMGhoeTAzVEU5MHpOSFRGUDloTjByZ0RFQWpBUVBqbjRV?= =?utf-8?B?UXFOOFZzY2F5Y05tVS8wSVYySVNUTWozNmFvVDBvTUJKcDZ4U1FFbjBKYTJL?= =?utf-8?B?djRBQmNvRjRXT3R2T0lTQ1kvN3NhSHNmZk9WUSs1eVhIWFRTS3pBaCtsZHFn?= =?utf-8?B?Q25mQlpqajI5blBjM0duK0lmRm5IY3hkVU1HQXdnQ1ZDZzBkYkFaMFNJMUYz?= =?utf-8?B?bVRMNE14NkViSm5GN0ZXcFE0cEc5NU9jQlRyZHNjRncxdmFiZmZuNHMzUmlJ?= =?utf-8?B?dCtKSTRuRWFCUmNkVERQRWRlMkQraFE3RnYwdnE4RGlBcTJxeFk1QXBtZVZV?= =?utf-8?B?L2hNajJTbjRPRWsxdzYxZmNINmhGRndYZEExTkJxQkN5c0J6aHVza08rek43?= =?utf-8?B?VTdmc2ZvT1l5dThWRFBjY09tdEdxenNGOXJlNUNjYkdRTGNjKythaEJjTncy?= =?utf-8?B?UVh2bHQ2MWJvLzJFeTMrbWpONXJGNXdNelVDVm50dEs3c2wvbllOWkNKZzVK?= =?utf-8?B?MzM1c2JJM3YxbFhObjVQZzdPOG8xQ1hVR2E4N3loQ0Z6bHM2cnhJU1lkSGF5?= =?utf-8?B?TVlYVis5OUlHTUp1SmpkMEFRL09JYmNvR2hhblRuU24zZTQrTlhaQ1J4ZTll?= =?utf-8?B?TDFWbHJhbFpBc2dpQW5FeFNYSWJQZDNNZmQ5M0hJYWk4c0pQWVBkemQwU2dC?= =?utf-8?B?Uzl4c1dOWExBcklhWHQ0S3FHVUQwcWNjQ1RNL2dNZmhnbnBoSUUrWVBwWit2?= =?utf-8?B?SStFTmRmRkRheGplMGZLVUdvdnI0RXYvak10aE5xS3luQU1Bd0JnL0pGZHJB?= =?utf-8?B?UTdFVE9mWElzdVgvY1Z5KzNwUUJqVE1EaDRWOWxFSTYvNXZWcUoxbm1lSnZX?= =?utf-8?B?U1RodFRidFRlMWRWSGNQY2VpcTVTQmlrWnJrdjg1YkZ4bU1NeDNrOTQ4MFhI?= =?utf-8?B?NVRDdC9lZGQya0JteG1GY0VDclFsOWtaT2xBWHVaNVZvbXBDRnlyby9jeVhG?= =?utf-8?B?dkNZV1JwOXRneHlkZWJOYnc1U3lla251N3d1V0FQeDJRU0JMSkVlYTUzMDJi?= =?utf-8?B?ZHUydHFtM3UxOWZKbmp5NlpqRkdXd2IwMk0zVlBaRmFRYXlBMHQ4Y1pCZXlO?= =?utf-8?B?dGhmNVRLbkx2VFFJKzJUZlRSWEdXWTR1SHJoQ3Rkb2JDZVd0WGt5YVdNaTNL?= =?utf-8?B?blZpUHNzb2E2Qk5FZjBzOHBRTVNaZVJJSE50S3dZalY4bkxPYkdHZ0VaelJ1?= =?utf-8?B?SjBOODhlTW1qa2hKaXZsT1d6ck1VblV1bVRFaVZzcVBnVXVNNnp5Qm5DUTRq?= =?utf-8?B?NmF6Z2YvWldETEZ1M0F3d1dnQzJvQnV6V0FWdW5XRjJndXVwb1Y5SitYQzdF?= =?utf-8?B?d2xCbkpaeWZQVW5tMW14eng2OVdjUkh0cDFndnQzeGpBVkRsMDhtWkpOM0hx?= =?utf-8?B?QmN1cXdRYWJqSUFENUhzS3ZERk1oNk94QzZTb2JlenU0RjEyMmJYbVh4RlpU?= =?utf-8?B?MU9JbEc4VDNFekppa04rQk1QZnBqbEkzbHdmc0JEMUZIWFZiMFhtdmIzcTcz?= =?utf-8?B?TktoUzBOTUd3KzBYcEpFNGw3OVgwRlVVM0svcmc3b1FzUXVjTXU2RnhIR3dW?= =?utf-8?B?V1VKdUFpSnJ6TXVTNmdPVTBmNmYzOTRHL3dSbGxWMlZWNDFpWFdhd1FvaVpK?= =?utf-8?B?RkQvYkwvZ3h5QlIxamcxZEUyOU10Y2ZwRVNSR05PeTJuQ0tOUk9lV2xqZDVY?= =?utf-8?B?ZzRyalZWb0hicXVIbXg3bjBHNXZDV2JORGFpLzN6RGRjRk9tYnAwL3BjSDJI?= =?utf-8?B?dWZEWkplWWNneWF6YTRqekdXSXhMQThYVVBGOThXQzBzVng3RmFoN3g5Qld2?= =?utf-8?B?VU5yS0lubE5yZ1pad3dVbmFoTU91Snd4UXRDR3p0R2RSQ2dpQmR0SUFOejhM?= =?utf-8?B?eDV0UVlabEJFU2kwcUdGcTBiOGRTRlZIdytNR2RiUmFKQ2dNR0xYdzBGVDFR?= =?utf-8?B?eUwzMENlalFMNmpUZTNxVzl0VWFENnNCR0dOdFlXY0l0bVRXZ3RCSW9HVy9I?= =?utf-8?B?U2tOWVdKcHZRdWRKSWw4bDlSTWZzdU95SWlBeXpNQmhQQ21TU2pWMW9pR3pV?= =?utf-8?Q?dv/R84Pw5AcdUCeCY8b/3iw=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: cccf1861-f7a2-47c2-1960-08d9b340fece X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2021 14:03:18.6184 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Kmxi+IyGHHYVSGCGkx2ZvZ4V1+tp2xcV4szM5w8yMY5K3CNN6KFp/7m6qSAkKjRVUGWbLBp/pjXgokJkVWV5sA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4918 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/29/2021 1:59 PM, Bruce Richardson wrote: > On Mon, Nov 29, 2021 at 12:49:56PM +0000, Ferruh Yigit wrote: >> On 11/26/2021 7:58 PM, Josh Soref wrote: >>> diff --git a/app/test-eventdev/test_order_common.c b/app/test-eventdev/test_order_common.c >>> index ff7813f9..603e7c91 100644 >>> --- a/app/test-eventdev/test_order_common.c >>> +++ b/app/test-eventdev/test_order_common.c >>> @@ -253,7 +253,7 @@ void >>> order_opt_dump(struct evt_options *opt) >>> { >>> evt_dump_producer_lcores(opt); >>> - evt_dump("nb_wrker_lcores", "%d", evt_nr_active_lcores(opt->wlcores)); >>> + evt_dump("nb_worker_lcores", "%d", evt_nr_active_lcores(opt->wlcores)); >> >> Hi Josh, Thanks for the patch. >> >> The typo fixes for comments and logs are more straightforward, but I have >> mixed feeling about the variable / macro typo fixes, let's see what others >> think. >> >> And I think we should get this patch either one of the first patch or last >> patch to prevent conflict with other patches. > > +1 to being a first patch to start things off clean. > > For the macros, since there is quick a bit of content in the patch, could > we have the patch split into a separate patch for macro changes to review > separately, allowing the simple doc/printf spelling changes to go in > immediately? > Also as far as I can see there are multiple build errors related to the variable / macro renames, which was the concern.