DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH v2 1/2] devtools: don't include headline "fix" in backports
@ 2021-12-03  7:54 christian.ehrhardt
  2021-12-03  7:54 ` [PATCH v2 2/2] devtools: report commit id on partial fixes christian.ehrhardt
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: christian.ehrhardt @ 2021-12-03  7:54 UTC (permalink / raw)
  To: dev, Thomas Monjalon, Luca Boccassi, Xueming Li, David Marchand,
	Kevin Traynor, Maxime Coquelin
  Cc: Christian Ehrhardt

From: Christian Ehrhardt <christian.ehrhardt@canonical.com>

It was important in the past to select anything with "fix" in the
headline, but recently more often created false positives and work
to sort tihngs out than identifying many helpful patches.

The community and processes aroudn DPDK matured enough that developers
(rightfully) expect to rely on "Fixes:" and "stable@" marking for
backprots.

Therefore do no more include patches that just include the word fix
in the backport candidate list.

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
---
 devtools/git-log-fixes.sh | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh
index 210c8dcf25..27ec9088d4 100755
--- a/devtools/git-log-fixes.sh
+++ b/devtools/git-log-fixes.sh
@@ -13,7 +13,7 @@ print_help ()
 	cat <<- END_OF_HELP
 
 	Find fixes to backport on previous versions.
-	It looks for the word "fix" in the headline or a tag "Fixes" or "Reverts".
+	It looks for a tag "Fixes" or "Reverts" and for recipient stable@dpdk.org.
 	The oldest bug origin is printed as well as partially fixed versions.
 	END_OF_HELP
 }
@@ -109,8 +109,7 @@ while read id headline ; do
 	origins=$(origin_filter $id)
 	stable=$(stable_tag $id)
 	fixes=$(fixes_tag $id)
-	[ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || \
-		echo "$headline" | grep -q fix || continue
+	[ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || continue
 	version=$(commit_version $id)
 	if [ -n "$origins" ] ; then
 		origver="$(origin_version $origins)"
-- 
2.34.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2022-11-26 21:35 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-03  7:54 [PATCH v2 1/2] devtools: don't include headline "fix" in backports christian.ehrhardt
2021-12-03  7:54 ` [PATCH v2 2/2] devtools: report commit id on partial fixes christian.ehrhardt
2021-12-03 12:24   ` Luca Boccassi
2021-12-03 14:05   ` Kevin Traynor
2021-12-05 11:35   ` Xueming(Steven) Li
2021-12-03 12:24 ` [PATCH v2 1/2] devtools: don't include headline "fix" in backports Luca Boccassi
2021-12-03 14:04 ` Kevin Traynor
2022-11-26 21:35   ` Thomas Monjalon
2021-12-05 11:38 ` Xueming(Steven) Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).