Re: [PATCH 0/6] app/procinfo: add some extended features

[Dongdong Liu <liudongdong3@huawei.com>]

Hi David

Many thanks for your review.
On 2022/7/22 18:03, David Marchand wrote:
> On Fri, Jul 22, 2022 at 11:13 AM Dongdong Liu <liudongdong3@huawei.com> wrote:
>>
>> [PATCH 1/6 2/6 3/6] support ethdev info about firmware version, RSS reta info,
>> and module info, from the below link [1] that have been sent out in the
>> earlier,  wait for review.
>> [PATCH 4/6] add dump of Rx/tx burst mode.
>> [PATCH 5/6] fix some wrong doxygen syntax for procinfo suggested by Thomas.
>> [PATCH 6/6] update the procinfo doc guide.
>>
>> [1] https://lore.kernel.org/dpdk-dev/20220527014259.38559-1-humin29@huawei.com/
>
> Some applications may not want to use multiprocess.
> Do you know if those added informations are available through telemetry?

After a quick look at telemetry doc guide and do some telemetry test.
--> /info
It displays dpdk version  but not include ethdev firmware version.
The ethdev firmware version maybe better to be added for /ethdev/info
cmd.

--> /ethdev/module_eeprom,0
It displays ports module eeprom information.

RSS reta info, Rx/Tx burst mode have not been supported by telemetry.
It is a good idea to add these features through telemetry.

This patchset add some extended features for procinfo, we can also
apply them, later will add these features through telemetry.

Current some features have been supported by procinfo in dpdk mainline
code, but not supported by telemetry, maybe we can also implement them 
through telemetry.

Thanks,
Dongdong

>
>