From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 744511B01D for ; Wed, 17 Jan 2018 13:34:10 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2018 04:34:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,372,1511856000"; d="scan'208";a="20475137" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by FMSMGA003.fm.intel.com with ESMTP; 17 Jan 2018 04:34:09 -0800 To: Yuanhan Liu , dev@dpdk.org Cc: Thomas Monjalon References: <1516114218-21501-1-git-send-email-yliu@fridaylinux.org> From: Ferruh Yigit Message-ID: <68453aa8-de09-c41b-0b84-82eb6bbe19ac@intel.com> Date: Wed, 17 Jan 2018 12:34:08 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1516114218-21501-1-git-send-email-yliu@fridaylinux.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jan 2018 12:34:11 -0000 On 1/16/2018 2:50 PM, Yuanhan Liu wrote: > This patch documents the new devargs syntax, which is going to be > implemented in DPDK v18.05. > > The new devargs proposal is introduced for having a consistent > interface for: > > - whitelisting/blacklisting devices > - identifying ports > - attaching/detaching devices Hi Yuanhan, devargs = device arguments, the PMD specific arguments, similar to module_param in Linux. Currently only "--vdev" and -w/-b eal parameters parse proceeding strings as devargs. Like: "--vdev "net_pcap,iface=lo" . For this case "iface=lo" device specific argument and available to use from pcap PMD. I agree it to have a consistent way to describe device, that makes better whitelist/blacklist support. But that part is not device args, more like device identifier. When you use this string with whitelist/blacklist I think you won't need "iface=lo" part, only need first part. And when using with --vdev, (or perhaps with attach) you don't need to use first part "bus=pci,id=0000:01:00.0/class=eth,mac=00:11:22:33:44:55", PMD already knows it is in virtual bus and its class etc. So does it make sense to separate them logically? Perhaps as "device identifier" and "device args". string can become: "device=bus=pci,id=0000:01:00.0/class=eth,mac=00:11:22:33:44:55;driver=PMD_NAME,driverspecificproperty=VALUE" specific usages can become: -w "device=bus=pci,id=0000:01:00.0/class=eth,mac=00:11:22:33:44:55" --vdev "driver=PMD_NAME,driverspecificproperty=VALUE" And store them in two separate storage, and eal or PMD can ask for "device identifier" or "device args" separately? What do you think? > > Please check the patch content for the details. Also, here is link > for the background: > http://dpdk.org/ml/archives/dev/2017-November/082600.html > > This syntax is suggestd by Thomas: > http://dpdk.org/ml/archives/dev/2017-December/084234.html > > Signed-off-by: Yuanhan Liu > --- > doc/guides/prog_guide/env_abstraction_layer.rst | 34 +++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/doc/guides/prog_guide/env_abstraction_layer.rst b/doc/guides/prog_guide/env_abstraction_layer.rst > index 34d871c..12f37f2 100644 > --- a/doc/guides/prog_guide/env_abstraction_layer.rst > +++ b/doc/guides/prog_guide/env_abstraction_layer.rst > @@ -213,6 +213,40 @@ device having emitted a Device Removal Event. In such case, calling > callback. Care must be taken not to close the device from the interrupt handler > context. It is necessary to reschedule such closing operation. > > +Devargs > +~~~~~~~ > + > +The ``devargs`` can be used for whitelisting/blacklisting devices, identifying > +DPDK ports and attaching/deatching devices. They all share the same syntax. > + > +It is split in 3 categories, where almost everything is optional key/value pairs: > + > +* bus (pci, vdev, vmbus, fslmc, etc) > +* class (eth, crypto, etc) > +* driver (i40e, mlx5, virtio, etc) > + > +The key/value pair describing the category scope is mandatory and must be the > +first pair in the category properties. Example: bus=pci, must be placed before > +id=0000:01:00.0. > + > +The syntax has below rules: > + > +* Between categories, the separator is a slash. > +* Inside a category, the separator is a comma. > +* Inside a key/value pair, the separator is an equal sign. > +* Each category can be used alone. > + > +Here is an example with all categories:: > + > + bus=pci,id=0000:01:00.0/class=eth,mac=00:11:22:33:44:55/driver=PMD_NAME,driverspecificproperty=VALUE > + > +It can also be simple like below:: > + > + class=eth,mac=00:11:22:33:44:55 > + > +A device is identified when every properties are matched. Before device is > +probed, only the bus category is relevant. > + > Blacklisting > ~~~~~~~~~~~~ > >