From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B209E425A6; Fri, 15 Sep 2023 17:54:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45618402B8; Fri, 15 Sep 2023 17:54:47 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2046.outbound.protection.outlook.com [40.107.244.46]) by mails.dpdk.org (Postfix) with ESMTP id 4396E402AF for ; Fri, 15 Sep 2023 17:54:45 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BrDaom3zvBnzncfe+6Ae09C/cL7et3XPAVjSEGGPDJA/br0nvi7f1LxCgRAU3JSLXa4MBD1beizhrllEyeKDWHYqrm+NGlAI27KmU/QN0lnPRtDH5C7nWhC2kp27cY+gEJXnDRr/lISbwS2EfJBHFvorc2grBw4ivfoGZNmlXPrTsYsTRsj0JcJQVDuHhPd+Nbfc5F135iGXngCf0CRs/U2hNV2eQ0EqWMdeTg2vBtcr9iCBP1d8nylKeiGUQs3GbkdcCRLxUmF0GRb3bey6gVQNnkNNYtBR0wfK/6fwL3yRxS+dp96ePY6s4+/kEpKYi1xwq/NiXe2GtMr1Qj2Zlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RH0zLLFu4qhav0xhcAB0Qfv0MdLDR1M6Iqnc96c3Vnc=; b=ljzvrDWOhSk73elGQzJHSrr9TnrVYVfhm9ls71P9MuUrwiJhBV6Stcj6OzHGwWXSdr3O9jXq45QvVbV7zmat2AP8fEdtr7KsiUDhJmzXfVy51p6A2Xr4PsqxaUELO8RkSJYUQ1n1jJ7z60mZPo4kNl5f2zLgrygSEyc6gLvALriPZ75t1HHVak/Gazc1+WfCAKurMotltixpSZAqR67mik3g7gHRpYRbzIyQSmn7BNOMiIbiCye7+4rlMQ2VD465Y/G9xaEwahpf301iq+EO3IzsjFf4E62b6u1Qjm0749K6725VLGYfRtLmZNN4rPsspE20hpoc7CXtFGzB3RgtVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RH0zLLFu4qhav0xhcAB0Qfv0MdLDR1M6Iqnc96c3Vnc=; b=a6RYqkzYUryfywLpJHivUIJqBruSnex4CdczNeLBl2W61uK35VRLnz6IXOhSoyr2UFbplLiXg63LzUNGpFGrUOILtbQ0hn+9EjiuZxyQsQK4OFip1jRgJyiJjfLe+XiKeyCl5PQvxpx6su4F5oAUtUPoKWqOaXq0r7i3OlfDoTo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH0PR12MB5388.namprd12.prod.outlook.com (2603:10b6:610:d7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.21; Fri, 15 Sep 2023 15:54:39 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6792.021; Fri, 15 Sep 2023 15:54:39 +0000 Message-ID: <684a4b8f-3cf5-49fd-a196-291132146b4d@amd.com> Date: Fri, 15 Sep 2023 16:54:32 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v16 1/8] net/ntnic: initial commit which adds register defines Content-Language: en-US To: Mykola Kostenok , dev@dpdk.org, Christiam Muf Cc: thomas@monjalon.net, ckm@napatech.com, andrew.rybchenko@oktetlabs.ru References: <20230816132552.2483752-1-mko-plv@napatech.com> <20230908160715.2498821-1-mko-plv@napatech.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20230908160715.2498821-1-mko-plv@napatech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0069.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5d::33) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH0PR12MB5388:EE_ X-MS-Office365-Filtering-Correlation-Id: 9a9bf340-5ac9-4da8-1e5c-08dbb6041135 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ml4ipItZNL0+jaNuqNGnBF/m09MQ/736pDy0EVVT29bhCcAKJPceVOzC5C/1qIfqMUkQ/U9KE+DSnC19k9n4PwBDeaLDHCpUaM1WkCOUJg38Lpq6T1bbo3j1DDBsZpuGdPbCaiFEj7Qj5ihQMhgZZD/0xHzQtt3+N472wyyJxZQvlo22Tgi+SmHPq7VMT0Uv9OwtyWilBeBxt82j/DNqBtFSR9mcxs/FjndPKk7UZUYUcO9U9bJ2tNhjKoFlLcai4DKMUXtxSLZYFg2n3F2Jjvq5aloso9sWAzbn3l2eWKz8M+O1bqxTMtLzDB1EaVunmm8/POEaavLM7XQKDeVcXPeE9d58O6C/EcTe0gcxpIfuR25kLcT7aLchShwROo5ogyMhlS3/HUIhljC6O5k69tdW4QS0Nwo1mb6RbXC5cWz4PDpGLuDQ+fL3qPY8wgiKoTWqbV2AP/rnhy70aEKilsM/cG/HtkuNmFb8Lkb2TYWhmN9/HJuYYH/ibKYdOjkUDjb1Bu75ZkDV5A4myNGY9CNSCHl/nub12Rca+xAdHM7Er8/BoYz9vUCGKIoFsZCD67GNggMRvAHg6dFa0U4nA10Kub1VSScyzMJSMtgBr3bklH+f3vTJw4zOAqxEmQ8xFz/bHySXTgdciJjMgyIKow== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(366004)(376002)(136003)(39860400002)(346002)(451199024)(1800799009)(186009)(6506007)(6486002)(53546011)(8936002)(8676002)(4326008)(6512007)(6666004)(110136005)(66476007)(66946007)(66556008)(316002)(38100700002)(478600001)(41300700001)(36756003)(2906002)(31686004)(31696002)(86362001)(44832011)(2616005)(5660300002)(26005)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VnhxSDRJOUFhL09vcmtUd09NaVQyL1IrcDR5WVEreHNHLzFGLzBneEFTM0gy?= =?utf-8?B?VW9uZXIxOHJ4bXphN1RubGlEeEJxSmpXRkhEcktJR24wZUlDTHZ6S2FGWTgy?= =?utf-8?B?eTdFK0J1NVJzRVBXYXN3NWNFM3pBWWpzdEdJN1dBNTE5Q3ZULzRpOWVXVStJ?= =?utf-8?B?MWlwUjBUQ1FYVXIwNGpUYktBUGM3R09XM2h6Q3EwNzExaEJqTlNuaDhpREky?= =?utf-8?B?Ly96NVNNZFdBSGlaMVBqMWtsTGZNTFBaN3gwRUhsa1JGbVpGZ1VxeWJmVnho?= =?utf-8?B?ekdXcGhaY2pNYkN1RDMvOW50OGNYd3hYVm1SN1RYTUw0RWNGdnk3UW55dlVI?= =?utf-8?B?Nng0TmZ6TzlOYjZsblZBQUhVY21raS9zR0NIeDdKZlV1NnVFMW9WMXRCOHNE?= =?utf-8?B?QmR4Z3huTjhaS0EvNm5FYkpUUkhIdFBCeElPa203UmM1UjVVT3NobU1IQ29w?= =?utf-8?B?M3BxeWlBVUo0UlZ5dXNIS011RVBDMlN0b3JvYmU3R0owSFFJTCt3ZXlnYWhI?= =?utf-8?B?RXVsczFCbW5Cd09PNVVMYVdKRzRGTmZtbFdXNHh4T1NwdVV4bGFhVTl3REZa?= =?utf-8?B?c2lQbjI4SzJTdVZMRU5paVl2d3ZoUDBlQnNhOFhaYXU5bDNTN2EvRlF6c3Jw?= =?utf-8?B?OU5PWkdBMmVuZlRiUXhNRUFIV2hlZEVHL2FOelE4YTRUdk5LakNIL3gwRUR1?= =?utf-8?B?MzliS2xJREZZMmUwNE9WOElzSGxXT0IxT0NYTjl0MW1saWIrTEhLRzZMV0h1?= =?utf-8?B?WUVjWW4xenEwUDBtZjJzRHdQa1JWdWF5cjJvbjV1bldNbm5hOE1kemZ2VGp3?= =?utf-8?B?T2oxL0FWRDRYQTE4WjVRWVZkM2c5bWlTMHo4SFVZalBpRmk1Rks5YnZpcW5v?= =?utf-8?B?U3QzWGNQRUY1bVpaWlNHdndzdU1zSHd2dGtaVC96aWdtbmdrYTkybXk3Mk5T?= =?utf-8?B?K1BNc0praGtpOU5FV3dCQ2tCOEhtaE56UWMxTm5MZDlRWDkvWHN2RmN4b2Qr?= =?utf-8?B?YSs0SmhRWko5M3pFMTZYSkVGOTc0cmtsUHlMUXA2VzNZU3Z1UkJ0U2UxR2hl?= =?utf-8?B?cW5pLzVwZVRXdHJsd2IzQnBkZWtoNXhuUW5takorL1c2T3c5ak5NVVlFcS9q?= =?utf-8?B?R1ZIVEFDdWhDSS8rZHJjSXhybVE3MUNCN2pGanpNdTEwaEJZeTdDNWM2dDJ1?= =?utf-8?B?L1JnRmFRblRNeG9BMEZrdHlxQ3FzUnY5QU9iRGJVNHdGcXN6YzFIbFIwL3BU?= =?utf-8?B?ank1Ym5DTjROOHBkK0hQTCthcVlPSDY1anpWSnZiN1AyOXFrUGVTU2xkbVR2?= =?utf-8?B?NUlrbDk2V29rNUZPVVArWWFoSTQvRjdObW5CbENXazRkTkJsNzh1WnFhTm5x?= =?utf-8?B?S0NOYys0VGw0OFcrQkxaK2hGK1oxZzhZZExTM2x0bUNvc2NDRmNqRFk2SnpG?= =?utf-8?B?YTlGdzhwWmFFamNRL3dtd1lDYmFWeGJwb1dnd1JWeW4yUEQ2M3AwNnBWU1JH?= =?utf-8?B?WUI0b0gvejRManV6aVcyKytwekdWNm9hWUpURkQ0NGJUV1ZmWTl5SGNrRmx0?= =?utf-8?B?bmpIK3k3OEV2ZVhadm1RcjJ0V2wxeEFNcXJPZFNoVjRBc1dRR2p4V2tnaklD?= =?utf-8?B?aHVxaURkMzdjdEpCYk5Pcy9sOW5QRDRvTjFQM0E3Ym5IeW1rcFJUUlZBT002?= =?utf-8?B?ZmZzN1N0bkNGSW9tcTRSU1hJU1h4ZkQxWGh5MzNVZ3lWWHNFTlpZbEx4U0Jk?= =?utf-8?B?cUFlUER2eFBHbUlDNXZNa0diUm92emdDTmxvSGY2U2hqTGluY1BpNWhVTUQx?= =?utf-8?B?cmR3ZmQrV2ltRFVCS21NV2ZkaWg2S2Yyd2o5NlF5R3FoS2Z6SFI1WEVhaWJB?= =?utf-8?B?K1ZMTkdWS0YxSGxOeklYR2FCZVhyVGlPVlhkR0RzdGo1emJLdTZieHlHYlN6?= =?utf-8?B?MS9nQzg0Q0Z6Q2ZFTWdJWlVaUFEyY3RKZ2FOb2hPN3FxNWNVdTN4KzZKWlpQ?= =?utf-8?B?T1BhS053VEJpeTdMUTNhZFoxaDRtRGxCVnhEN1prSFdRWlhDc2RBNXNvcUtY?= =?utf-8?B?UUI0djlvOGdlVFkrUG1KdkdOZHRYaWx3SWN5a0lVSnZwSU9Ocm9OdVJ3dDNM?= =?utf-8?Q?nUf9CXBXD1cqYWHqaFRTHX9NI?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a9bf340-5ac9-4da8-1e5c-08dbb6041135 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2023 15:54:39.0959 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2hvims/uX9QxiBI17Knt9UratN3ckWAsOaqr1jbWn0O4frRMhI8V/a41Ygj6rLWL X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5388 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/8/2023 5:07 PM, Mykola Kostenok wrote: > From: Christian Koue Muf > > The NTNIC PMD does not rely on a kernel space Napatech driver, > thus all defines related to the register layout is part of the PMD > code, which will be added in later commits. > > Signed-off-by: Christian Koue Muf > Reviewed-by: Mykola Kostenok > Hi Mykola, Christiam, This PMD scares me, overall it is a big drop: "249 files changed, 87128 insertions(+)" I think it is not possible to review all in one release cycle, and it is not even possible to say if all code used or not. I can see code is already developed, and it is difficult to restructure developed code, but restructure it into small pieces really helps for reviews. Driver supports good list of features, can it be possible to distribute upstream effort into multiple release. Starting from basic functionality and add features gradually. Target for this release can be providing datapath, and add more if we have time in the release, what do you think? Also there are large amount of base code (HAL / FPGA code), instead of adding them as a bulk, relevant ones with a feature can be added with the feature patch, this eliminates dead code in the base code layer, also helps user/review to understand the link between driver code and base code. As far as I understand last patch opens a socket interface and an external application can sent control commands via this interface. I am not sure about this side control channel, what is missing in the DPDK API? Can we try to address them in the DPDK layer instead of a driver specific solution? Thanks, ferruh