From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id 6D5E42A9 for ; Wed, 17 Dec 2014 00:57:02 +0100 (CET) Received: by mail-wi0-f172.google.com with SMTP id n3so13932755wiv.17 for ; Tue, 16 Dec 2014 15:57:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=TH+/M3JkoYCyGp0HtngF6SQ0KcMFmvP8nQNL3iDAeMQ=; b=lZFoo5VAazC6RMmx6hC1poiPlxLld5lzJVD0TEu/4cq5GxakUNeUO9CAxrPDolqNc4 KEND/tj/TC34PZk81nRI9E1c05l8x7ceyA3QZntsfGVbIx4xhhMX2PFnvvCgfiLWcUwd mUZdoFY/z9LXw8chaB7jNME3kmkkyN0bKAAXhit8qZG2Hc9EZO95WxREmii8FbtLAcTB Brn4eHkrxDhiSuEEnWrnl1yk3nEuJy4rJkWyRyech4V9a0k7lMaR1FCjex8Ao2EzJKTN GaIfcn6jgZXcor6PmB5nZqq7RA+jv9IJl9EbLGR0G5in56asM1gt1GRkHLxN3ePlZkj7 dQsA== X-Gm-Message-State: ALoCoQlihFpGBBTv/Kmc6v7wHpDcsG/99rblpeDXS2bG9XDoj0PSHJ3y2MqqRfkA1HdGEoJw9VlF X-Received: by 10.180.73.235 with SMTP id o11mr8935296wiv.51.1418774222308; Tue, 16 Dec 2014 15:57:02 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id wx3sm2928095wjc.19.2014.12.16.15.57.00 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Dec 2014 15:57:01 -0800 (PST) From: Thomas Monjalon To: Konstantin Ananyev Date: Wed, 17 Dec 2014 00:56:35 +0100 Message-ID: <6854580.rpBbEFEqVn@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <54898F06.2060503@6wind.com> References: <1418298582-6953-1-git-send-email-konstantin.ananyev@intel.com> <54898F06.2060503@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] librte_net: fix TX checksum offload problem with IPv6 packet. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Dec 2014 23:57:02 -0000 > > For rte_ipv6_phdr_cksum() gcc 4.8.* with "-O3" not always generates > > correct code. > > Sometimes it 'forgets' to put len and proto fields of psd_header on the stack. > > To overcome that problem and speedup things a bit, refactored rte_raw_cksum() > > by splitting ipv6 pseudo-header csum calculation into 3 phases: > > 1. calc sum for src & dst addresses > > 2. add sum for proto & len. > > 3. finalise sum > > That makes gcc to generate valid code and helps to avoid any copying. > > > > Signed-off-by: Konstantin Ananyev > > Acked-by: Olivier Matz Applied Thanks -- Thomas