DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Julien Massonneau <julien.massonneau@6wind.com>
Cc: dev@dpdk.org, stable@dpdk.org, david.marchand@redhat.com,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH] usertools: fix parsing error from dpdk-pmdinfo.py
Date: Sun, 22 Nov 2020 22:09:34 +0100	[thread overview]
Message-ID: <6856178.pT7LhGLBB5@thomas> (raw)
In-Reply-To: <20201119094401.1322-1-julien.massonneau@6wind.com>

19/11/2020 10:44, Julien Massonneau:
> In the display_pmd_info_strings function, the script parses the section
> until to find a byte between 32 and 127, and get all data
> until a byte equals to 0.
> After, it searches "PMD_INFO_STRING" in the data and passes the whole
> string in the parse_pmd_info_string function, which split the string
> with "=" and convert it in python dict with json.loads().
> 
> But the string may contain a "=" before "PMD_INFO_STRING",
> so it is not correctly split and will lead to an error
> (json.decoder.JSONDecodeError).
> 
> Example of a string encountered that leads to an error:
> 
> "Ag%=C£°ÐÊ+Ë®{0´wË-£0òjB·;¾¬úPMD_INFO_STRING= {"name" :
> "net_octeontx", "params" : "nr_port=<int> ", "pci_ids" : []}"
> 
> Fixes: c67c9a5c646a ("tools: query binaries for HW and other support information")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Julien Massonneau <julien.massonneau@6wind.com>

Applied, thanks



      reply	other threads:[~2020-11-22 21:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19  9:44 Julien Massonneau
2020-11-22 21:09 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6856178.pT7LhGLBB5@thomas \
    --to=thomas@monjalon.net \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=julien.massonneau@6wind.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).