From: Thomas Monjalon <thomas@monjalon.net>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Alexander Kozyrev <akozyrev@nvidia.com>,
"dev@dpdk.org" <dev@dpdk.org>, Ori Kam <orika@nvidia.com>
Cc: "ivan.malov@oktetlabs.ru" <ivan.malov@oktetlabs.ru>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"mohammad.abdul.awal@intel.com" <mohammad.abdul.awal@intel.com>,
"qi.z.zhang@intel.com" <qi.z.zhang@intel.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>
Subject: Re: [PATCH v5 03/10] ethdev: bring in async queue-based flow rules operations
Date: Thu, 17 Feb 2022 15:34:17 +0100 [thread overview]
Message-ID: <6856670.dE46n4Xy2H@thomas> (raw)
In-Reply-To: <MW2PR12MB4666F49116C7204C762413C2D6369@MW2PR12MB4666.namprd12.prod.outlook.com>
17/02/2022 15:16, Ori Kam:
> From: Ori Kam
> > From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> > > On 2/16/22 17:53, Ori Kam wrote:
> > > > From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> > > >> On 2/12/22 05:19, Alexander Kozyrev wrote:
> > > >>> On Fri, Feb 11, 2022 7:42 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>:
> > > >>>>> +/**
> > > >>>>> + * @warning
> > > >>>>> + * @b EXPERIMENTAL: this API may change without prior notice.
> > > >>>>> + *
> > > >>>>> + * Queue operation attributes.
> > > >>>>> + */
> > > >>>>> +struct rte_flow_q_ops_attr {
> > > >>>>> + /**
> > > >>>>> + * The user data that will be returned on the completion events.
> > > >>>>> + */
> > > >>>>> + void *user_data;
> > > >>>>
> > > >>>> IMHO it must not be hiddne in attrs. It is a key information
> > > >>>> which is used to understand the opration result. It should
> > > >>>> be passed separately.
> > > >>>
> > > >>> Maybe, on the other hand it is optional and may not be needed by an application.
> > > >>
> > > >> I don't understand how it is possible. Without it application
> > > >> don't know fate of its requests.
> > > >>
> > > > IMHO since user_data should be in all related operations API
> > > > along with the attr, splitting the user_data will just add extra parameter
> > > > to each function call. Since we have number of functions and will add
> > > > more in future I think it will be best to keep it in this location.
> > >
> > > My problem with hiding user_data inside attr is that
> > > 'user_data' is not an auxiliary attribute defining extra
> > > properties of the request. It is a key information.
> > > May be attr is not an ideal name for such grouping
> > > of parameters. Unfortunately I have no better ideas right now.
> > >
> > I understand your point, if you don't have objections lets keep the current one
> > and if needed we will modify.
> > Is that O.K?
>
> Thinking about it again,
> lets move it to a dedecated parameter.
I'm OK with the decision of moving user_data as a function parameter.
next prev parent reply other threads:[~2022-02-17 14:34 UTC|newest]
Thread overview: 218+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220206032526.816079-1-akozyrev@nvidia.com >
2022-02-09 21:37 ` [PATCH v4 00/10] ethdev: datapath-focused flow rules management Alexander Kozyrev
2022-02-09 21:38 ` [PATCH v4 01/10] ethdev: introduce flow pre-configuration hints Alexander Kozyrev
2022-02-09 21:38 ` [PATCH v4 02/10] ethdev: add flow item/action templates Alexander Kozyrev
2022-02-09 21:38 ` [PATCH v4 03/10] ethdev: bring in async queue-based flow rules operations Alexander Kozyrev
2022-02-09 21:38 ` [PATCH v4 04/10] app/testpmd: implement rte flow configuration Alexander Kozyrev
2022-02-10 9:32 ` Thomas Monjalon
2022-02-09 21:38 ` [PATCH v4 05/10] app/testpmd: implement rte flow template management Alexander Kozyrev
2022-02-09 21:38 ` [PATCH v4 06/10] app/testpmd: implement rte flow table management Alexander Kozyrev
2022-02-09 21:38 ` [PATCH v4 07/10] app/testpmd: implement rte flow queue flow operations Alexander Kozyrev
2022-02-09 21:53 ` Ori Kam
2022-02-09 21:38 ` [PATCH v4 08/10] app/testpmd: implement rte flow push operations Alexander Kozyrev
2022-02-09 21:38 ` [PATCH v4 09/10] app/testpmd: implement rte flow pull operations Alexander Kozyrev
2022-02-09 21:38 ` [PATCH v4 10/10] app/testpmd: implement rte flow queue indirect actions Alexander Kozyrev
2022-02-10 16:00 ` [PATCH v4 00/10] ethdev: datapath-focused flow rules management Ferruh Yigit
2022-02-10 16:12 ` Asaf Penso
2022-02-10 16:33 ` Suanming Mou
2022-02-10 18:04 ` Ajit Khaparde
2022-02-11 10:22 ` Ivan Malov
2022-02-11 10:48 ` Jerin Jacob
2022-02-11 2:26 ` [PATCH v5 " Alexander Kozyrev
2022-02-11 2:26 ` [PATCH v5 01/10] ethdev: introduce flow pre-configuration hints Alexander Kozyrev
2022-02-11 10:16 ` Andrew Rybchenko
2022-02-11 18:47 ` Alexander Kozyrev
2022-02-16 13:03 ` Andrew Rybchenko
2022-02-16 22:17 ` Alexander Kozyrev
2022-02-17 10:35 ` Andrew Rybchenko
2022-02-17 10:57 ` Ori Kam
2022-02-17 11:04 ` Andrew Rybchenko
2022-02-11 2:26 ` [PATCH v5 02/10] ethdev: add flow item/action templates Alexander Kozyrev
2022-02-11 11:27 ` Andrew Rybchenko
2022-02-11 22:25 ` Alexander Kozyrev
2022-02-16 13:14 ` Andrew Rybchenko
2022-02-16 14:18 ` Ori Kam
2022-02-17 10:44 ` Andrew Rybchenko
2022-02-17 11:11 ` Ori Kam
2022-02-11 2:26 ` [PATCH v5 03/10] ethdev: bring in async queue-based flow rules operations Alexander Kozyrev
2022-02-11 12:42 ` Andrew Rybchenko
2022-02-12 2:19 ` Alexander Kozyrev
2022-02-12 9:25 ` Thomas Monjalon
2022-02-16 22:49 ` Alexander Kozyrev
2022-02-17 8:18 ` Thomas Monjalon
2022-02-17 11:02 ` Andrew Rybchenko
2022-02-16 13:34 ` Andrew Rybchenko
2022-02-16 14:53 ` Ori Kam
2022-02-17 10:52 ` Andrew Rybchenko
2022-02-17 11:08 ` Ori Kam
2022-02-17 14:16 ` Ori Kam
2022-02-17 14:34 ` Thomas Monjalon [this message]
2022-02-16 15:15 ` Ori Kam
2022-02-17 11:10 ` Andrew Rybchenko
2022-02-17 11:19 ` Ori Kam
2022-02-11 2:26 ` [PATCH v5 04/10] app/testpmd: add flow engine configuration Alexander Kozyrev
2022-02-11 2:26 ` [PATCH v5 05/10] app/testpmd: add flow template management Alexander Kozyrev
2022-02-11 2:26 ` [PATCH v5 06/10] app/testpmd: add flow table management Alexander Kozyrev
2022-02-11 2:26 ` [PATCH v5 07/10] app/testpmd: add async flow create/destroy operations Alexander Kozyrev
2022-02-11 2:26 ` [PATCH v5 08/10] app/testpmd: add flow queue push operation Alexander Kozyrev
2022-02-11 2:26 ` [PATCH v5 09/10] app/testpmd: add flow queue pull operation Alexander Kozyrev
2022-02-11 2:26 ` [PATCH v5 10/10] app/testpmd: add async indirect actions creation/destruction Alexander Kozyrev
2022-02-12 4:19 ` [PATCH v6 00/10] ethdev: datapath-focused flow rules management Alexander Kozyrev
2022-02-12 4:19 ` [PATCH v6 01/10] ethdev: introduce flow pre-configuration hints Alexander Kozyrev
2022-02-12 4:19 ` [PATCH v6 02/10] ethdev: add flow item/action templates Alexander Kozyrev
2022-02-12 4:19 ` [PATCH v6 03/10] ethdev: bring in async queue-based flow rules operations Alexander Kozyrev
2022-02-12 4:19 ` [PATCH v6 04/10] app/testpmd: add flow engine configuration Alexander Kozyrev
2022-02-12 4:19 ` [PATCH v6 05/10] app/testpmd: add flow template management Alexander Kozyrev
2022-02-12 4:19 ` [PATCH v6 06/10] app/testpmd: add flow table management Alexander Kozyrev
2022-02-12 4:19 ` [PATCH v6 07/10] app/testpmd: add async flow create/destroy operations Alexander Kozyrev
2022-02-12 4:19 ` [PATCH v6 08/10] app/testpmd: add flow queue push operation Alexander Kozyrev
2022-02-12 4:19 ` [PATCH v6 09/10] app/testpmd: add flow queue pull operation Alexander Kozyrev
2022-02-12 4:19 ` [PATCH v6 10/10] app/testpmd: add async indirect actions creation/destruction Alexander Kozyrev
2022-02-19 4:11 ` [PATCH v7 00/10] ethdev: datapath-focused flow rules management Alexander Kozyrev
2022-02-19 4:11 ` [PATCH v7 01/11] ethdev: introduce flow engine configuration Alexander Kozyrev
2022-02-19 4:11 ` [PATCH v7 02/11] ethdev: add flow item/action templates Alexander Kozyrev
2022-02-19 4:11 ` [PATCH v7 03/11] ethdev: bring in async queue-based flow rules operations Alexander Kozyrev
2022-02-19 4:11 ` [PATCH v7 04/11] ethdev: bring in async indirect actions operations Alexander Kozyrev
2022-02-19 4:11 ` [PATCH v7 05/11] app/testpmd: add flow engine configuration Alexander Kozyrev
2022-02-19 4:11 ` [PATCH v7 06/11] app/testpmd: add flow template management Alexander Kozyrev
2022-02-19 4:11 ` [PATCH v7 07/11] app/testpmd: add flow table management Alexander Kozyrev
2022-02-19 4:11 ` [PATCH v7 08/11] app/testpmd: add async flow create/destroy operations Alexander Kozyrev
2022-02-19 4:11 ` [PATCH v7 09/11] app/testpmd: add flow queue push operation Alexander Kozyrev
2022-02-19 4:11 ` [PATCH v7 10/11] app/testpmd: add flow queue pull operation Alexander Kozyrev
2022-02-19 4:11 ` [PATCH v7 11/11] app/testpmd: add async indirect actions operations Alexander Kozyrev
2022-02-20 3:43 ` [PATCH v8 00/10] ethdev: datapath-focused flow rules management Alexander Kozyrev
2022-02-20 3:43 ` [PATCH v8 01/11] ethdev: introduce flow engine configuration Alexander Kozyrev
2022-02-21 9:47 ` Andrew Rybchenko
2022-02-21 9:52 ` Andrew Rybchenko
2022-02-21 12:53 ` Ori Kam
2022-02-21 14:33 ` Alexander Kozyrev
2022-02-21 14:53 ` Andrew Rybchenko
2022-02-21 15:49 ` Thomas Monjalon
2022-02-20 3:44 ` [PATCH v8 02/11] ethdev: add flow item/action templates Alexander Kozyrev
2022-02-21 10:57 ` Andrew Rybchenko
2022-02-21 13:12 ` Ori Kam
2022-02-21 15:05 ` Andrew Rybchenko
2022-02-21 15:43 ` Ori Kam
2022-02-21 15:14 ` Alexander Kozyrev
2022-02-20 3:44 ` [PATCH v8 03/11] ethdev: bring in async queue-based flow rules operations Alexander Kozyrev
2022-02-21 14:49 ` Andrew Rybchenko
2022-02-21 15:35 ` Alexander Kozyrev
2022-02-20 3:44 ` [PATCH v8 04/11] ethdev: bring in async indirect actions operations Alexander Kozyrev
2022-02-20 3:44 ` [PATCH v8 05/11] app/testpmd: add flow engine configuration Alexander Kozyrev
2022-02-20 3:44 ` [PATCH v8 06/11] app/testpmd: add flow template management Alexander Kozyrev
2022-02-20 3:44 ` [PATCH v8 07/11] app/testpmd: add flow table management Alexander Kozyrev
2022-02-20 3:44 ` [PATCH v8 08/11] app/testpmd: add async flow create/destroy operations Alexander Kozyrev
2022-02-20 3:44 ` [PATCH v8 09/11] app/testpmd: add flow queue push operation Alexander Kozyrev
2022-02-20 3:44 ` [PATCH v8 10/11] app/testpmd: add flow queue pull operation Alexander Kozyrev
2022-02-20 3:44 ` [PATCH v8 11/11] app/testpmd: add async indirect actions operations Alexander Kozyrev
2022-02-21 23:02 ` [PATCH v9 00/11] ethdev: datapath-focused flow rules management Alexander Kozyrev
2022-02-21 23:02 ` [PATCH v9 01/11] ethdev: introduce flow engine configuration Alexander Kozyrev
2022-02-21 23:02 ` [PATCH v9 02/11] ethdev: add flow item/action templates Alexander Kozyrev
2022-02-21 23:02 ` [PATCH v9 03/11] ethdev: bring in async queue-based flow rules operations Alexander Kozyrev
2022-02-21 23:02 ` [PATCH v9 04/11] ethdev: bring in async indirect actions operations Alexander Kozyrev
2022-02-21 23:02 ` [PATCH v9 05/11] app/testpmd: add flow engine configuration Alexander Kozyrev
2022-02-21 23:02 ` [PATCH v9 06/11] app/testpmd: add flow template management Alexander Kozyrev
2022-02-21 23:02 ` [PATCH v9 07/11] app/testpmd: add flow table management Alexander Kozyrev
2022-02-21 23:02 ` [PATCH v9 08/11] app/testpmd: add async flow create/destroy operations Alexander Kozyrev
2022-02-21 23:02 ` [PATCH v9 09/11] app/testpmd: add flow queue push operation Alexander Kozyrev
2022-02-21 23:02 ` [PATCH v9 10/11] app/testpmd: add flow queue pull operation Alexander Kozyrev
2022-02-21 23:02 ` [PATCH v9 11/11] app/testpmd: add async indirect actions operations Alexander Kozyrev
2022-02-23 3:02 ` [PATCH v10 00/11] ethdev: datapath-focused flow rules management Alexander Kozyrev
2022-02-23 3:02 ` [PATCH v10 01/11] ethdev: introduce flow engine configuration Alexander Kozyrev
2022-02-24 8:22 ` Andrew Rybchenko
2022-02-23 3:02 ` [PATCH v10 02/11] ethdev: add flow item/action templates Alexander Kozyrev
2022-02-24 8:34 ` Andrew Rybchenko
2022-02-23 3:02 ` [PATCH v10 03/11] ethdev: bring in async queue-based flow rules operations Alexander Kozyrev
2022-02-24 8:35 ` Andrew Rybchenko
2022-02-23 3:02 ` [PATCH v10 04/11] ethdev: bring in async indirect actions operations Alexander Kozyrev
2022-02-24 8:37 ` Andrew Rybchenko
2022-02-23 3:02 ` [PATCH v10 05/11] app/testpmd: add flow engine configuration Alexander Kozyrev
2022-02-23 3:02 ` [PATCH v10 06/11] app/testpmd: add flow template management Alexander Kozyrev
2022-02-23 3:02 ` [PATCH v10 07/11] app/testpmd: add flow table management Alexander Kozyrev
2022-02-23 3:02 ` [PATCH v10 08/11] app/testpmd: add async flow create/destroy operations Alexander Kozyrev
2022-02-23 3:02 ` [PATCH v10 09/11] app/testpmd: add flow queue push operation Alexander Kozyrev
2022-02-23 3:02 ` [PATCH v10 10/11] app/testpmd: add flow queue pull operation Alexander Kozyrev
2022-02-23 3:02 ` [PATCH v10 11/11] app/testpmd: add async indirect actions operations Alexander Kozyrev
2022-02-24 13:07 ` [PATCH v10 00/11] ethdev: datapath-focused flow rules management Ferruh Yigit
2022-02-24 13:13 ` Ferruh Yigit
2022-02-24 13:14 ` Raslan Darawsheh
2022-02-22 16:41 ` [PATCH v8 00/10] " Ferruh Yigit
2022-02-22 16:49 ` Ferruh Yigit
2021-10-06 4:48 [dpdk-dev] [RFC 0/3] " Alexander Kozyrev
2021-10-06 4:48 ` [dpdk-dev] [PATCH 1/3] ethdev: introduce flow pre-configuration hints Alexander Kozyrev
2021-10-13 4:11 ` Ajit Khaparde
2021-10-13 13:15 ` Ori Kam
2021-10-31 17:27 ` Ajit Khaparde
2021-11-01 10:40 ` Ori Kam
2021-10-06 4:48 ` [dpdk-dev] [PATCH 2/3] ethdev: add flow item/action templates Alexander Kozyrev
2021-10-06 17:24 ` Ivan Malov
2021-10-13 1:25 ` Alexander Kozyrev
2021-10-13 2:26 ` Ajit Khaparde
2021-10-13 2:38 ` Alexander Kozyrev
2021-10-13 11:25 ` Ivan Malov
2021-10-06 4:48 ` [dpdk-dev] [PATCH 3/3] ethdev: add async queue-based flow rules operations Alexander Kozyrev
2021-10-06 16:24 ` Ivan Malov
2021-10-13 1:10 ` Alexander Kozyrev
2021-10-13 4:57 ` Ajit Khaparde
2021-10-13 13:17 ` Ori Kam
2022-01-18 15:30 ` [PATCH v2 00/10] ethdev: datapath-focused flow rules management Alexander Kozyrev
2022-01-18 15:30 ` [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints Alexander Kozyrev
2022-01-24 14:36 ` Jerin Jacob
2022-01-24 17:35 ` Thomas Monjalon
2022-01-24 17:46 ` Jerin Jacob
2022-01-24 18:08 ` Bruce Richardson
2022-01-25 1:14 ` Alexander Kozyrev
2022-01-25 15:58 ` Ori Kam
2022-01-25 18:09 ` Bruce Richardson
2022-01-25 18:14 ` Bruce Richardson
2022-01-26 9:45 ` Ori Kam
2022-01-26 10:52 ` Bruce Richardson
2022-01-26 11:21 ` Thomas Monjalon
2022-01-26 12:19 ` Ori Kam
2022-01-26 13:41 ` Bruce Richardson
2022-01-26 15:12 ` Ori Kam
2022-01-24 17:40 ` Ajit Khaparde
2022-01-25 1:28 ` Alexander Kozyrev
2022-01-25 18:44 ` Jerin Jacob
2022-01-26 22:02 ` Alexander Kozyrev
2022-01-27 9:34 ` Jerin Jacob
2022-01-18 15:30 ` [PATCH v2 02/10] ethdev: add flow item/action templates Alexander Kozyrev
2022-01-18 15:30 ` [PATCH v2 03/10] ethdev: bring in async queue-based flow rules operations Alexander Kozyrev
2022-01-18 15:30 ` [PATCH v2 04/10] app/testpmd: implement rte flow configure Alexander Kozyrev
2022-01-18 15:33 ` [v2,05/10] app/testpmd: implement rte flow item/action template Alexander Kozyrev
2022-01-18 15:34 ` [v2,06/10] app/testpmd: implement rte flow table Alexander Kozyrev
2022-01-18 15:35 ` [v2,07/10] app/testpmd: implement rte flow queue create flow Alexander Kozyrev
2022-01-18 15:35 ` [v2,08/10] app/testpmd: implement rte flow queue drain Alexander Kozyrev
2022-01-18 15:36 ` [v2,09/10] app/testpmd: implement rte flow queue dequeue Alexander Kozyrev
2022-01-18 15:37 ` [v2,10/10] app/testpmd: implement rte flow queue indirect action Alexander Kozyrev
2022-01-19 7:16 ` [PATCH v2 00/10] ethdev: datapath-focused flow rules management Suanming Mou
2022-01-24 15:10 ` Ori Kam
2022-02-06 3:25 ` [PATCH v3 " Alexander Kozyrev
2022-02-06 3:25 ` [PATCH v3 01/10] ethdev: introduce flow pre-configuration hints Alexander Kozyrev
2022-02-07 13:15 ` Ori Kam
2022-02-07 14:52 ` Jerin Jacob
2022-02-07 17:59 ` Alexander Kozyrev
2022-02-07 18:24 ` Jerin Jacob
2022-02-06 3:25 ` [PATCH v3 02/10] ethdev: add flow item/action templates Alexander Kozyrev
2022-02-07 13:16 ` Ori Kam
2022-02-06 3:25 ` [PATCH v3 03/10] ethdev: bring in async queue-based flow rules operations Alexander Kozyrev
2022-02-07 13:18 ` Ori Kam
2022-02-08 10:56 ` Jerin Jacob
2022-02-08 14:11 ` Alexander Kozyrev
2022-02-08 15:23 ` Ivan Malov
2022-02-09 5:40 ` Alexander Kozyrev
2022-02-08 17:36 ` Jerin Jacob
2022-02-09 5:50 ` Jerin Jacob
2022-02-06 3:25 ` [PATCH v3 04/10] app/testpmd: implement rte flow configuration Alexander Kozyrev
2022-02-07 13:19 ` Ori Kam
2022-02-06 3:25 ` [PATCH v3 05/10] app/testpmd: implement rte flow template management Alexander Kozyrev
2022-02-07 13:20 ` Ori Kam
2022-02-06 3:25 ` [PATCH v3 06/10] app/testpmd: implement rte flow table management Alexander Kozyrev
2022-02-07 13:22 ` Ori Kam
2022-02-06 3:25 ` [PATCH v3 07/10] app/testpmd: implement rte flow queue flow operations Alexander Kozyrev
2022-02-07 13:21 ` Ori Kam
2022-02-06 3:25 ` [PATCH v3 08/10] app/testpmd: implement rte flow push operations Alexander Kozyrev
2022-02-07 13:22 ` Ori Kam
2022-02-06 3:25 ` [PATCH v3 09/10] app/testpmd: implement rte flow pull operations Alexander Kozyrev
2022-02-07 13:23 ` Ori Kam
2022-02-06 3:25 ` [PATCH v3 10/10] app/testpmd: implement rte flow queue indirect actions Alexander Kozyrev
2022-02-07 13:23 ` Ori Kam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6856670.dE46n4Xy2H@thomas \
--to=thomas@monjalon.net \
--cc=ajit.khaparde@broadcom.com \
--cc=akozyrev@nvidia.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=ivan.malov@oktetlabs.ru \
--cc=jerinj@marvell.com \
--cc=mohammad.abdul.awal@intel.com \
--cc=orika@nvidia.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).