DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Subject: Re: [PATCH 5/6] devtools: make uAPI check exclusive to other options
Date: Wed, 3 Sep 2025 15:52:18 +0200	[thread overview]
Message-ID: <68594e6e-c261-4d86-b57f-5fd9eeaa8c18@redhat.com> (raw)
In-Reply-To: <20250827082413.1417226-6-thomas@monjalon.net>



On 8/27/25 10:21 AM, Thomas Monjalon wrote:
> When doing a check of Linux uAPI headers,
> it is better to not fix them before.
> Also, it does not make sense to check just after doing an update,
> as the check would just repeat the same update process.
> That's why a check is now run alone without any update.
> 
> The current version has to be retrieved in all cases,
> so it is moved at the beginning of any processing.
> 
> If the check option (-c) is used with an import (-i) or an upgrade (-u),
> an error is raised.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>   devtools/linux-uapi.sh | 22 ++++++++++++----------
>   1 file changed, 12 insertions(+), 10 deletions(-)
> 

As discussed off-list, I agree it did not made sense to make possible
both check and import/update at the same time.

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


  reply	other threads:[~2025-09-03 13:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-27  8:21 [PATCH 0/6] devtools: improve Linux uAPI script Thomas Monjalon
2025-08-27  8:21 ` [PATCH 1/6] devtools: remove superfluous curly braces in " Thomas Monjalon
2025-09-03 13:39   ` Maxime Coquelin
2025-08-27  8:21 ` [PATCH 2/6] devtools: remove superfluous fallbacks " Thomas Monjalon
2025-09-03 13:47   ` Maxime Coquelin
2025-08-27  8:21 ` [PATCH 3/6] devtools: move uAPI processing into functions Thomas Monjalon
2025-09-03 13:50   ` Maxime Coquelin
2025-08-27  8:21 ` [PATCH 4/6] devtools: remove unused variables in uAPI script Thomas Monjalon
2025-09-03 13:50   ` Maxime Coquelin
2025-08-27  8:21 ` [PATCH 5/6] devtools: make uAPI check exclusive to other options Thomas Monjalon
2025-09-03 13:52   ` Maxime Coquelin [this message]
2025-08-27  8:21 ` [PATCH 6/6] devtools: add quiet mode in uAPI script Thomas Monjalon
2025-09-03 13:54   ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68594e6e-c261-4d86-b57f-5fd9eeaa8c18@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).