From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D30F9A04AC; Tue, 1 Sep 2020 12:57:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AF8021515; Tue, 1 Sep 2020 12:57:47 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 56857137D for ; Tue, 1 Sep 2020 12:57:45 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id B3BAE5C012C; Tue, 1 Sep 2020 06:57:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 01 Sep 2020 06:57:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= jxyTjI46E/PmfEm4btrJNkw7xWLbQJxdCo+o+/F4pVw=; b=ODk8AmT+DTvQMDiz pkN4ptKTnhOoyV7OatV+dcyllQBbzbXavqwe2nq1Exn57XA4P8PpPq2l2aP8doO0 7PjhJhRpub+0UuxQyXcsvI6/dEMcClatdXOBWCSUDoa+yfuheSAn1zavAKyeGsph 7v2FduYvVukRsIxu3rtfYQ0fNyeRDNNF4poHwZUX/CXbr3CRhCH1uyRdyXx9qjJV eBXlXBEx5UHfn4EmJJAh5gN8q8YfQWTPiuzuUbSP6EG5xsxRsvE2wt+g0aeRNtgn CyY+SYkmbGXg2xRoXngWtLgFfKqP+CG4/Y/EdoM5hzNuyhzVrtThoPDC0xChy+1b CqJNcg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=jxyTjI46E/PmfEm4btrJNkw7xWLbQJxdCo+o+/F4p Vw=; b=HtxB5Tj4k+Ob71+IFi1NPTLIk22AtN0AJ/ktVvA5dukvhkm/aI0Q29+Vt Da6JnysEFu4ZwjYsoyjTrR3BNABWcOJ9QyzeLWEMHWzOw0ZOd7YU1dOOpT0lYI3Z WXQaXO3We63V8IMrpPnbeUQ7WzfNXX4WTB1mMGRLaGVbu5cPJy1FSW/l6iRU9r0+ PwLmVLs8zlAbw/CdbHUNXmQY1D3YKjuyyFdsNF6GY2usxsNHWRuwmkMITmeMkIc+ QmpMpaWnc2ZC0vOWMngileHsK4uKNRICe31999j3uWZYdivEfJwDNL2pg83N+LB8 kWoLBEACiW5sHwwtCS2exwpXy0xKQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudefjedgfeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrd dvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4ECA930600A3; Tue, 1 Sep 2020 06:57:43 -0400 (EDT) From: Thomas Monjalon To: wangyunjian Cc: "dev@dpdk.org" , "keith.wiles@intel.com" , "ophirmu@mellanox.com" , "Lilijun (Jerry)" , xudingke Date: Tue, 01 Sep 2020 12:57:41 +0200 Message-ID: <6863536.XA1mUAnDxV@thomas> In-Reply-To: <34EFBCA9F01B0748BEB6B629CE643AE60DA0D229@dggemm513-mbx.china.huawei.com> References: <40a0e68ed41b05fba8cbe5f34e369a59a1c0c09c.1596022448.git.wangyunjian@huawei.com> <3793874.FWKru8qnbX@thomas> <34EFBCA9F01B0748BEB6B629CE643AE60DA0D229@dggemm513-mbx.china.huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/tap: free mempool when closing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/08/2020 14:51, wangyunjian: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 06/08/2020 14:47, wangyunjian: > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > 29/07/2020 13:35, wangyunjian: > > > > > From: Yunjian Wang > > > > > > > > > > When setup tx queues, we will create a mempool for the 'gso_ctx'. > > > > > The mempool is not freed when closing tap device. If free the tap > > > > > device and create it with different name, it will create a new > > > > > mempool. This maybe cause an OOM. > > > > > > > > While at it, please look at implementing RTE_ETH_DEV_CLOSE_REMOVE > > > > behaviour in tap. Thanks > > > > > > > > > > I read the codes about tap device. Currently, the tap pmd doesn't use > > > RTE_ETH_DEV_CLOSE_REMOVE flag. > > > > I know. That's why I suggest to switch to RTE_ETH_DEV_CLOSE_REMOVE. > > Please see this deprecation notice: > > http://git.dpdk.org/dpdk/commit/?id=7efbaa7b4e423 > > OK, I have sent a patch to add this feature for tap device. > > https://patchwork.dpdk.org/patch/76137/ Thanks a lot