From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6AEFA04C9; Mon, 14 Sep 2020 10:08:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4E42F2BAB; Mon, 14 Sep 2020 10:08:43 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 1F349FFA for <dev@dpdk.org>; Mon, 14 Sep 2020 10:08:42 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id ACC045C00E2; Mon, 14 Sep 2020 04:08:40 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 14 Sep 2020 04:08:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 4LJffvQlJ/cXTmQBwVWp7uYDuYVNABRe3fuYmViyJAA=; b=GFZPt6sJ5vePdd3N 1suhTM5pi0gw9Xq0fv51xUe23OcaLTyR5YPK8HiyW4rgV1WLJcR2rQWCP25Kvvw1 JnoTLQxKkcoopPgb2c/kv230S3Z9j1wYvK078EEtqR9g3E4O6p5fc68ChnuzR1Ch 9CHFpj79qx9qvwcpRAS5ZEP22k+dZk4fnLAtYQw3SKrb68T9LZSQ57wi7lTFakTF mpc6VgqobhE0P9Bbfo3bd+KUJIfTmapPImvWkRlyWG7sbsD2DyKt+e0wRkqhNsIv +3WNyyoZIJ2L7r7N3p1UofxhqgzjNH5DmB0x6FovaSGlNfv+Irit3spdmwz7fQj7 vOpzcw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=4LJffvQlJ/cXTmQBwVWp7uYDuYVNABRe3fuYmViyJ AA=; b=OIxlfOfKGnSf0V9hBp0fALxOZuuucVE/LsP5hBehg4KWTVXPshndGYmj/ KZFaUZPyH2Uyx4QezUcEigYs7rZ+i8G/oLhDpKHh7txc2JXKEjp63KVi3AUX/i74 egWKrdzUCF0BVrgM5oGLeNl5WRmEv+KkuNzgCBL5gNneLpFXqT6sU2KR+btvwMfg LsVU/z+9VxUg40slGzTa206MA3gq1hPxXBRmFBopoGexvqPnuCZayS999DdvIBFW X4q7RGqecu4PdHJtk6VYdaVHPIL7vD3d0ZN1xZW5itqTD5jYtvB378o4TAmdzcb6 OFY87tCVRFMTb1YFxw8HlpAfCxoTQ== X-ME-Sender: <xms:ByVfXx-Gq2VA9GiHsnPIC5P1RsDr19Yq0AEp5THgFb7SrMkdmow-eA> <xme:ByVfX1sREjN4bKyjZ_1IyJXsI7l3i9IQIpZ3Ymyj3Ano8U3oruu-PkD-P5GKarL6b ubt60CR4xqEeIMnRA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudeiiecutefuodetggdotefrodftvfcurf hrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfo ohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtffrrg htthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueeiiedv ffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdr nhgvth X-ME-Proxy: <xmx:ByVfX_B9jds_hHtjmw9bORtbiPSz9pUTOaPECL4OcESk1NSvW74dkQ> <xmx:ByVfX1erhxjI_JVehY4VO-lBqEQVDhGBRcw7rNNjCjAK4a5u_ydh4A> <xmx:ByVfX2PiK_jR2AQFSSdmpU6YZ41WUYcX6VVWhE4MzU0hUpyT-ivOIw> <xmx:CCVfX93szWnd-xjtg5-7BlP8O2wiexk1x87cSfvgRqmf037gjvlmKA> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 146433064674; Mon, 14 Sep 2020 04:08:38 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Conor Walsh <conor.walsh@intel.com> Cc: dev@dpdk.org, david.marchand@redhat.com, ray.kinsella@intel.com, nhorman@tuxdriver.com, aconole@redhat.com, maicolgabriel@hotmail.com, bruce.richardson@intel.com Date: Mon, 14 Sep 2020 10:08:37 +0200 Message-ID: <6873366.jM3skLiTAc@thomas> In-Reply-To: <20200911160332.256343-1-conor.walsh@intel.com> References: <20200910142121.3995680-1-conor.walsh@intel.com> <20200911160332.256343-1-conor.walsh@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 0/4] abi breakage checks for meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Hi, > This patchset allows developers to check ABI breakages during build > time. > Currently checking that the DPDK ABI has not changed before up-streaming > code is not intuitive. The current method, requires the contributor to > use either the test-build.sh and test-meson-build.sh tools, along side The contributor *MUST* test compilation with test-meson-build.sh in any case. > some environmental variables to test their changes. Contributors in many It is just one variable to add to a file: export DPDK_ABI_REF_VERSION=v20.11 in ~/.config/dpdk/devel.config or dpdk/.develconfig > cases are either unaware or unable to do this themselves, leading to a > potentially serious situation where they are unknowingly up-streaming > code that breaks the ABI. These breakages are then caught by Travis, but > it is more efficient if this is caught locally before up-streaming. I think you are proposing a complex solution to a non-issue. And I don't understand how your method is more straight-forward for the user, given this statement in your last patch: " This patch adds the ability to run ABI breakage checks to meson. To do this the developer needs to set the meson build type to debug and set the version of DPDK that they want to check the ABI against. "