From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id F0EFD1B418
for <dev@dpdk.org>; Tue, 30 Jan 2018 14:46:50 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 7B12E20D31;
Tue, 30 Jan 2018 08:46:50 -0500 (EST)
Received: from frontend1 ([10.202.2.160])
by compute1.internal (MEProxy); Tue, 30 Jan 2018 08:46:50 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc; s=mesmtp; bh=XV5FLpZmGWC25d2UUKzpo/Gn5B
HyD5kAiZwaXpVACNo=; b=HpWCwIk4ze8Hf9eLyOcIQiFhCt70zBQ4AlBRMZYhuQ
mEo//WjMaCRYNlg752dHcT80n97mwd67vSSk2KviPe9inxNN0b+aQuoxJ7CbwC4o
tCf/Nm2mNglUbuVPjpD+ReqYyE8uCFcFc9TfTKRcmsXFKf+9ksIfGYRk6Z9y6EG8
U=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=XV5FLp
ZmGWC25d2UUKzpo/Gn5BHyD5kAiZwaXpVACNo=; b=Br+91mzQ8UNAAY3WZDUL6y
XYyZjF9SdosNYtxruBpo1LLUHiIW6+hRBmbtQixX/a7j3Gpq3y5rNUvSjYZ4YMaF
UL4ohhANxjM/4xqrNrpQmnMcWovOgjdADf0v0jAhTWsNluAMaDvilH9cgBAJt0I9
t2Xp+n6Wzi/ZCjyQVN6imLPt/Go7xjHM5JMket2l1AH/RBp+QQJbrqqlWtgL6ayl
Nv+Zzvt9os1e/WO5HDbnoZaM0FmnRX7BiLBK2hVsxZB6xsl6SZgKQk9qQfBmZTry
nCr34LplKZqkgH3414tVDJkaxbq2sBSzidtbkVXSFesq2khKiA8uYzXIP7RjaYMQ
==
X-ME-Sender: <xms:SndwWv8aLh3SL5eJFFUUzCv26hw5RXlXR2Q7yv5Z-T8NAx_I8jb5MQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 098337E3DF;
Tue, 30 Jan 2018 08:46:50 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Gowrishankar <gowrishankar.m@linux.vnet.ibm.com>
Cc: dev@dpdk.org, Chao Zhu <chaozhu@linux.vnet.ibm.com>,
Olivier Matz <olivier.matz@6wind.com>
Date: Tue, 30 Jan 2018 14:46:04 +0100
Message-ID: <6873526.vGmRUKyOO2@xps>
In-Reply-To: <d8b28f8d6f340b5b13664362b72cec62dc5ea0ec.1517308613.git.gowrishankar.m@linux.vnet.ibm.com>
References: <0d242c92a3734252f6baa5592c56afeba254941b.1517301739.git.gowrishankar.m@linux.vnet.ibm.com>
<d8b28f8d6f340b5b13664362b72cec62dc5ea0ec.1517308613.git.gowrishankar.m@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] eal/ppc: fix compilation error with a
broken else clause
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Jan 2018 13:46:51 -0000
30/01/2018 11:53, Gowrishankar:
> From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
>
> Calling rte_smp_{w/r}mb macro expands into a compound block, which
> would break compiling a else clause following it, if that calling
> place has been terminated already with ";", as in below code.
> This patch adds { } around this macro to allow compiling else too.
>
> Fixes: d23a6bd04d ("eal/ppc: fix memory barrier for IBM POWER")
> Fixes: 05c3fd7110 ("eal/ppc: atomic operations for IBM Power")
>
> Signed-off-by: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
Applied, thanks