From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 29D3025E5 for ; Fri, 15 Sep 2017 17:51:38 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9E69720B0A; Fri, 15 Sep 2017 11:51:37 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 15 Sep 2017 11:51:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=N7qqceebTjBFlKf CZDxlBCN/x3SA2OCMrUV+1enC3FQ=; b=iKud4QF0ZmBVqZtNSwjzIhDYgH1q3WY fvNUJx+3x496A38Mz4ZwaH80ZF3SVa0cfp0VmlvEhB7tsh268ZeByfhSfpQfKGWu JE5JghGlpO61gcOMH1CAgHltRSEQHnCxDOSTlXIAQtOWdVCDK3eozyBwupHqBRLD X+E9p6GFEfiM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=N7qqceebTjBFlKfCZDxlBCN/x3SA2OCMrUV+1enC3FQ=; b=FLuEho5+ w2DmClEm7b7xYfJ7j2oG5W9g/MP8CykNjf+jibz9Mm8dRPaznmepR1I9YFrSviWs r+ID3qAQm1T98flpe1ff2jd6WqTKOaKXOWBVXr3XYCSYZzCS9tN5XrzIVosvDuo5 f9gABx1TS4TRvwnd2CBvR+SiOw1trDlObswMVydCQ+OmMN92gpoMuWJSrYkRUExC ccCl3K7Muhvo7s0IAeG+W59/04dUfkUDCrYU2QsQbyK5Ha88Lvoe+PFWsn5tQHOA Ke3Gn5X71yjasABkmdLA6k73aX/vlfTcQwe7K1ZYoGkiAhbWP/YfssRW5+6Ec7+0 LXqHXU+x0j67kA== X-ME-Sender: X-Sasl-enc: 4AEiNdzouff63fnqaWGDjPNhe1+ZYYVGHKDi6mjfyaiG 1505490697 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4C8FA7FA1D; Fri, 15 Sep 2017 11:51:37 -0400 (EDT) From: Thomas Monjalon To: Pavan Nikhilesh Bhagavatula Cc: "Van Haaren, Harry" , dev@dpdk.org Date: Fri, 15 Sep 2017 17:51:36 +0200 Message-ID: <6875069.BRSTqJL15t@xps> In-Reply-To: <20170915145933.GA16776@PBHAGAVATULA-LT> References: <1503501027-11046-1-git-send-email-pbhagavatula@caviumnetworks.com> <20170915145933.GA16776@PBHAGAVATULA-LT> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: added new `rte_lcore_is_service_lcore` API. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Sep 2017 15:51:38 -0000 15/09/2017 16:59, Pavan Nikhilesh Bhagavatula: > On Fri, Sep 15, 2017 at 02:44:57PM +0000, Van Haaren, Harry wrote: > > > > > We could also choose to add this function to rte_service.h ? > > > > > > > > Yes that is an option, and OK with me. > > > > > > > > @Pavan what do you think of adding it to service.h, implement in .c and add > > > to .map? > > > > > > > > > > The ROLE_SERVICE/ROLE_RTE defines the role of a lcore so it made sense to put > > > it in rte_lcore.h as lcore properties are accessed mostly through this header. > > > I'm fine with adding it to service.h as suggested by Harry. > > > > > > -Pavan > > > > *as suggested by Thomas ;) > > > > Initially I thought it made more sense in lcore.h too, however the application > > should only require knowing if core X is a service core if it cares about > > services / service-cores, hence I'm fine with rte_service.h too. > > > > -Harry > > > Agreed, will spin up a v2. The most difficult is to find a good name for this function :)