From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E73AA3160 for ; Wed, 9 Oct 2019 19:17:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 822111C200; Wed, 9 Oct 2019 19:17:11 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 6121D1C0C0; Wed, 9 Oct 2019 19:17:09 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Oct 2019 10:17:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,277,1566889200"; d="scan'208";a="192938198" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.10]) ([10.237.221.10]) by fmsmga008.fm.intel.com with ESMTP; 09 Oct 2019 10:17:05 -0700 To: "Hyong Youb Kim (hyonkim)" Cc: "dev@dpdk.org" , "John Daley (johndale)" , Dirk-Holger Lenz , "stable@dpdk.org" References: <20190906065020.21206-1-hyonkim@cisco.com> <20190906065020.21206-2-hyonkim@cisco.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <68962f8b-1ff0-e098-0f15-bc7e857cc666@intel.com> Date: Wed, 9 Oct 2019 18:17:05 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/3] net/enic: restrict several handlers to primary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/9/2019 10:38 AM, Hyong Youb Kim (hyonkim) wrote: >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Wednesday, October 9, 2019 6:28 PM >> To: Hyong Youb Kim (hyonkim) >> Cc: dev@dpdk.org; John Daley (johndale) ; Dirk- >> Holger Lenz ; stable@dpdk.org >> Subject: Re: [dpdk-stable] [PATCH 1/3] net/enic: restrict several handlers to >> primary process >> >> On 10/9/2019 9:48 AM, Hyong Youb Kim (hyonkim) wrote: >>>> -----Original Message----- >>>> From: Ferruh Yigit >>>> Sent: Wednesday, October 9, 2019 5:02 PM >>>> To: Hyong Youb Kim (hyonkim) >>>> Cc: dev@dpdk.org; John Daley (johndale) ; Dirk- >>>> Holger Lenz ; stable@dpdk.org >>>> Subject: Re: [PATCH 1/3] net/enic: restrict several handlers to primary >>>> process >>>> >>>> On 9/6/2019 7:50 AM, Hyong Youb Kim wrote: >>>>> These eth_dev_ops handlers should run only in the primary process. >>>>> - filter_ctrl >>>>> - reta_update >>>>> - rss_hash_update >>>>> - set_mc_addr_list >>>>> - udp_tunnel_port_add >>>>> - udp_tunnel_port_del >>>>> >>>>> Fixes: c2fec27b5cb0 ("net/enic: allow to change RSS settings") >>>>> Fixes: 8d496995346c ("net/enic: support multicast filtering") >>>>> Fixes: 8a4efd17410c ("net/enic: add handlers to add/delete vxlan port >>>> number") >>>>> Cc: stable@dpdk.org >>>>> >>>>> Reported-by: Dirk-Holger Lenz >>>>> Signed-off-by: Hyong Youb Kim >>>>> Tested-by: Dirk-Holger Lenz >>>>> Reviewed-by: John Daley >>>>> --- >>>>> drivers/net/enic/enic_ethdev.c | 12 ++++++++++++ >>>>> 1 file changed, 12 insertions(+) >>>>> >>>>> diff --git a/drivers/net/enic/enic_ethdev.c >>>> b/drivers/net/enic/enic_ethdev.c >>>>> index 06dc67122..85d785e62 100644 >>>>> --- a/drivers/net/enic/enic_ethdev.c >>>>> +++ b/drivers/net/enic/enic_ethdev.c >>>>> @@ -129,6 +129,8 @@ enicpmd_dev_filter_ctrl(struct rte_eth_dev >> *dev, >>>>> { >>>>> int ret = 0; >>>>> >>>>> + if (rte_eal_process_type() != RTE_PROC_PRIMARY) >>>>> + return -E_RTE_SECONDARY; >>>>> ENICPMD_FUNC_TRACE(); >>>>> >>>>> switch (filter_type) { >>>> >>>> I remember we have similar talk with John in the past about these >> secondary >>>> application checks in ethdev_ops. >>>> >>>> I would like to understand why these checks required only in enic, can you >>>> please describe your use case? >>>> Is there any reason secondary application can't change configuration of >> the >>>> device, or are you updating your driver to work with specific application? >>> >>> Hi, >>> >>> No fundamental reasons why secondary processes cannot run these >>> handlers. These checks are to make it clear that it is not safe to do >>> so at the moment. It is a software limitation. >>> >>> The firmware API (devcmd) we use to configure NIC settings assumes one >>> user executing one command at a time. And, many of the handlers in the >>> driver also assume primary process. The firmware itself has >>> enough checks to prevent concurrent devcmd attempts from corrupting >>> its internal state. But, host processes can get confused. For example, >>> process A gets process B's results, or overwrites B's devcmd, etc. >>> >>> I believe these issues are all fixable in the driver. We could use >>> locks in shared memory to serialize devcmd (though risky), fix >>> handlers that assume primary process, and so on. It is a to-do item for >>> this driver and would require its own patch series (e.g. allow >>> secondary processes to run X, Y, Z safely).. >> >> What you have described is valid concern for all drivers, that synchronization >> has been pushed to the application level. >> >> I don't see the point of just putting protection to only one driver. >> >> And as a alternative, what do you think about having a check in the prob for >> the >> secondary process and assign a subset of the ethdev_ops in that case? This >> makes >> more clear what is supported in the secondary process, and it prevents >> putting >> secondary process checks everywhere. > > Hi, > > Okay, that sounds reasonable. Could you drop this one patch and apply > the rest in the series? I may not have time to properly re-do this one > in this cycle.. OK, will mark 1/3 as "Change Requested" and continue with others. Thanks.