DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Serhii Iliushyk <sil-plv@napatech.com>
Cc: dev@dpdk.org, mko-plv@napatech.com, sil-plv@napatech.com,
	ckm@napatech.com, stephen@networkplumber.org
Subject: Re: [PATCH v2] doc: refactoring the guide for NTNIC PMD
Date: Thu, 23 Oct 2025 16:49:49 +0200	[thread overview]
Message-ID: <6896421.YiXZdWvhHV@thomas> (raw)
In-Reply-To: <20251023143506.587329-1-sil-plv@napatech.com>

23/10/2025 16:35, Serhii Iliushyk:
> +=========================================================================================== =======
> +Supported Features                                                                           Linux
> +=========================================================================================== =======
> +FW version                                                                                     X
> +Speed capabilities                                                                             X
> +Link status (Link update only)                                                                 X
> +Unicast MAC filter                                                                             X
> +Multicast MAC filter                                                                           X
> +Promiscuous mode (Enable only. The device always run promiscuous mode)                         X
> +Flow API support.                                                                              X
> +Support for multiple rte_flow groups.                                                          X
> +Multiple TX and RX queues.                                                                     X
> +Scattered and gather for TX and RX.                                                            X
> +Jumbo frame support.                                                                           X
> +Traffic mirroring.                                                                             X
> +VLAN filtering.                                                                                X
> +Packet modification: NAT, TTL decrement, DSCP tagging                                          X
> +Tunnel types: GTP.                                                                             X
> +Encapsulation and decapsulation of GTP data.                                                   X
> +RX VLAN stripping via raw decap.                                                               X
> +TX VLAN insertion via raw encap.                                                               X
> +CAM and TCAM based matching.                                                                   X
> +Exact match of 140 million flows and policies.                                                 X
> +Tunnel HW offload: Packet type, inner/outer RSS, IP and UDP checksum verification.             X
> +RSS hash                                                                                       X
> +RSS key update                                                                                 X
> +RSS based on VLAN or 5*tuple.                                                                  X
> +RSS using combinations of fields: L3 only, L4 only or both, and src only, dst only or both.    X

When you make a table, you should not write sentences.
Columns must not be wide.


[...]
> +<object>.<attribute>=[<object-ids>:]<value>

Should it have a fixed witdth font?


[...]
> -``exception_path`` parameter [int]
> +- ``exception_path`` parameter [int]

Why do you replace the definition list with a simple list?
Did you check the HTML output?


[...]
>  Logging and Debugging
> ----------------------
> +~~~~~~~~~~~~~~~~~~~~~

Why? So there is only 1 main title like "Features"?


[...]
> -.. note::
> +   .. note::

No reason to do that.



  reply	other threads:[~2025-10-23 14:49 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-08 11:04 [PATCH v1 0/7] migrate threads to DPDK service framework Serhii Iliushyk
2025-09-08 11:04 ` [PATCH v1 1/7] net/ntnic: introduce service API for NTNIC PMD Serhii Iliushyk
2025-09-24 20:27   ` Stephen Hemminger
2025-09-08 11:04 ` [PATCH v1 2/7] net/ntnic: migrate flm update thread to service Serhii Iliushyk
2025-09-08 11:04 ` [PATCH v1 3/7] net/ntnic: migrate statistic " Serhii Iliushyk
2025-09-08 11:04 ` [PATCH v1 4/7] net/ntnic: migrate port event " Serhii Iliushyk
2025-09-08 11:04 ` [PATCH v1 5/7] net/ntnic: migrate adapter mon " Serhii Iliushyk
2025-09-08 11:04 ` [PATCH v1 6/7] net/ntnic: add warning about service cores Serhii Iliushyk
2025-09-08 11:04 ` [PATCH v1 7/7] net/ntnic: cleanup using pthreads and rte_thread Serhii Iliushyk
2025-09-08 14:17   ` [PATCH v2 0/7] migrate threads to DPDK service framework Serhii Iliushyk
2025-09-08 14:17     ` [PATCH v2 1/7] net/ntnic: introduce service API for NTNIC PMD Serhii Iliushyk
2025-09-13 16:23       ` Stephen Hemminger
2025-09-15 10:10         ` Serhii Iliushyk
2025-09-15 15:46       ` Stephen Hemminger
2025-09-24 14:41       ` [PATCH v1 00/24] Migrate threads to the DPDK service framework and refactor naming for exported symbols Serhii Iliushyk
2025-09-24 14:41         ` [PATCH v1 01/24] net/ntnic: introduce service API for NTNIC PMD Serhii Iliushyk
2025-09-24 14:41         ` [PATCH v1 02/24] net/ntnic: migrate flm update thread to service Serhii Iliushyk
2025-09-24 14:41         ` [PATCH v1 03/24] net/ntnic: migrate statistic " Serhii Iliushyk
2025-09-24 14:41         ` [PATCH v1 04/24] net/ntnic: migrate port event " Serhii Iliushyk
2025-09-24 14:41         ` [PATCH v1 05/24] net/ntnic: migrate adapter mon " Serhii Iliushyk
2025-09-24 14:41         ` [PATCH v1 06/24] net/ntnic: add warning about service cores Serhii Iliushyk
2025-09-24 14:41         ` [PATCH v1 07/24] net/ntnic: avoid using thread API Serhii Iliushyk
2025-09-24 14:41         ` [PATCH v1 08/24] net/ntnic: fix potential format overflow Serhii Iliushyk
2025-09-24 14:41         ` [PATCH v1 09/24] net/ntnic: single file function as static Serhii Iliushyk
2025-09-24 14:41         ` [PATCH v1 10/24] net/ntnic: remove unused functions Serhii Iliushyk
2025-09-24 14:41         ` [PATCH v1 11/24] net/ntnic: move nthw to prefix part Serhii Iliushyk
2025-09-24 14:41         ` [PATCH v1 12/24] net/ntnic: change prefix hw to prefix nthw Serhii Iliushyk
2025-09-24 14:41         ` [PATCH v1 13/24] net/ntnic: modify prefix flow with " Serhii Iliushyk
2025-09-24 14:41         ` [PATCH v1 14/24] net/ntnic: change prefix flm to " Serhii Iliushyk
2025-09-24 14:41         ` [PATCH v1 15/24] net/ntnic: change prefix nt " Serhii Iliushyk
2025-09-24 14:41         ` [PATCH v1 16/24] net/ntnic: change prefix ntlog " Serhii Iliushyk
2025-09-24 14:41         ` [PATCH v1 17/24] net/ntnic: change prefix km " Serhii Iliushyk
2025-09-24 14:41         ` [PATCH v1 18/24] net/ntnic: change prefix set " Serhii Iliushyk
2025-09-24 14:41         ` [PATCH v1 19/24] net/ntnic: rename common hash and flow functions Serhii Iliushyk
2025-09-24 14:41         ` [PATCH v1 20/24] net/ntnic: rename register ops function Serhii Iliushyk
2025-09-24 14:41         ` [PATCH v1 21/24] net/ntnic: rename get ops functions Serhii Iliushyk
2025-09-24 14:41         ` [PATCH v1 22/24] net/ntnic: rename ops init functions Serhii Iliushyk
2025-09-24 14:41         ` [PATCH v1 23/24] net/ntnic: rename nim agx setup function Serhii Iliushyk
2025-09-24 14:41         ` [PATCH v1 24/24] net/ntnic: rename table ID functions Serhii Iliushyk
2025-10-20 16:35       ` [PATCH v1 00/24] Migrate threads to the DPDK service framework and refactor naming for exported symbols Serhii Iliushyk
2025-10-20 16:35         ` [PATCH v1 01/24] net/ntnic: introduce service API for NTNIC PMD Serhii Iliushyk
2025-10-21 15:12           ` Thomas Monjalon
2025-10-22 16:40             ` [PATCH v1 0/1] cleanup the guide " Serhii Iliushyk
2025-10-22 16:40               ` [PATCH v1 1/1] doc: refactoring " Serhii Iliushyk
2025-10-22 17:35                 ` Thomas Monjalon
2025-10-23 14:35                   ` [PATCH v2] " Serhii Iliushyk
2025-10-23 14:49                     ` Thomas Monjalon [this message]
2025-10-24 13:30                       ` Serhii Iliushyk
2025-10-24 13:46                         ` Thomas Monjalon
2025-10-23 16:09                 ` [PATCH v1 1/1] " Stephen Hemminger
2025-10-20 16:35         ` [PATCH v1 02/24] net/ntnic: migrate flm update thread to service Serhii Iliushyk
2025-10-20 16:35         ` [PATCH v1 03/24] net/ntnic: migrate statistic " Serhii Iliushyk
2025-10-20 16:35         ` [PATCH v1 04/24] net/ntnic: migrate port event " Serhii Iliushyk
2025-10-20 16:35         ` [PATCH v1 05/24] net/ntnic: migrate adapter mon " Serhii Iliushyk
2025-10-21 15:20           ` Thomas Monjalon
2025-10-20 16:35         ` [PATCH v1 06/24] net/ntnic: add warning about service cores Serhii Iliushyk
2025-10-20 16:35         ` [PATCH v1 07/24] net/ntnic: avoid using thread API Serhii Iliushyk
2025-10-20 16:35         ` [PATCH v1 08/24] net/ntnic: fix potential format overflow Serhii Iliushyk
2025-10-20 16:36         ` [PATCH v1 09/24] net/ntnic: single file function as static Serhii Iliushyk
2025-10-20 16:36         ` [PATCH v1 10/24] net/ntnic: remove unused functions Serhii Iliushyk
2025-10-20 16:36         ` [PATCH v1 11/24] net/ntnic: move nthw to prefix part Serhii Iliushyk
2025-10-20 16:36         ` [PATCH v1 12/24] net/ntnic: change prefix hw to prefix nthw Serhii Iliushyk
2025-10-20 16:36         ` [PATCH v1 13/24] net/ntnic: modify prefix flow with " Serhii Iliushyk
2025-10-20 16:36         ` [PATCH v1 14/24] net/ntnic: change prefix flm to " Serhii Iliushyk
2025-10-20 16:36         ` [PATCH v1 15/24] net/ntnic: change prefix nt " Serhii Iliushyk
2025-10-20 16:36         ` [PATCH v1 16/24] net/ntnic: change prefix ntlog " Serhii Iliushyk
2025-10-20 16:36         ` [PATCH v1 17/24] net/ntnic: change prefix km " Serhii Iliushyk
2025-10-20 16:36         ` [PATCH v1 18/24] net/ntnic: change prefix set " Serhii Iliushyk
2025-10-20 16:36         ` [PATCH v1 19/24] net/ntnic: rename common hash and flow functions Serhii Iliushyk
2025-10-20 16:36         ` [PATCH v1 20/24] net/ntnic: rename register ops function Serhii Iliushyk
2025-10-20 16:36         ` [PATCH v1 21/24] net/ntnic: rename get ops functions Serhii Iliushyk
2025-10-20 16:36         ` [PATCH v1 22/24] net/ntnic: rename ops init functions Serhii Iliushyk
2025-10-20 16:36         ` [PATCH v1 23/24] net/ntnic: rename nim agx setup function Serhii Iliushyk
2025-10-20 16:36         ` [PATCH v1 24/24] net/ntnic: rename table ID functions Serhii Iliushyk
2025-10-20 21:17         ` [PATCH v1 00/24] Migrate threads to the DPDK service framework and refactor naming for exported symbols Stephen Hemminger
2025-10-20 21:38         ` Stephen Hemminger
2025-09-08 14:17     ` [PATCH v2 2/7] net/ntnic: migrate flm update thread to service Serhii Iliushyk
2025-09-08 14:17     ` [PATCH v2 3/7] net/ntnic: migrate statistic " Serhii Iliushyk
2025-09-08 14:17     ` [PATCH v2 4/7] net/ntnic: migrate port event " Serhii Iliushyk
2025-09-08 14:17     ` [PATCH v2 5/7] net/ntnic: migrate adapter mon " Serhii Iliushyk
2025-09-08 14:17     ` [PATCH v2 6/7] net/ntnic: add warning about service cores Serhii Iliushyk
2025-09-08 14:17     ` [PATCH v2 7/7] net/ntnic: cleanup using pthreads and rte_thread Serhii Iliushyk
2025-09-23 14:47     ` [PATCH v2 0/7] migrate threads to DPDK service framework Stephen Hemminger
2025-09-08 20:08 ` [PATCH v1 " Stephen Hemminger
2025-09-10 12:13   ` Serhii Iliushyk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6896421.YiXZdWvhHV@thomas \
    --to=thomas@monjalon.net \
    --cc=ckm@napatech.com \
    --cc=dev@dpdk.org \
    --cc=mko-plv@napatech.com \
    --cc=sil-plv@napatech.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).