From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20070.outbound.protection.outlook.com [40.107.2.70]) by dpdk.org (Postfix) with ESMTP id C20651B53A for ; Thu, 11 Oct 2018 19:05:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JLeFzVWfliUKV2Vwk/wT5ydBLL+cR3ZdMSpM3+uxFrc=; b=iAL2wib4/MO8k/7ES96rChfMWaf8YhN6brN9li8RLr6XnLlk7zaGVMQytP8HTAzxdUwNFOpZ2ydjO9HSjuo15zyvOa1lDw6apJSguJY2fXBuI0NBh+sbbNiZBnbJPw5PcthysMwVEWrgfuDdnBLqnDR4QPYh7QIbgLHt+/TA4ds= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4059.eurprd05.prod.outlook.com (52.134.66.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.23; Thu, 11 Oct 2018 17:05:09 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::1cb0:661b:ecab:6045]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::1cb0:661b:ecab:6045%2]) with mapi id 15.20.1207.029; Thu, 11 Oct 2018 17:05:09 +0000 From: Yongseok Koh To: Dekel Peled CC: Shahaf Shuler , "dev@dpdk.org" , Ori Kam Thread-Topic: [PATCH v5 1/4] net/mlx5: add flow action functions to glue Thread-Index: AQHUYVvCNCVI8OaxvEyz24o8QLD6M6UaRmgA Date: Thu, 11 Oct 2018 17:05:09 +0000 Message-ID: <68B2734D-87B8-43D8-A8B3-BBBAAEEE3739@mellanox.com> References: <1539160531-27953-1-git-send-email-dekelp@mellanox.com> <1539259967-10975-2-git-send-email-dekelp@mellanox.com> In-Reply-To: <1539259967-10975-2-git-send-email-dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB4059; 6:ytch9wuQmdxqnxSkkCFBbQAnl1Vw1/D/8tIbHk7arSgtp/uP61m/2qI2ACXGqAhV+pl36sRvbdFIGbnvuoTv6Ouk5WtllC77htpFzOnQ8R/wx4e7fLRR5A96CIY/8q5MmUdTH3wNG2uPVxEslN+N7lZNLPUxj/E/qRNuyPpU1XwukpijJsIanF95WcCd85puRYLEctzp0K6BGV7nr4hGt2nKQVBS5pz9BF/ybSfp2hQ8wfD81DR4tQFM4ZmfgMBBo75N7n993vjlKn2nm2hQ7/fPuidDPjFKVwNkLyRSoIjHRf2/md4yxSZSx14tKazZSUBww53zXSzzrtM+vaJTAgs0RoVVvTpraKf83VsqpKWkzMJf07DF32sxxhsG0bjb/3rUpC528CmOdb84VO8M6nJzkXS1/IEQ+XvUr9SNnRZNcAqVfud1wdqUNPZSvBljPekL6lqYH0n1SEHZU2NW4g==; 5:hiGvKltxm4tAaZMA3/HBRekekl9RILliaV+vSwE76+T1vHBiRT7qdsPKRPzd8Mt0F2IL4U1MPtxtUIPcLXAgSLgCwYhNw/PMKMvOMji5W6/QtFqfuBxc/Gga0XfGT6YjJP8Dfr4PE5a6uTRISTBST0iyfxDl7YKt3JasPzRikWg=; 7:06WtKiZhY4pFd/Qdijj0k9+N+c6DPYYUa8fWfdceRB919kDu+2u5BwQcV29i6cvdOj4gpwN4kZqXkfgupmkzRh7iQL/Sk2g772I53EHWi3ZOdj/j1sUMTR/5jo6MsszDXQ+yRp6RaQHAdGpxKVjCqEhk9XOVFjKFVwhLTOkRU/7xHP6gmTPI79A3uzSJK/nkQR2XAn99GB21yGvzAKRE57qz8IbxmkTIt6rWMTybPBYR+71dbN6AYGsxGxh2P0yL x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 396245f3-8668-46ab-3bf4-08d62f9bb34f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB4059; x-ms-traffictypediagnostic: DB3PR0502MB4059: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(3231355)(944501410)(52105095)(93006095)(93001095)(10201501046)(6055026)(149066)(150057)(6041310)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051); SRVR:DB3PR0502MB4059; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB4059; x-forefront-prvs: 08220FA8D6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(366004)(346002)(136003)(376002)(189003)(199004)(71200400001)(83716004)(68736007)(99286004)(3846002)(6116002)(37006003)(54906003)(256004)(86362001)(6636002)(186003)(26005)(446003)(2616005)(11346002)(476003)(486006)(7736002)(71190400001)(4326008)(66066001)(102836004)(53546011)(25786009)(36756003)(76176011)(5660300001)(6246003)(107886003)(2906002)(305945005)(105586002)(82746002)(106356001)(5250100002)(53936002)(316002)(97736004)(6506007)(6862004)(2900100001)(14454004)(6486002)(8936002)(229853002)(8676002)(33656002)(81166006)(81156014)(478600001)(6436002)(6512007); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4059; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 9R3LqQgK6DPh0pSCoYVsBm7EtSlSkj8oKMS3/FMv0jIE6UocMnOmlAIIsRPV1kJwnxsB77tlFmCweWEZ1cM9Gigfo4D7MSSOCH2FRf2JfwN9dvVnr9VPY7fdLTMdywwtxbmTD8fM2QcJe0VSPYAb2sGn2YybGabeqG1Pzpn9j5wRplcr/fY2/UV6ZMoVdZyhctoIh18TzBppGo6mHto7u8uibvKVJvhvHkFs1a0jaX4ncO2efjeti7nXgwWQqrMrFtlIE7o9gTIAYk/dNVgG0BvrV/FLEkM+gTG2mgR930fKqVPMgR2HiwDQUPlni+rtYP94I4t7NQf9frzTMWJrZFvUiPn2sNfgcQapaD7+NM4= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <44DBA66123253A4F9D7BEB0403AAE06A@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 396245f3-8668-46ab-3bf4-08d62f9bb34f X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2018 17:05:09.3303 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4059 Subject: Re: [dpdk-dev] [PATCH v5 1/4] net/mlx5: add flow action functions to glue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Oct 2018 17:05:11 -0000 > On Oct 11, 2018, at 5:12 AM, Dekel Peled wrote: >=20 > This patch adds glue functions for operations: > - Create packet reformat (encap/decap) flow action. > - Destroy flow action. >=20 > The new operations depend on HAVE_IBV_FLOW_DV_SUPPORT. >=20 > Signed-off-by: Dekel Peled > --- > drivers/net/mlx5/Makefile | 2 +- > drivers/net/mlx5/meson.build | 2 +- > drivers/net/mlx5/mlx5_glue.c | 38 ++++++++++++++++++++++++++++++++++++++ > drivers/net/mlx5/mlx5_glue.h | 10 ++++++++++ > 4 files changed, 50 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile > index 92bae9d..bbfb686 100644 > --- a/drivers/net/mlx5/Makefile > +++ b/drivers/net/mlx5/Makefile > @@ -139,7 +139,7 @@ mlx5_autoconf.h.new: $(RTE_SDK)/buildtools/auto-confi= g-h.sh > $Q sh -- '$<' '$@' \ > HAVE_IBV_FLOW_DV_SUPPORT \ > infiniband/mlx5dv.h \ > - enum MLX5DV_FLOW_ACTION_TAG \ > + func mlx5dv_create_flow_action_packet_reformat \ > $(AUTOCONF_OUTPUT) > $Q sh -- '$<' '$@' \ > HAVE_ETHTOOL_LINK_MODE_25G \ > diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build > index 6966248..c93347c 100644 > --- a/drivers/net/mlx5/meson.build > +++ b/drivers/net/mlx5/meson.build > @@ -95,7 +95,7 @@ if build > [ 'HAVE_IBV_MLX5_MOD_CQE_128B_COMP', 'infiniband/mlx5dv.h', > 'MLX5DV_CONTEXT_FLAGS_CQE_128B_COMP' ], > [ 'HAVE_IBV_FLOW_DV_SUPPORT', 'infiniband/mlx5dv.h', > - 'MLX5DV_FLOW_ACTION_TAG' ], > + 'mlx5dv_create_flow_action_packet_reformat' ], > [ 'HAVE_IBV_DEVICE_MPLS_SUPPORT', 'infiniband/verbs.h', > 'IBV_FLOW_SPEC_MPLS' ], > [ 'HAVE_IBV_WQ_FLAG_RX_END_PADDING', 'infiniband/verbs.h', > diff --git a/drivers/net/mlx5/mlx5_glue.c b/drivers/net/mlx5/mlx5_glue.c > index 48590df..565c2cf 100644 > --- a/drivers/net/mlx5/mlx5_glue.c > +++ b/drivers/net/mlx5/mlx5_glue.c > @@ -174,6 +174,17 @@ > return ibv_destroy_flow(flow_id); > } >=20 > +static int > +mlx5_glue_destroy_flow_action(struct ibv_flow_action *action) > +{ > +#ifdef HAVE_IBV_FLOW_DV_SUPPORT > + return ibv_destroy_flow_action(action); > +#else > + (void)action; > + return -ENOTSUP; Please revert it to positive value and submit v6 with my acked-by tag.=20 Thanks Yongseok=