From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <marcinx.kerlin@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 530F958DD
 for <dev@dpdk.org>; Thu, 22 Sep 2016 16:11:32 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga103.fm.intel.com with ESMTP; 22 Sep 2016 07:11:06 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,378,1470726000"; d="scan'208";a="882684801"
Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155])
 by orsmga003.jf.intel.com with ESMTP; 22 Sep 2016 07:11:05 -0700
Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by
 IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Thu, 22 Sep 2016 15:11:04 +0100
Received: from irsmsx102.ger.corp.intel.com ([169.254.2.248]) by
 irsmsx111.ger.corp.intel.com ([169.254.2.67]) with mapi id 14.03.0248.002;
 Thu, 22 Sep 2016 15:11:04 +0100
From: "Kerlin, MarcinX" <marcinx.kerlin@intel.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>, "De Lara Guarch, 
 Pablo" <pablo.de.lara.guarch@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v2 1/2] librte_ether: ensure not overwrite
 device	data in mp app
Thread-Index: AQHSE1oQXiR5RjBFQ0usDn8aCCkiL6CFjTdA
Date: Thu, 22 Sep 2016 14:11:04 +0000
Message-ID: <68D830D942438745AD09BAFA99E33E812AA347@IRSMSX102.ger.corp.intel.com>
References: <1472806710-25866-2-git-send-email-marcinx.kerlin@intel.com>
 <1474381895-16066-1-git-send-email-marcinx.kerlin@intel.com>
 <1474381895-16066-2-git-send-email-marcinx.kerlin@intel.com>
 <3AEA2BF9852C6F48A459DA490692831F010A59C3@IRSMSX109.ger.corp.intel.com>
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F010A59C3@IRSMSX109.ger.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 1/2] librte_ether: ensure not overwrite
 device	data in mp app
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Sep 2016 14:11:32 -0000

Hi Reshma,

> -----Original Message-----
> From: Pattan, Reshma
> Sent: Tuesday, September 20, 2016 6:14 PM
> To: Kerlin, MarcinX <marcinx.kerlin@intel.com>; dev@dpdk.org
> Cc: thomas.monjalon@6wind.com; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Kerlin, MarcinX
> <marcinx.kerlin@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v2 1/2] librte_ether: ensure not overwrite
> device data in mp app
>=20
> Hi Marcin,
>=20
>=20
>=20
> >  /**
> >   * @internal
> > + * Returns a shared device data slot specified by the unique identifie=
r name.
> > + *
> > + * @param	name
> > + *  The pointer to the Unique identifier name for each shared
> > +Ethernet device
> > + *  between multiple processes.
> > + * @return
> > + *   - The pointer to the device data slot, on success. NULL on error
> > + */
> > +struct rte_eth_dev_data *rte_eth_dev_data_allocated(const char
> > +*name);
>=20
> This should be static function in source file rather than public function=
.
> And name can be rte_eth_dev_get_dev_by_name() something like that?

1) Yes should be, this function is not using outside lib now, thanks
2) My proposition is rte_eth_dev_get_dev_data_by_name(), because it is rela=
ted with device data structure.. Do you have any objections Thomas?

I am waiting for still some objections and then prepare v3

Regards,
Marcin

>=20
> Thanks,
> Reshma