From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 18AA8137C for ; Mon, 26 Sep 2016 17:07:56 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP; 26 Sep 2016 08:07:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,400,1470726000"; d="scan'208";a="173300250" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by fmsmga004.fm.intel.com with ESMTP; 26 Sep 2016 08:07:50 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.198]) by IRSMSX109.ger.corp.intel.com ([169.254.13.6]) with mapi id 14.03.0248.002; Mon, 26 Sep 2016 16:07:48 +0100 From: "Kerlin, MarcinX" To: Thomas Monjalon CC: "Pattan, Reshma" , "dev@dpdk.org" , "De Lara Guarch, Pablo" Thread-Topic: [dpdk-dev] [PATCH v2 1/2] librte_ether: ensure not overwrite device data in mp app Thread-Index: AQHSE1oQXiR5RjBFQ0usDn8aCCkiL6CFjTdAgAGEYACABNSFMA== Date: Mon, 26 Sep 2016 15:07:48 +0000 Message-ID: <68D830D942438745AD09BAFA99E33E812BB008@IRSMSX102.ger.corp.intel.com> References: <1472806710-25866-2-git-send-email-marcinx.kerlin@intel.com> <3AEA2BF9852C6F48A459DA490692831F010A59C3@IRSMSX109.ger.corp.intel.com> <68D830D942438745AD09BAFA99E33E812AA347@IRSMSX102.ger.corp.intel.com> <4580114.oiHn6CQCKM@xps13> In-Reply-To: <4580114.oiHn6CQCKM@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/2] librte_ether: ensure not overwrite device data in mp app X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Sep 2016 15:07:57 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, September 23, 2016 4:13 PM > To: Kerlin, MarcinX > Cc: Pattan, Reshma ; dev@dpdk.org; De Lara > Guarch, Pablo > Subject: Re: [dpdk-dev] [PATCH v2 1/2] librte_ether: ensure not overwrite > device data in mp app >=20 > 2016-09-22 14:11, Kerlin, MarcinX: > > Hi Reshma, > > > > From: Pattan, Reshma > > > > > > Hi Marcin, > > > > > > > /** > > > > * @internal > > > > + * Returns a shared device data slot specified by the unique ident= ifier > name. > > > > + * > > > > + * @param name > > > > + * The pointer to the Unique identifier name for each shared > > > > +Ethernet device > > > > + * between multiple processes. > > > > + * @return > > > > + * - The pointer to the device data slot, on success. NULL on er= ror > > > > + */ > > > > +struct rte_eth_dev_data *rte_eth_dev_data_allocated(const char > > > > +*name); > > > > > > This should be static function in source file rather than public func= tion. > > > And name can be rte_eth_dev_get_dev_by_name() something like that? > > > > 1) Yes should be, this function is not using outside lib now, thanks > > 2) My proposition is rte_eth_dev_get_dev_data_by_name(), because it is > related with device data structure.. Do you have any objections Thomas? >=20 > No objection on the name. > But the whole patch looks strange. >=20 > > I am waiting for still some objections and then prepare v3 >=20 > Please could you better state the problem you want to solve in the messag= es of > each v3 patch? > I'll try to understand and review the v3. you're right, description without example is hard to quickly understand. I added to cover letter how to reproduce the bug, how it affects on applica= tions and=20 how it is repaired in patch. =20 I hope that it will clarify problem. Regards, Marcin >=20 > Thanks