From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <marcinx.kerlin@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id B00603B5
 for <dev@dpdk.org>; Tue, 27 Sep 2016 12:01:51 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga102.fm.intel.com with ESMTP; 27 Sep 2016 03:01:50 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,404,1470726000"; d="scan'208";a="1046419746"
Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99])
 by fmsmga001.fm.intel.com with ESMTP; 27 Sep 2016 03:01:50 -0700
Received: from irsmsx102.ger.corp.intel.com ([169.254.2.198]) by
 IRSMSX107.ger.corp.intel.com ([169.254.10.95]) with mapi id 14.03.0248.002;
 Tue, 27 Sep 2016 11:01:49 +0100
From: "Kerlin, MarcinX" <marcinx.kerlin@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "De Lara Guarch, Pablo"
 <pablo.de.lara.guarch@intel.com>, "thomas.monjalon@6wind.com"
 <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v3 1/2] librte_ether: ensure not overwrite
 device data in mp app
Thread-Index: AQHSGAaWSViW+nBe9kWhfu+0MTveV6CMl4sAgACD+DA=
Date: Tue, 27 Sep 2016 10:01:47 +0000
Message-ID: <68D830D942438745AD09BAFA99E33E812BD1F1@IRSMSX102.ger.corp.intel.com>
References: <1474901586-8706-1-git-send-email-marcinx.kerlin@intel.com>
 <1474901586-8706-2-git-send-email-marcinx.kerlin@intel.com>
 <20160927030646.GA9990@yliu-dev.sh.intel.com>
In-Reply-To: <20160927030646.GA9990@yliu-dev.sh.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v3 1/2] librte_ether: ensure not overwrite
 device data in mp app
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Sep 2016 10:01:52 -0000

Hi Liu

> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> Sent: Tuesday, September 27, 2016 5:07 AM
> To: Kerlin, MarcinX <marcinx.kerlin@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> thomas.monjalon@6wind.com
> Subject: Re: [dpdk-dev] [PATCH v3 1/2] librte_ether: ensure not overwrite
> device data in mp app
>=20
> On Mon, Sep 26, 2016 at 04:53:05PM +0200, Marcin Kerlin wrote:
> > diff --git a/lib/librte_ether/rte_ether_version.map
> > b/lib/librte_ether/rte_ether_version.map
> > index 45ddf44..34e1109 100644
> > --- a/lib/librte_ether/rte_ether_version.map
> > +++ b/lib/librte_ether/rte_ether_version.map
> > @@ -139,3 +139,10 @@ DPDK_16.07 {
> >  	rte_eth_dev_get_port_by_name;
> >  	rte_eth_xstats_get_names;
> >  } DPDK_16.04;
> > +
> > +DPDK_16.11 {
> > +	global:
> > +
> > +	rte_eth_dev_data_allocated;
> > +	rte_eth_dev_release_dev_data;
> > +} DPDK_16.07
>=20
> Interestingly, my robot caught an error (missing ';') with your v1, and y=
ou fixed
> it in v2. Now you broke it again in v3.

I did format-patch on the older branch without fix semicolon.. Thanks, your=
 robot is a great tool.

Regards,
Marcin

>=20
> 	--yliu