From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D96941D30; Tue, 21 Feb 2023 17:44:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1648D4320A; Tue, 21 Feb 2023 17:44:30 +0100 (CET) Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by mails.dpdk.org (Postfix) with ESMTP id 164A940E0F for ; Tue, 21 Feb 2023 17:44:29 +0100 (CET) Received: by mail-ed1-f44.google.com with SMTP id ee7so4597933edb.2 for ; Tue, 21 Feb 2023 08:44:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Np+HMq0SS60lg51K77WVsOIaWCxwM4jZarIzEShbNm0=; b=iV/M3JUNYv7vXtAMfTVAtzndtcUwXIMyAZB8kfRuUQLSNrZdcpCLOrQiGQjGKBppvF 0g7f+kN+8j1ZpUC26i1nhkW8+nXt0Rk8xUuycldHiH94m1WjLsXAeIQnLIC3AnlkP14h tfIPoiJAtbwpXbdbrHCYzsC16OD1siK4sQr2uXFhH8J0WPWnFUTnIF3VRbrRFfh+HQvF UQgBYskuy6qdgX/Ubo4U53A/RXcG6/Kwze7ib2JEOJzp7HyhKVeaTm68vOkxAe84Ysia MQeHypT9p3cmgMqMl4MfXIy7nqYsVYLkwbuRNx32AaCfeCC7TRFd3qLwE97ltaD6Vqdw qTWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Np+HMq0SS60lg51K77WVsOIaWCxwM4jZarIzEShbNm0=; b=BZt9LWoko61mn+kKVAD2wdTlfjI1RbsCtfJwBwzcYCGKryMFO+UKwKScLxfRIjlYxD Dl8IsYdIEZwSmKu409Bf/uFLwFeg+FeY1dUHxNoCGAbXwaKTjOd7sjG2iriqCr5LhZhN ZmHtRPxEGNp+4KP/TD1uxFDeUzxP8NbeCwxxlA/stcla2dl4H3yf8ihLenVVaGAFh7vB PivPqfXuWQSeme41LzAe9tndf/C8v00yLHPSCa3ZgomfyVMJRoYA81ys5FR5PXw6NsyA DUnqH0pK+BLy/CbIvCWeJSmmqc0sHIURWbN5wah9RlYT2mNzQt2tcWEgvCfdM3AwxYgm Kwrg== X-Gm-Message-State: AO0yUKVKH4ebdEJRllGqyGZZ+f9EXGqMy/O+xQJIdZEqRflHjncNAaoF lHIBiyTXFbIXUWtEdZ1mg7fC3x6Cwdw= X-Google-Smtp-Source: AK7set+c79q1wHP0zhxN405DAJgVhzotRZxH8V1xr3HSkYd6WIxnV7l9IgZWMCYUg0oexuVw/colDQ== X-Received: by 2002:a05:6402:454:b0:4ac:be53:1789 with SMTP id p20-20020a056402045400b004acbe531789mr4162260edw.40.1676997868694; Tue, 21 Feb 2023 08:44:28 -0800 (PST) Received: from smtpclient.apple ([176.41.31.3]) by smtp.gmail.com with ESMTPSA id m25-20020a509999000000b004ad7bf8be72sm6697249edb.53.2023.02.21.08.44.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Feb 2023 08:44:28 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: [PATCH v5] net/gve: add Rx/Tx queue stats as extended stats From: Levend Sayar In-Reply-To: Date: Tue, 21 Feb 2023 19:44:17 +0300 Cc: "Guo, Junfeng" , dev@dpdk.org Content-Transfer-Encoding: 7bit Message-Id: <68DCC243-8E0A-4BE9-8D7F-2D704B427EAE@gmail.com> References: <20230221141350.12335-1-levendsayar@gmail.com> <20230221141814.13674-1-levendsayar@gmail.com> To: Ferruh Yigit X-Mailer: Apple Mail (2.3731.300.101.1.3) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Thanks Ferruh for the review. > On 21 Feb 2023, at 18:58, Ferruh Yigit wrote: > > On 2/21/2023 2:18 PM, Levend Sayar wrote: >> Google Virtual NIC rx/tx queue stats are added as extended stats. >> >> Signed-off-by: Levend Sayar > > Reviewed-by: Ferruh Yigit > > <...> > >> @@ -20,6 +20,7 @@ gve_rx_refill(struct gve_rx_queue *rxq) >> if (nb_alloc <= rxq->nb_avail) { >> diag = rte_pktmbuf_alloc_bulk(rxq->mpool, &rxq->sw_ring[idx], nb_alloc); >> if (diag < 0) { >> + rxq->stats.no_mbufs_bulk++; > > It is not common to record bulk alloc failures, but as 'no_mbufs' > already recorded conventionally, I guess it is OK to keep this extra > stat if it is helpful. >