From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Junjie Chen <junjie.j.chen@intel.com>,
jianfeng.tan@intel.com, mtetsuyah@gmail.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v6 1/2] vhost: add support for interrupt mode
Date: Fri, 13 Apr 2018 11:15:47 +0200 [thread overview]
Message-ID: <68db4761-520a-1bc2-f7dc-fe75078d88c8@redhat.com> (raw)
In-Reply-To: <1523550514-44037-1-git-send-email-junjie.j.chen@intel.com>
On 04/12/2018 06:28 PM, Junjie Chen wrote:
> In some cases we want vhost dequeue work in interrupt mode to
> release cpus to others when no data to transmit. So we install
> interrupt handler of vhost device and interrupt vectors for each
> rx queue when creating new backend according to vhost intrerupt
> configuration. Thus, applications could register a epoll event fd
> to associate rx queues with interrupt vectors.
>
> Signed-off-by: Junjie Chen <junjie.j.chen@intel.com>
> ---
> Changes in v6:
> - rebase code to master
> Changes in v5:
> - update license to DPDK new license format
> - rebase code to master
> Changes in v4:
> - revert back license change
> Changes in v3:
> - handle failure in the middle of intr setup.
> - use vhost API to enable interrupt.
> - rebase to check rxq existence.
> - update vhost API to support guest notification.
> Changes in v2:
> - update rx queue index.
> - fill efd_counter_size for intr handler.
> - update log.
> drivers/net/vhost/rte_eth_vhost.c | 158 +++++++++++++++++++++++++++++++++++++-
> lib/librte_vhost/vhost.c | 14 ++--
> 2 files changed, 163 insertions(+), 9 deletions(-)
>
Applied to dpdk-next-virtio/master.
Please next time run checkpatch before posting, I had to fix below
errors when applying.
Thanks,
Maxime
### [dpdk-dev,v6,1/2] vhost: add support for interrupt mode
CHECK:BRACES: braces {} should be used on all arms of this statement
#208: FILE: drivers/net/vhost/rte_eth_vhost.c:743:
+ if (rte_atomic32_read(&internal->started) == 1) {
[...]
else
[...]
ERROR:TRAILING_WHITESPACE: trailing whitespace
#237: FILE: drivers/net/vhost/rte_eth_vhost.c:939:
+^I$
ERROR:TRAILING_WHITESPACE: trailing whitespace
#282: FILE: lib/librte_vhost/vhost.c:554:
+^Ielse^I$
total: 2 errors, 0 warnings, 225 lines checked
0/1 valid patch
next prev parent reply other threads:[~2018-04-13 9:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 9:59 [dpdk-dev] [PATCH] " Junjie Chen
2018-03-29 14:37 ` [dpdk-dev] [PATCH v2] " Junjie Chen
2018-03-31 4:00 ` Tan, Jianfeng
2018-04-02 8:51 ` Chen, Junjie J
2018-04-03 16:33 ` [dpdk-dev] [PATCH v3] " Junjie Chen
2018-04-04 9:43 ` [dpdk-dev] [PATCH v4] " Junjie Chen
2018-04-08 16:50 ` [dpdk-dev] [PATCH v5] " Junjie Chen
2018-04-12 16:28 ` [dpdk-dev] [PATCH v6 1/2] " Junjie Chen
2018-04-12 12:18 ` Tan, Jianfeng
2018-04-13 9:15 ` Maxime Coquelin [this message]
2018-04-13 10:07 ` Chen, Junjie J
2018-04-12 16:29 ` [dpdk-dev] [PATCH v6 2/2] net/vhost: update license to SPDX format Junjie Chen
2018-04-12 16:43 ` Junjie Chen
2018-04-12 12:21 ` Maxime Coquelin
2018-04-19 1:07 ` Takanari Hayama
2018-04-19 14:55 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68db4761-520a-1bc2-f7dc-fe75078d88c8@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=junjie.j.chen@intel.com \
--cc=mtetsuyah@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).