From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id D98671BC56 for ; Fri, 13 Apr 2018 11:15:50 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4D40E81A88CD; Fri, 13 Apr 2018 09:15:50 +0000 (UTC) Received: from [10.36.112.36] (ovpn-112-36.ams2.redhat.com [10.36.112.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5AEFED7DF6; Fri, 13 Apr 2018 09:15:49 +0000 (UTC) To: Junjie Chen , jianfeng.tan@intel.com, mtetsuyah@gmail.com Cc: dev@dpdk.org References: <1523206226-27205-1-git-send-email-junjie.j.chen@intel.com> <1523550514-44037-1-git-send-email-junjie.j.chen@intel.com> From: Maxime Coquelin Message-ID: <68db4761-520a-1bc2-f7dc-fe75078d88c8@redhat.com> Date: Fri, 13 Apr 2018 11:15:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1523550514-44037-1-git-send-email-junjie.j.chen@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Fri, 13 Apr 2018 09:15:50 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Fri, 13 Apr 2018 09:15:50 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v6 1/2] vhost: add support for interrupt mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 09:15:51 -0000 On 04/12/2018 06:28 PM, Junjie Chen wrote: > In some cases we want vhost dequeue work in interrupt mode to > release cpus to others when no data to transmit. So we install > interrupt handler of vhost device and interrupt vectors for each > rx queue when creating new backend according to vhost intrerupt > configuration. Thus, applications could register a epoll event fd > to associate rx queues with interrupt vectors. > > Signed-off-by: Junjie Chen > --- > Changes in v6: > - rebase code to master > Changes in v5: > - update license to DPDK new license format > - rebase code to master > Changes in v4: > - revert back license change > Changes in v3: > - handle failure in the middle of intr setup. > - use vhost API to enable interrupt. > - rebase to check rxq existence. > - update vhost API to support guest notification. > Changes in v2: > - update rx queue index. > - fill efd_counter_size for intr handler. > - update log. > drivers/net/vhost/rte_eth_vhost.c | 158 +++++++++++++++++++++++++++++++++++++- > lib/librte_vhost/vhost.c | 14 ++-- > 2 files changed, 163 insertions(+), 9 deletions(-) > Applied to dpdk-next-virtio/master. Please next time run checkpatch before posting, I had to fix below errors when applying. Thanks, Maxime ### [dpdk-dev,v6,1/2] vhost: add support for interrupt mode CHECK:BRACES: braces {} should be used on all arms of this statement #208: FILE: drivers/net/vhost/rte_eth_vhost.c:743: + if (rte_atomic32_read(&internal->started) == 1) { [...] else [...] ERROR:TRAILING_WHITESPACE: trailing whitespace #237: FILE: drivers/net/vhost/rte_eth_vhost.c:939: +^I$ ERROR:TRAILING_WHITESPACE: trailing whitespace #282: FILE: lib/librte_vhost/vhost.c:554: +^Ielse^I$ total: 2 errors, 0 warnings, 225 lines checked 0/1 valid patch