From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7C0B0A0548;
	Tue, 31 May 2022 17:22:18 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 296504067B;
	Tue, 31 May 2022 17:22:18 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 11BA040143
 for <dev@dpdk.org>; Tue, 31 May 2022 17:22:17 +0200 (CEST)
Received: from [192.168.1.38] (unknown [188.170.81.145])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 34ED186;
 Tue, 31 May 2022 18:22:16 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 34ED186
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1654010536;
 bh=qkySGQ7whqOHw5q7JasJjp2AjHAeF5daHKdHRuBmfMk=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=ZLg+G2aDJdIDQlDpLMMEiCsNMfmyIdvQFyJsTRFr0S15JOeQ/FB28x9zZxTJ+2vc3
 oHtC8bTj1aOoila5b/CLEj69asOaRED2K/04kDfDytq7wSt/iWu/7p5jknf+S3xkj/
 AuS1ynGfRc/V5gyo4NoRAjDJBZOvQ9zXzaGu8JLo=
Message-ID: <68eeb11c-666d-ada9-e6e4-1922fbba01d1@oktetlabs.ru>
Date: Tue, 31 May 2022 18:22:15 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH V3 0/2] ethdev: fix MAC addrs list
Content-Language: en-US
To: "Min Hu (Connor)" <humin29@huawei.com>, dev@dpdk.org
Cc: ferruh.yigit@intel.com, ktraynor@redhat.com, thomas@monjalon.net
References: <20210922033630.41130-1-humin29@huawei.com>
 <20220514020049.57294-1-humin29@huawei.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
In-Reply-To: <20220514020049.57294-1-humin29@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 5/14/22 05:00, Min Hu (Connor) wrote:
> From: Huisong Li <lihuisong@huawei.com>
> 
> The index zero of rte_eth_dev_data::mac_addrs array is as the default MAC
> index, and other indexes can't be the same as the address corresponding to
> index 0. If we break it, may cause following problems:
> 1) waste of MAC address spaces.
> 2) a fake MAC address in the MAC list, isn't in hardware MAC entries.
> 3) a MAC address is assigned to diffent pool.

The series looks broken in the patchwork. As the result unit tests
are run in a strange way. Please, format patches once again and send v4.