From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <anatoly.burakov@intel.com> Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 0B5822965 for <dev@dpdk.org>; Fri, 27 Jul 2018 10:51:24 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jul 2018 01:51:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,408,1526367600"; d="scan'208";a="70397688" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.252.5.176]) ([10.252.5.176]) by orsmga003.jf.intel.com with ESMTP; 27 Jul 2018 01:51:22 -0700 To: "Pattan, Reshma" <reshma.pattan@intel.com>, Thomas Monjalon <thomas@monjalon.net> Cc: "dev@dpdk.org" <dev@dpdk.org>, "Parthasarathy, JananeeX M" <jananeex.m.parthasarathy@intel.com> References: <1531843225-14638-1-git-send-email-reshma.pattan@intel.com> <9233572.sMqcLjnXGc@xps> <3AEA2BF9852C6F48A459DA490692831F2A376E43@IRSMSX109.ger.corp.intel.com> From: "Burakov, Anatoly" <anatoly.burakov@intel.com> Message-ID: <68f818a6-eb93-4552-b495-ffce656338b3@intel.com> Date: Fri, 27 Jul 2018 09:51:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A376E43@IRSMSX109.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 00/10] Make unit tests great again X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 27 Jul 2018 08:51:25 -0000 On 27-Jul-18 9:36 AM, Pattan, Reshma wrote: > Hi, > >> -----Original Message----- >> From: Thomas Monjalon [mailto:thomas@monjalon.net] >> Sent: Thursday, July 26, 2018 9:05 PM >> To: Pattan, Reshma <reshma.pattan@intel.com> >> Cc: dev@dpdk.org; Burakov, Anatoly <anatoly.burakov@intel.com>; >> Parthasarathy, JananeeX M <jananeex.m.parthasarathy@intel.com> >> Subject: Re: [dpdk-dev] [PATCH v5 00/10] Make unit tests great again >> >> 17/07/2018 18:00, Reshma Pattan: >>> Previously, unit tests were running in groups. There were technical reasons >> why that was the case (mostly having to do with limiting memory), but it was >> hard to maintain and update the autotest script. >>> >>> In 18.05, limiting of memory at DPDK startup was no longer necessary, as >> DPDK allocates memory at runtime as needed. This has the implication that >> the old test grouping can now be retired and replaced with a more sensible >> way of running unit tests (using multiprocessing pool of workers and a queue >> of tests). This patchset accomplishes exactly that. >>> >>> This patchset merges changes done in [1], [2] >>> >>> [1] http://dpdk.org/dev/patchwork/patch/40370/ >>> [2] http://patches.dpdk.org/patch/40373/ >>> >>> Removed unused and duplicate make rules for test-basic, test-mempool, >>> test-ring from make file system in patch 10/10. >>> >>> v4: Removed unused and duplicate make rules for test-basic, >>> test-mempool, test-ring from make file system in patch 10/10. >>> >>> Reshma Pattan (10): >>> autotest: fix printing >>> autotest: fix invalid code on reports >>> autotest: make autotest runner python 2/3 compliant >>> autotest: visually separate different test categories >>> autotest: improve filtering >>> autotest: remove autotest grouping >>> autotest: properly parallelize unit tests >>> autotest: update autotest test case list >>> mk: update make targets for classified testcases >>> mk: remove unnecessary make rules of test >> >> Patches 1 to 7 are from Anatoly. >> Patches 8 and 9 were initiated by Jananee. > > The respective patches have i.e 1 to 7 have Anatolys Signed--off > And 8 and 9 have Jananees Signed-off along with mine. > > I have used git-am. What I am missing here? > > Thanks, > Reshma > The signoff is part of commit message, but the author name is part of commit metadata. I.e. as it stands, if these patches are applied, the commit message says i am the author, but the actual commit metadata says it's you. Use "git show --pretty=fuller" to see who is the author and who is the committer of each commit. To fix each commit, do an interactive rebase, stop after each commit (i.e. mark each commit as "edit") and do git commit --amend --author="Author Name <email@address.com>" (this is a brute force way - a "smarter" way would be to use git filter-branch, but IMO it's overkill unless you do that often and already have all necessary scripts ready and set up :) ) -- Thanks, Anatoly