From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8A9FA052A; Sun, 12 Jul 2020 22:09:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2AAB91C1A0; Sun, 12 Jul 2020 22:09:56 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 5C5251C199 for ; Sun, 12 Jul 2020 22:09:55 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200712200954euoutp0149690fc9dece7f39f4277a0114ae9693~hGj1s38DV0138001380euoutp01T; Sun, 12 Jul 2020 20:09:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200712200954euoutp0149690fc9dece7f39f4277a0114ae9693~hGj1s38DV0138001380euoutp01T DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594584594; bh=DHcUz5wjTUrIeBD8hhBAnTEnXGxdM4uhm6AQte2OM54=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=dNxQvLZXSgnKbs8QvstaC99Ju3VoXjVwHeRz/qDqPK9qYVbP7y48pMN0mBpj32Y8G K0dsg3GQCryqjHGYL6fQ/vBFMfueF5qiT1NZigCsgF+KPYz+iwI388Q+ExkxaZZ0P0 VmC3GBX8mYEm1J5qWJTQSbiwji6sgKIeY4zO0Q4Q= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200712200953eucas1p271c4e3d2df0b201ee874866b2757882a~hGj1Mc7EO2476424764eucas1p2k; Sun, 12 Jul 2020 20:09:53 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id BA.C8.05997.11E6B0F5; Sun, 12 Jul 2020 21:09:53 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200712200953eucas1p2f379051565bd397b40c6e4202762b51d~hGj00jL822269022690eucas1p2k; Sun, 12 Jul 2020 20:09:53 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200712200953eusmtrp219e1cc937aeed0d3e16d0cc55e89995a~hGj0zgFNy2843328433eusmtrp2O; Sun, 12 Jul 2020 20:09:53 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-73-5f0b6e117e14 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 07.18.06314.11E6B0F5; Sun, 12 Jul 2020 21:09:53 +0100 (BST) Received: from [106.109.129.29] (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200712200951eusmtip115621fb70594e877e9bb026ed0bc9940~hGjy_p0kX2886428864eusmtip1n; Sun, 12 Jul 2020 20:09:51 +0000 (GMT) To: Thomas Monjalon Cc: dev@dpdk.org, v.kuramshin@samsung.com, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com, olivier.matz@6wind.com From: Ivan Dyukov Message-ID: <69051bbb-9ab7-18bd-9baf-5fe2e77628e9@samsung.com> Date: Sun, 12 Jul 2020 23:09:50 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <1954009.Q9tCs6qVOH@thomas> Content-Transfer-Encoding: 8bit Content-Language: ru-RU X-Brightmail-Tracker: H4sIAAAAAAAAA01SbUxbZRTOe9/be2/LSi5lysk0KnV+4JS5aeK7ZGF+kHiNPyQxJgZlrLI7 WKQd6QUm7g/ixNoCc3xsrGBlELOJi80YpbQpEzpHqWXd2Ee2ubIxNq3UbXyMiSAT294u8u85 z3mec86THA5rhphV3HZDqWg06Iq1jIruGZwPvpBiSMp/0fRlOrEP2xAZv9qByVjjKEMsU7sp cqlzE/E4WxWk/lolRerqpyniPGxmyK2xKprcmXFSJNQXYMmMN8yS2tMtiIQXI5gcaLuLyGmb Q0HmB9wMmVxsp0ndwgVE9nQPIeKoOkoRX800TRpdvYhUm3ky9f0hlnSEHiMzY0M0CVw+xpIj 90YwcQzfR2Svz47IqeolxavpwsieEBIW2r5TCB2eCUpoODiChcHL+1ihxm+jhKN3eilh8vgF Rqjr7kTCL+MWLPxw828mJylXtXGrWLy9XDSuzdqiKjp/vI4t6VJ90mP5jKpENs6MlBzwL4Mn 6GbNSMVp+MMILppOYrmYRWA/cY2Ri7sIDv4RpB5YLMNVCcuhqGrgx4RqEkFDpQ/FVKn823Bv 3242hlfyGXBlzopiIszbGAj/dp2ONRj+WQiYbPGxaj4LqiPjcZ7mnwJXy3B80EP8+7BUf4OW NSngP3AzijlOGfV6zm+J0Zh/HD53tGAZp8GUcyB+EPANSjjXNK2Qz86G27cGsIxTIeLrZmX8 KCy5vk1E2wVzXRdZ2WxCcLX9i4RoE3T/GWRji3E0jd29VqZfgz5POE4DnwyXbqfINyRDfc9+ LNNqMFVrZLUW+v1nEzTA/X9WfI201mW5rMvCWJeFsf6/tg3RnShNLJP0haK03iDuzJR0eqnM UJhZsEPfhaL/HfjXN9uL3IsfeRHPIe0K9ZnMpHyNQlcuVei9CDisXal+/VRgs0a9VVfxqWjc kW8sKxYlL3qEo7Vp6pfaJ/I0fKGuVPxYFEtE44MuxSlXVaKn/TjcnPoXWtj7bv+ZAlfDM4P2 vrzRJ47l5ZbsVFfsj2SvyXmL2xX8av7nN5zJZjHjFXfTN5vnLWX6YE25v6mo/Uh688TI6g98 z39Y8GurJ6TNbV29bePYe7VZP83aQLJvWBPBoXceduQo+zM2ZJ8YLeWfvD73e63XNWSsbWye 6HlTS0tFunXPYaOk+w95Zc012wMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRiA+845O+d4GZym1ofQbV2ooFPTbO+6WATRoQsE9aOy0mEHldxm O5tkFJmJ2LR1vzhtWHbVwLysqWngqNS2KNOki9UyQVaWl5BK7LK1Av89vO/zwPfBy5KK17Jo Nk1vEo16bbqSDqXcv1reLJioD0tcVPMqDCo9dgQ9b8tI8J55Q0PBYC4BL8pXQqOzRAan3mUT YD01RIDzhoWGfm8OBV+GnQR0N7kZGHb1MXDsSTGCvrGPJBSVfkXwxO6QwY/mBhoGxi5TYB19 juB4bSsCR04VAS2FQxScqa9DkGfhYPDmdQbKuqfCsLeVAvfLGgZujbST4PD8RHCypRLB47zf slUzhPbj3UgYLb0qE8oafYRw+lI7KTx8eY4RCtvshFD1pY4QBu49pwVrbTkSHvUUkEJF73d6 U9h2frnRYDaJ01MNkmmFMkEFMbxKA3zMYg2vilXvXBoTp1wYv3y3mJ6WKRoXxifxqZ33rExG dei+OwWHiWxkZy0ohMXcYlzgyWEsKJRVcFcRLvW5CAti/QuMP/WSQScCj3VZ6KDzGWHP2btM YBHBrccj53L/ciQ3D7/+ZkMBieTsNPZVnaeCxS+Ez3Y5qIBFc3OxO99OBFjOxeO8jz1/5xQ3 G9cXe1CAo7it+GvzfTroTMRtRb1U4EUh/raxMykwJrkl2F7zngzyNHzEUfyPJ+NBZzN9Ails 42rbuMQ2LrGNS0oRVY4iRbOkS9FJKl7S6iSzPoVPNuiqkf+w7jz8UVOHnlVtdiGORcpw+VM+ LFEh02ZKWToXwiypjJSvfuzepZDv1mbtF42GRKM5XZRcKM7/t5NkdFSywX+melOiKk6lBo1K HauOXQLKyfJ8rnmHgkvRmsQ9opghGv93BBsSnY2yzdP1/QmKNfyU+wdmIW94blH10Ytr9yUd 9O21XqnY9iE/IYN75qv4qfFc22pPv7D9t7BuRWuXN5/pyHrQdnHSpG8DEfPEy0LInNqIspKG vi274jpaZiY7N0540VTZdzjJu3a0cGDDUOa7Rd2iOmePxnyi5HbsMl/4yKyGQ6v6OztoJSWl alXzSaOk/QPwnSesbgMAAA== X-CMS-MailID: 20200712200953eucas1p2f379051565bd397b40c6e4202762b51d X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200712073536eucas1p189cc44dc6b62d6a5a4eb3456e5e4fb58 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200712073536eucas1p189cc44dc6b62d6a5a4eb3456e5e4fb58 References: <20200427095737.11082-1-i.dyukov@samsung.com> <1652895.iZPJ0jMcVD@thomas> <424d7367-e947-0d48-ff6e-879ae3268b27@samsung.com> <1954009.Q9tCs6qVOH@thomas> Subject: Re: [dpdk-dev] [PATCH v8 02/24] ethdev: add a link status text representation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12.07.2020 10:35, Thomas Monjalon пишет: > 11/07/2020 20:58, Ivan Dyukov: >> 11.07.2020 14:27, Thomas Monjalon пишет: >>> 11/07/2020 12:43, Ivan Dyukov: >>>> +__rte_experimental >>>> +int rte_eth_link_printf(const char *const fmt, >>>> + const struct rte_eth_link *eth_link); >>>> >>> Maybe I missed your reply, >>> I still don't understand the need for this function. >>> >> I used it few times in apps in this patchset. It allows to avoid code >> duplication in examples. i.e. declare array, call rte_eth_link_to_str, >> call printf. >> >> It's simple and usefull function. Why not? > Why not is not a good justification :) I still don't understand your objections against this tiny shiny function. > We must avoid adding too much in the API. > > I agree that this function is superfluous for DPDK library, but I would note that it's not just 'DPDK library' change, it's 'DPDK library + DPDK examples' change. With this change, the entire code is getting better. The new function adds usefull functionality. It allows to reduce code size and remove duplicates. so technically it's good change but practically I would like to ask maintainers to decide this. P.S. I'll we on vacation next two weeks. May be I'll check email but I don't guarantee that.