DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Nicolas Chautru <nicolas.chautru@intel.com>,
	dev@dpdk.org, thomas@monjalon.net
Cc: trix@redhat.com, mdr@ashroe.eu, bruce.richardson@intel.com,
	hemant.agrawal@nxp.com, david.marchand@redhat.com,
	stephen@networkplumber.org, hernan.vargas@intel.com
Subject: Re: [PATCH v6 03/14] baseband/acc: rename directory from acc100 to acc
Date: Tue, 27 Sep 2022 15:01:23 +0200	[thread overview]
Message-ID: <6909cc3c-b869-ecf6-590c-9d91a2c15b5f@redhat.com> (raw)
In-Reply-To: <20220924005048.20302-4-nicolas.chautru@intel.com>



On 9/24/22 02:50, Nicolas Chautru wrote:
> From: Nic Chautru <nicolas.chautru@intel.com>
> 
> Using a common directory for the ACC PMDs
> 
> Signed-off-by: Nic Chautru <nicolas.chautru@intel.com>
> ---
>   MAINTAINERS                                           | 2 +-
>   app/test-bbdev/meson.build                            | 4 ++--
>   app/test-bbdev/test_bbdev_perf.c                      | 4 ++--
>   drivers/baseband/{acc100 => acc}/acc100_pf_enum.h     | 0
>   drivers/baseband/{acc100 => acc}/acc100_pmd.h         | 0
>   drivers/baseband/{acc100 => acc}/acc100_vf_enum.h     | 0
>   drivers/baseband/{acc100 => acc}/acc101_pmd.h         | 0
>   drivers/baseband/{acc100 => acc}/acc_common.h         | 0
>   drivers/baseband/{acc100 => acc}/meson.build          | 0
>   drivers/baseband/{acc100 => acc}/rte_acc100_cfg.h     | 0
>   drivers/baseband/{acc100 => acc}/rte_acc100_pmd.c     | 0
>   drivers/baseband/{acc100 => acc}/rte_acc_common_cfg.h | 0
>   drivers/baseband/{acc100 => acc}/version.map          | 0
>   drivers/baseband/meson.build                          | 2 +-
>   14 files changed, 6 insertions(+), 6 deletions(-)
>   rename drivers/baseband/{acc100 => acc}/acc100_pf_enum.h (100%)
>   rename drivers/baseband/{acc100 => acc}/acc100_pmd.h (100%)
>   rename drivers/baseband/{acc100 => acc}/acc100_vf_enum.h (100%)
>   rename drivers/baseband/{acc100 => acc}/acc101_pmd.h (100%)
>   rename drivers/baseband/{acc100 => acc}/acc_common.h (100%)
>   rename drivers/baseband/{acc100 => acc}/meson.build (100%)
>   rename drivers/baseband/{acc100 => acc}/rte_acc100_cfg.h (100%)
>   rename drivers/baseband/{acc100 => acc}/rte_acc100_pmd.c (100%)
>   rename drivers/baseband/{acc100 => acc}/rte_acc_common_cfg.h (100%)
>   rename drivers/baseband/{acc100 => acc}/version.map (100%)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 32ffdd1a61..52afd5d2e0 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1336,7 +1336,7 @@ F: doc/guides/bbdevs/features/fpga_lte_fec.ini
>   F: drivers/baseband/fpga_5gnr_fec/
>   F: doc/guides/bbdevs/fpga_5gnr_fec.rst
>   F: doc/guides/bbdevs/features/fpga_5gnr_fec.ini
> -F: drivers/baseband/acc100/
> +F: drivers/baseband/acc/
>   F: doc/guides/bbdevs/acc100.rst
>   F: doc/guides/bbdevs/features/acc100.ini
>   F: doc/guides/bbdevs/features/acc101.ini
> diff --git a/app/test-bbdev/meson.build b/app/test-bbdev/meson.build
> index 76d4c26999..cd6a5089d5 100644
> --- a/app/test-bbdev/meson.build
> +++ b/app/test-bbdev/meson.build
> @@ -20,8 +20,8 @@ endif
>   if dpdk_conf.has('RTE_BASEBAND_FPGA_5GNR_FEC')
>       deps += ['baseband_fpga_5gnr_fec']
>   endif
> -if dpdk_conf.has('RTE_BASEBAND_ACC100')
> -    deps += ['baseband_acc100']
> +if dpdk_conf.has('RTE_BASEBAND_ACC')
> +    deps += ['baseband_acc']
>   endif
>   if dpdk_conf.has('RTE_LIBRTE_PMD_BBDEV_LA12XX')
>       deps += ['baseband_la12xx']
> diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
> index af9ceca67b..41c78ded7d 100644
> --- a/app/test-bbdev/test_bbdev_perf.c
> +++ b/app/test-bbdev/test_bbdev_perf.c
> @@ -52,7 +52,7 @@
>   #define DL_5G_LOAD_BALANCE 128
>   #endif
>   
> -#ifdef RTE_BASEBAND_ACC100
> +#ifdef RTE_BASEBAND_ACC
>   #include <rte_acc100_cfg.h>
>   #define ACC100PF_DRIVER_NAME   ("intel_acc100_pf")
>   #define ACC100VF_DRIVER_NAME   ("intel_acc100_vf")
> @@ -705,7 +705,7 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *info,
>   				info->dev_name);
>   	}
>   #endif
> -#ifdef RTE_BASEBAND_ACC100
> +#ifdef RTE_BASEBAND_ACC
>   	if ((get_init_device() == true) &&
>   			(!strcmp(info->drv.driver_name, ACC100PF_DRIVER_NAME))) {
>   		struct rte_acc_conf conf;
> diff --git a/drivers/baseband/acc100/acc100_pf_enum.h b/drivers/baseband/acc/acc100_pf_enum.h
> similarity index 100%
> rename from drivers/baseband/acc100/acc100_pf_enum.h
> rename to drivers/baseband/acc/acc100_pf_enum.h
> diff --git a/drivers/baseband/acc100/acc100_pmd.h b/drivers/baseband/acc/acc100_pmd.h
> similarity index 100%
> rename from drivers/baseband/acc100/acc100_pmd.h
> rename to drivers/baseband/acc/acc100_pmd.h
> diff --git a/drivers/baseband/acc100/acc100_vf_enum.h b/drivers/baseband/acc/acc100_vf_enum.h
> similarity index 100%
> rename from drivers/baseband/acc100/acc100_vf_enum.h
> rename to drivers/baseband/acc/acc100_vf_enum.h
> diff --git a/drivers/baseband/acc100/acc101_pmd.h b/drivers/baseband/acc/acc101_pmd.h
> similarity index 100%
> rename from drivers/baseband/acc100/acc101_pmd.h
> rename to drivers/baseband/acc/acc101_pmd.h
> diff --git a/drivers/baseband/acc100/acc_common.h b/drivers/baseband/acc/acc_common.h
> similarity index 100%
> rename from drivers/baseband/acc100/acc_common.h
> rename to drivers/baseband/acc/acc_common.h
> diff --git a/drivers/baseband/acc100/meson.build b/drivers/baseband/acc/meson.build
> similarity index 100%
> rename from drivers/baseband/acc100/meson.build
> rename to drivers/baseband/acc/meson.build
> diff --git a/drivers/baseband/acc100/rte_acc100_cfg.h b/drivers/baseband/acc/rte_acc100_cfg.h
> similarity index 100%
> rename from drivers/baseband/acc100/rte_acc100_cfg.h
> rename to drivers/baseband/acc/rte_acc100_cfg.h
> diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c
> similarity index 100%
> rename from drivers/baseband/acc100/rte_acc100_pmd.c
> rename to drivers/baseband/acc/rte_acc100_pmd.c
> diff --git a/drivers/baseband/acc100/rte_acc_common_cfg.h b/drivers/baseband/acc/rte_acc_common_cfg.h
> similarity index 100%
> rename from drivers/baseband/acc100/rte_acc_common_cfg.h
> rename to drivers/baseband/acc/rte_acc_common_cfg.h
> diff --git a/drivers/baseband/acc100/version.map b/drivers/baseband/acc/version.map
> similarity index 100%
> rename from drivers/baseband/acc100/version.map
> rename to drivers/baseband/acc/version.map
> diff --git a/drivers/baseband/meson.build b/drivers/baseband/meson.build
> index 686e98b2ed..1d732da882 100644
> --- a/drivers/baseband/meson.build
> +++ b/drivers/baseband/meson.build
> @@ -6,7 +6,7 @@ if is_windows
>   endif
>   
>   drivers = [
> -        'acc100',
> +        'acc',
>           'fpga_5gnr_fec',
>           'fpga_lte_fec',
>           'la12xx',


Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


  reply	other threads:[~2022-09-27 13:01 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-24  0:50 From: Nicolas Chautru <nicolas.chautru@intel.com> Nicolas Chautru
2022-09-24  0:50 ` [PATCH v6 01/14] baseband/acc100: remove unused registers Nicolas Chautru
2022-09-24  0:50 ` [PATCH v6 02/14] baseband/acc100: refactor to segregate common code Nicolas Chautru
2022-09-24  0:50 ` [PATCH v6 03/14] baseband/acc: rename directory from acc100 to acc Nicolas Chautru
2022-09-27 13:01   ` Maxime Coquelin [this message]
2022-09-24  0:50 ` [PATCH v6 04/14] baseband/acc: introduce PMD for ACC200 Nicolas Chautru
2022-09-24  0:50 ` [PATCH v6 05/14] baseband/acc: add HW register definitions " Nicolas Chautru
2022-09-24  0:50 ` [PATCH v6 06/14] baseband/acc: add info get function " Nicolas Chautru
2022-09-27 13:03   ` Maxime Coquelin
2022-09-24  0:50 ` [PATCH v6 07/14] baseband/acc: add queue configuration " Nicolas Chautru
2022-09-27 13:06   ` Maxime Coquelin
2022-09-24  0:50 ` [PATCH v6 08/14] baseband/acc: add LDPC processing functions Nicolas Chautru
2022-09-27 13:21   ` Maxime Coquelin
2022-09-24  0:50 ` [PATCH v6 09/14] baseband/acc: add LTE " Nicolas Chautru
2022-09-27 13:43   ` Maxime Coquelin
2022-09-29 21:13     ` Chautru, Nicolas
2022-09-24  0:50 ` [PATCH v6 10/14] baseband/acc: add support for FFT operations Nicolas Chautru
2022-09-27 13:45   ` Maxime Coquelin
2022-09-29 21:14     ` Chautru, Nicolas
2022-09-24  0:50 ` [PATCH v6 11/14] baseband/acc: support interrupt Nicolas Chautru
2022-09-27 13:49   ` Maxime Coquelin
2022-09-29 21:15     ` Chautru, Nicolas
2022-09-24  0:50 ` [PATCH v6 12/14] baseband/acc: add device status and vf2pf comms Nicolas Chautru
2022-09-24  0:50 ` [PATCH v6 13/14] baseband/acc: add PF configure companion function Nicolas Chautru
2022-09-24  0:50 ` [PATCH v6 14/14] baseband/acc: simplify meson dependency Nicolas Chautru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6909cc3c-b869-ecf6-590c-9d91a2c15b5f@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=hernan.vargas@intel.com \
    --cc=mdr@ashroe.eu \
    --cc=nicolas.chautru@intel.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).