Re: [dpdk-dev] [PATCH 3/6] crypto/mvsam: add support for HMAC SHA224

[Akhil Goyal <akhil.goyal@nxp.com>]

Hi Tomasz,

On 8/24/2018 7:24 PM, Tomasz Duszynski wrote:
> Add support for the HMAC SHA224 authentication algorithm.
>
> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> Reviewed-by: Natalie Samsonov <nsamsono@marvell.com>
> ---
>   drivers/crypto/mvsam/rte_mrvl_pmd.c     |  3 +++
>   drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 21 +++++++++++++++++++++
>   2 files changed, 24 insertions(+)
>
> diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd.c b/drivers/crypto/mvsam/rte_mrvl_pmd.c
> index 9d130b1..5ef4139 100644
> --- a/drivers/crypto/mvsam/rte_mrvl_pmd.c
> +++ b/drivers/crypto/mvsam/rte_mrvl_pmd.c
> @@ -113,6 +113,9 @@ struct auth_params_mapping auth_map[RTE_CRYPTO_AUTH_LIST_END] = {
>   	[RTE_CRYPTO_AUTH_SHA1] = {
>   		.supported = ALGO_SUPPORTED,
>   		.auth_alg = SAM_AUTH_HASH_SHA1 },
> +	[RTE_CRYPTO_AUTH_SHA224_HMAC] = {
> +		.supported = ALGO_SUPPORTED,
> +		.auth_alg = SAM_AUTH_HMAC_SHA2_224 },
>   	[RTE_CRYPTO_AUTH_SHA224] = {
>   		.supported = ALGO_SUPPORTED,
>   		.auth_alg = SAM_AUTH_HASH_SHA2_224 },
> diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
> index e2cfc07..d253b8f 100644
> --- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
> +++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
> @@ -97,6 +97,27 @@ static const struct rte_cryptodev_capabilities
>   			}, }
>   		}, }
>   	},
> +	{
> +		/* SHA224 HMAC */
> +		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
> +		{.sym = {
> +			.xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
> +			{.auth = {
> +				.algo = RTE_CRYPTO_AUTH_SHA224_HMAC,
> +				.block_size = 64,
> +				.key_size = {
> +					.min = 1,
> +					.max = 64,
> +					.increment = 1
> +				},
> +				.digest_size = {
> +					.min = 28,
> +					.max = 28,
> +					.increment = 0
> +				},
> +			}, }
> +		}, }
> +	},
>   	{	/* SHA224 */
>   		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
>   		{.sym = {
doc shall also be updated for each of the new algorithm supported.

Also please rephrase the subject as
crypto/mvsam: support for HMAC SHA224

Please change the subject for other patches as well.

Thanks,
Akhil