From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF65DA04B5; Tue, 27 Oct 2020 09:52:14 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CD7442BD3; Tue, 27 Oct 2020 09:52:13 +0100 (CET) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 8AFDC2B9D for ; Tue, 27 Oct 2020 09:52:12 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id EB755580272; Tue, 27 Oct 2020 04:52:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 27 Oct 2020 04:52:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 2g0Z5tjx//gH+zvjv5T6aDQG+XofHyruZsDOxw0gm+I=; b=L9V5JwgHqQZN9LM1 z5GJ5v7V/t7p7gA7zAD3nmOPVaD1Lb1kC7DQfXCnqr0wH6NuiGiohWRZfCBSvKa+ a3ABzzyLHS8qnZhi7aRrgMY/csS8LonRYnpq/mYaZf5TMmz0EXeMLKHUgYBliQ0s i/355x56MImfh+g4el6Jlnvrg1wee7fldQSyQIW1owiGOw7r/xXEItm3iPPmIC5S RWusk86nLD/jBoBJBMJF8xTL1IEwIRfT35MqzfbWoCLQbSXOjExvAVzduIgAC1xG GXAQeD5+03Hb36a4n+RZQMDZYqBB8FaHISsp/5i5ittPy339fLLY8P4mkv9v+W/N IQNAVA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=2g0Z5tjx//gH+zvjv5T6aDQG+XofHyruZsDOxw0gm +I=; b=LQtgAZpwtc0VuJbB9Il/f5oANnld9jbks4Pxwy4InLKBLiODnEPMJPHKk tSgjo1Uw5re1aMDV3XJK4uOS8GWZJ3iGDSO2rLzH760Rpx7DyvBAEB5F3tCqz/mn 87002UhTdQcpwUKufMLush6lORkhicgTdSy2WIpp2wRbgduW2iP1qtCNYVFOKUDk HSKX9QO9Z/gGcyyl1I+pMbTRGm3Sez9y/2NHQC4FlQrXzxSMAvS1vxfFYQODUKNT hfMbHJvnWsKeHrLou2mdrz/5O2FZrJRxclOw0ffytIfa76Xw3WomRyXifgBSv7ut SJwSnVUc86Ha4yGmHMphHHHbMFyqg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrkeekgdduvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 284B3306467D; Tue, 27 Oct 2020 04:52:08 -0400 (EDT) From: Thomas Monjalon To: "Wang, Haiyue" Cc: "dev@dpdk.org" , "Yigit, Ferruh" , "david.marchand@redhat.com" , "Richardson, Bruce" , "olivier.matz@6wind.com" , "andrew.rybchenko@oktetlabs.ru" , "akhil.goyal@nxp.com" , "Doherty, Declan" , Ankur Dwivedi , Anoob Joseph , "Guo, Jia" , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , "Nicolau, Radu" , Ray Kinsella , Neil Horman Date: Tue, 27 Oct 2020 09:52:04 +0100 Message-ID: <6914016.8XNVhmot91@thomas> In-Reply-To: References: <20201026052105.1561859-1-thomas@monjalon.net> <20201026222013.2147904-6-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 05/15] security: switch metadata to dynamic mbuf field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/10/2020 03:01, Wang, Haiyue: > From: Thomas Monjalon > For ixgbe PMD, > > Acked-by: Haiyue Wang > > But I feel that 'rte_security_dynfield' name is too generic, can it be > more specific about what the field is used for ? > > Like below ;-) > > #define RTE_SECURITY_DEV_METADATA(m) \ > RTE_MBUF_DYNFIELD((m), \ > rte_security_dev_metadata_offset, \ > RTE_SECURITY_DEV_METADATA_TYPE *) Yes rte_security_dynfield is too much generic, as well as RTE_SECURITY_DEV_METADATA. It seems there are different data stored in this field. We should have different fields for different data. But such cleanup is another step for someone else.