From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C80BFA0A02; Wed, 24 Mar 2021 18:15:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45D76140F61; Wed, 24 Mar 2021 18:15:43 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 4532D140F60 for ; Wed, 24 Mar 2021 18:15:41 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id A4AE95C015A; Wed, 24 Mar 2021 13:15:40 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 24 Mar 2021 13:15:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= ci9KWry2oAVWaot1F2ioVN5rFgsJ7MD6OCm6PIIhDJo=; b=MWrNDo7uTt+UA+Hg ndj049LVsizTkUzeBmHmxW8o/UYngdXK0v8E703c54U83JdaBjApL6M6RyjMrcGZ k32VqawEumkCx+8StqxToqrkGZhdx0sxWduXh1jgxXcFBXAgKc5RfvQh14EWqhpC aQT502GEeeutXjjy7zb5IsUdswD04ULD73pkP6RYj5D/Vj0m0QBuM/tSHVClc5uw Zl//0WJuxSe7yQYpoj0m8u2egvYq2vPoyFgtnV6j5yKAaM/fo8eYU1VLgD3rfndt ySNFSJRQQ3s2M3/2MxBPa3HsYEDngpCDY6eru/OzX4Y5JCuYh2XGzg17FANtu2ro WJwnpA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ci9KWry2oAVWaot1F2ioVN5rFgsJ7MD6OCm6PIIhD Jo=; b=MLRk7PyZ02YYWvPuFHT9w+/ufCWC+m+dfjz1ZQP74kGiGimJRfsIDbmKl KE2gnmA7bxzO8tRfNUunzUr0iGHrLMIfXScPPyu6Om6NJamf9gwKg5Mn/KZgMHVj SbIl4zX7lgh7A0AxuCrWn3QulNtBpnn186DkSSF2UvUbz0BBSZ2zTYgaPq1SUwn1 ACQVhbmu5pjnV5n+HLSEUIfCm+Og2qNnlKb3inY8/Cvm2qHaUJ0RlFJBdsJxenxj 2akv9s0FZK+Ai3xHYCcpebRwVJIk0kfz/4OUKQ/2UgVH7a4RFxOH2+YEl0VDFJxP OCQ1I5bmsY75J4veJDft2QcSbO0hA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudegkedgleeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4207024033F; Wed, 24 Mar 2021 13:15:39 -0400 (EDT) From: Thomas Monjalon To: Kathleen Capella Cc: dev@dpdk.org, nd@arm.com, honnappa.nagarahalli@arm.com Date: Wed, 24 Mar 2021 18:15:38 +0100 Message-ID: <6914149.Zb7rk1ssy2@thomas> In-Reply-To: <20210223182300.29817-1-kathleen.capella@arm.com> References: <20210223182300.29817-1-kathleen.capella@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix TX burst queue drain edge case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/02/2021 19:23, Kathleen Capella: > Initialize prev_tsc to cur_tsc. This avoids running the TX queue drain > in the first iteration of the packet processing loop. Is it really a fix? What was broken? Isn't it an optimization? > Fixes: af75078fece3 ("first public release") If it's really a fix, we should probably backport it, so Cc: stable@dpdk.org > Signed-off-by: Kathleen Capella > Reviewed-by: Honnappa Nagarahalli