From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 270895A1F for ; Thu, 12 May 2016 23:44:52 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id n129so161152wmn.1 for ; Thu, 12 May 2016 14:44:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=VMXxbM8Zh4gjV7SRlxagcOHRpULa1cOtCZjFIh6yHNE=; b=Nm2aYIYWVWhgwbJ/8T94s/EO4sPZytuIede8D8hN3XPe/gFp4ZpnS/2aVXuE1Xz+15 SIn30jpUwrsQDAPxiYc4OXnzrF/h5ajabYVh7RqGzCWEPy8bY5PXs7M4xXyl2chsYyuU ddHGypRSm8nyvqP2/yFxBa36QBWFBGfzM9oCSeKjGza85keI6SOQ8R33yrsLLFJfya2W LP++/OZroQkCm1L+0k8iM2N9+JsvL7sZi9TsZtV8xusSxtCUdqgUp13kcTaIyXPTgmVG QWb+S1K7SnXTK1+Ad5diDzfVETLZ/jPpapSEvTYV452heMClCEi4HJRv15QLbm8ilZqL j2AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=VMXxbM8Zh4gjV7SRlxagcOHRpULa1cOtCZjFIh6yHNE=; b=BgZ4ViKSBvnU2BeHOXBuSMdHzuby6Oj6CWvQaDKL9b5NhAsC0bU3inFtAcTJZpaeQi AOGzQhnHtFR0z/GDDOwP7zsOMcz9zwSGBcfTnahvFi5nQCNvrDjo1SdqzGp6w0wqpF0Z rJhs+0rLLttT7FUDIb5i4gfKcbczvzzOJ5hUKBwXWhWBS0WXdYsrwTpnj/5H/hgep3LG pX6DEpwBUIVzRHp4trEmibxSCCZBJYgliyOAggc+5tAkEChEYVXos4CXtTWFtNHsN9Ai /kPPyhlL4ocwO7RRZUYqC1heFypoGeVGb59zdVEws2OmknLGXPwBLRrLFaJP8RWzix6J WkMg== X-Gm-Message-State: AOPr4FVRpjB4649TcLH/RSB7UVI+yeFaIHguG7ri/Osu8JA5DWqBAX/Z9kY4WxrXIM/9vCzG X-Received: by 10.194.186.237 with SMTP id fn13mr12621930wjc.47.1463089491905; Thu, 12 May 2016 14:44:51 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id kz1sm15322676wjc.46.2016.05.12.14.44.50 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 12 May 2016 14:44:51 -0700 (PDT) From: Thomas Monjalon To: Jan Viktorin Cc: dev@dpdk.org, David Marchand , Bruce Richardson Date: Thu, 12 May 2016 23:44:50 +0200 Message-ID: <6917242.TZ3GTNlPop@xps13> User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160512230044.654b1588@jvn> References: <1462904011-29838-1-git-send-email-viktorin@rehivetech.com> <1659775.2ddTAuyrkI@xps13> <20160512230044.654b1588@jvn> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 06/11] app/test: use linked list to store PCI drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2016 21:44:52 -0000 2016-05-12 23:00, Jan Viktorin: > On Thu, 12 May 2016 18:08:16 +0200 > Thomas Monjalon wrote: > > > 2016-05-12 17:53, Jan Viktorin: > > > On Thu, 12 May 2016 17:31:28 +0200 > > > Thomas Monjalon wrote: > > > > > > > 2016-05-10 20:13, Jan Viktorin: > > > > > The test unregisters all real drivers before starting into an array. This > > > > > inflexiable as we can use a linked list for this purpose. > > > > > > > > I don't understand this. Maybe some words are missing. > > > > > > Better? > > > > > > The test unregisters all real drivers before starting (stored into an array). > > > This is inflexiable (due to its fixed size) and we can use a linked list for > > > this purpose. > > > > Better with a past tense? "The test was unregistering..." > > No. This patch does not change the semantics (well, it does, because > the list of drivers become global but that's all). The test still > unregisters the drivers. That is the important fact to consider. > > Perhaps: > > The test unregisters all drivers before start. The drivers were stored > into a fixed-sized array. This is inflexible. This patch change this to > utilize a linked list for the same purpose. Yes better. Thanks