From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1E177A0C3F;
	Mon, 28 Jun 2021 13:13:36 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A5EEF40692;
	Mon, 28 Jun 2021 13:13:35 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id D83844068A
 for <dev@dpdk.org>; Mon, 28 Jun 2021 13:13:33 +0200 (CEST)
Received: from [192.168.1.71] (unknown [188.170.72.30])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 43B177F502;
 Mon, 28 Jun 2021 14:13:33 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 43B177F502
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1624878813;
 bh=T1P8PtCbaMid/6umQ0kp3/JEZZLZD1MmUZ04USZ/NIY=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=VwGS/tf6E+apazxXG117wHI7V3fDLFkK0aylv9OeupTj+lrJUObv0AoEln2rTs4vW
 qBC9OfMHATX/uJ71aaa1zGzumLOBrPA1WPiNYcROAVDIkPr3eMXrtmItvPl6bDKcEg
 +PpSMGCfGgz/DgQQC3yPCkEzfbBgmTsExBwTjw9o=
To: Heinrich Kuhn <heinrich.kuhn@netronome.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
References: <20210518104115.1427712-1-ferruh.yigit@intel.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Message-ID: <691e140d-ecd2-c963-0dc6-709b40be7f2b@oktetlabs.ru>
Date: Mon, 28 Jun 2021 14:13:32 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210518104115.1427712-1-ferruh.yigit@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] net/nfp: remove compile time log
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Heinrich,

could you take a look at the patch?

Thanks,
Andrew.

On 5/18/21 1:41 PM, Ferruh Yigit wrote:
> Logging should be converted to dynamic log.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>   drivers/net/nfp/nfp_net_logs.h | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/net/nfp/nfp_net_logs.h b/drivers/net/nfp/nfp_net_logs.h
> index 27dd87611b94..76cc94cb6565 100644
> --- a/drivers/net/nfp/nfp_net_logs.h
> +++ b/drivers/net/nfp/nfp_net_logs.h
> @@ -30,14 +30,7 @@ extern int nfp_logtype_init;
>   #define ASSERT(x) do { } while (0)
>   #endif
>   
> -#define RTE_LIBRTE_NFP_NET_DEBUG_CPP
> -
> -#ifdef RTE_LIBRTE_NFP_NET_DEBUG_CPP
> -#define PMD_CPP_LOG(level, fmt, args...) \
> -	RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args)
> -#else
>   #define PMD_CPP_LOG(level, fmt, args...) do { } while (0)
> -#endif
>   
>   extern int nfp_logtype_driver;
>   #define PMD_DRV_LOG(level, fmt, args...) \
>